Commit Graph

52 Commits

Author SHA1 Message Date
Bernd Verst 8b3672c91e
Merge branch 'master' into feat/rabbitmq-tls 2022-12-19 15:31:47 -08:00
seachen e59dfd63c0 feature: add context to lock&pubsub API
Signed-off-by: seachen <seachen@tencent.com>
2022-12-14 19:37:24 +08:00
spike 1d9f3358e4 Add rabbitmq tls metadata
Signed-off-by: spike <hello@spike.wiki>
2022-11-13 15:17:50 +08:00
Bernd Verst 462e2faadc Upgrade linter and fix linter issues
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
2022-11-11 13:19:57 -08:00
Taction 9870c5e33b
Add pubsub rabbitmq TTL support (#2093)
* Add pubsub rabbitmq TTL support

Signed-off-by: zhangchao <zchao9100@gmail.com>

* fix review: remove queue level ttl, both ttl is handled when publishing, to make message ttl has priority over queue level ttl

Signed-off-by: zhangchao <zchao9100@gmail.com>

* add rabbitmq ttl certificate test

Signed-off-by: zhangchao <zchao9100@gmail.com>

* fix lint

Signed-off-by: zhangchao <zchao9100@gmail.com>

* fix ttl certificate test precreate topic

Signed-off-by: zhangchao <zchao9100@gmail.com>

* tiny fix tests

Signed-off-by: zhangchao <zchao9100@gmail.com>

Signed-off-by: zhangchao <zchao9100@gmail.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
2022-11-11 11:34:33 -08:00
Bernd Verst f137bc7373 rabbitmq: use ctx for publishing
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
2022-10-10 14:37:21 -07:00
Mario Reggiori b0d267317d
Add individual connection arguments to pubsub.rabbitmq metadata (#2129)
Signed-off-by: Mario Reggiori <git@marioreggiori.com>

Signed-off-by: Mario Reggiori <git@marioreggiori.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
2022-09-23 23:37:09 -07:00
ItalyPaleAle b58464ad1c Make RabbitMQ retry more than once
Also updated tests to remove unused options and add more logging

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
2022-06-27 22:31:31 +00:00
ItalyPaleAle 35034aa877 Disable built-in retries in pubsub components
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
2022-06-27 20:36:15 +00:00
saber-wang d7eb3b7b27
[pubsub][rabbitmq]add support for binding multiple routingkeys at the same time (#1750)
* Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar
Signed-off-by: saberwang <saberwang@hotmail.com>

* sort field
Signed-off-by: saberwang <saberwang@hotmail.com>

* [pubsub]fix unit test bug
Signed-off-by: saberwang <saberwang@hotmail.com>

* remove unrelated changes
Signed-off-by: saberwang <saberwang@hotmail.com>

* Delete hard coded Metadata
Signed-off-by: saberwang <saberwang@hotmail.com>

* remove  .history

Signed-off-by: saberwang <saberwang@hotmail.com>

* restore .gitignore

Signed-off-by: saberwang <saberwang@hotmail.com>

* Hard coding default values and adding 'BatchingMaxPublishDelay' metadata

Signed-off-by: saberwang <saberwang@hotmail.com>

* fix code format

Signed-off-by: saberwang <saberwang@hotmail.com>

* formatting code

Signed-off-by: saberwang <saberwang@hotmail.com>

* [pubsub][rabbitmq]Add support for binding multiple routingkeys at the same time

Signed-off-by: saberwang <saberwang@hotmail.com>

* add TestSubscribeBindRoutingKeys

Signed-off-by: saberwang <saberwang@hotmail.com>

* fix: Infof to Debugf

Signed-off-by: saberwang <saberwang@hotmail.com>

* Update pubsub/rabbitmq/rabbitmq_test.go

Co-authored-by: Looong Dai <long.dai@intel.com>
Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
2022-06-10 16:34:15 -07:00
Alessandro (Ale) Segala 6f3234d5ac
Rabbitmq publisher confirm (#1762)
* Added `publishConfirm` option to RabbitMQ

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Changed to publisherConfirm per feedback

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
2022-06-10 12:47:02 -07:00
Alessandro (Ale) Segala 704f4dd730
Add contexts to pubsub.Subscribe to allow early cancelation (#1756)
This commit is related to dapr/dapr#4624. As noted there, we have an issue in the runtime where all components are shut down after the grace period, when the app is likely already stopped. Because of that, certain input components (the subscribe part of pubsub and the input part of bindings - the latter not in scope of this PR), can continue bringing new work when it's known to fail.

In order to fix the issue linked above properly, we need to implement a way for PubSub components to have the "publish" part closed before the "subscribe" one (and in the future that will need to be done for input bindings too).

This commit achieves precisely that by adding a context in the Subscribe method. When that context is canceled (which can be at any time), the subscription is removed.

PS: This API change was implemented so it can one day be used for dapr/dapr#814 too, as it allows canceling individual subscriptions by using a different context. Although that's not possible today because it requires more work on the runtime, it does implement everything that's needed in the pubsub components already.
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
2022-06-02 15:06:36 -07:00
Taction 70a86e6d80
supports rabbitmq pubsub set exchangekind (#1520)
Signed-off-by: zhangchao <zchao9100@gmail.com>
2022-02-21 13:08:18 -08:00
Taction 7c7c977d52
Fix rabbitmq pubsub reconnect (#1471)
Signed-off-by: zhangchao <zchao9100@gmail.com>
2022-02-02 11:56:48 -08:00
Dmitry Shmulevich c7adb917f3
update license to Apache v2.0 (#1406) 2022-01-04 19:53:31 -08:00
Dmitry Shmulevich 7a631ef7aa
pub/sub rabbitmq: add publishing retries (#1382)
Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com>

Co-authored-by: Looong Dai <long.dai@intel.com>
2021-12-17 15:59:38 -08:00
Dmitry Shmulevich 3fcf50c044
pub/sub rabbitmq: fix subscribe error (#1377)
Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com>
2021-12-14 08:22:35 -08:00
Dmitry Shmulevich ad433a27e1
add troubleshooting info (#1278)
add retries for pubsub subscribe
fix race conditions
2021-11-15 16:33:21 -08:00
Phil Kedy 77564a34c0
RabbitMQ certification: Fixing publish/subscribe race condition. (#1271)
* Fixing publish/subscribe race condition in RabbitMQ component.
Added amqpReady function to tests to wait for RabbitMQ readiness.
Tweaks to when subscribed is signaled in the test.

* Update go.mod(s)
2021-11-03 16:37:52 -07:00
Dmitry Shmulevich 3b1249cf87
reconnect rabbitmq on 'unexpected command received' error (#1198) 2021-10-14 21:19:31 -07:00
Taction ca8cf5c1fc
Add dead letter support in RabbitMQ pubsub (#883)
* Add dead letter support

* fix lint

* add maxLen and maxLenBytes support

* Let the DLX and DLQ be free form.

Co-authored-by: Yaron Schneider <yaronsc@microsoft.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Co-authored-by: Simon Leet <31784195+CodeMonkeyLeet@users.noreply.github.com>
Co-authored-by: Long Dai <long0dai@foxmail.com>
Co-authored-by: Phil Kedy <phil.kedy@gmail.com>
Co-authored-by: Long Dai <long.dai@intel.com>
Co-authored-by: Ian Luo <ian.luo@gmail.com>
Co-authored-by: cvictory <shenglicao2@gmail.com>
2021-10-11 09:49:14 -07:00
Dmitry Shmulevich 4795f75270
properly close channel in rabbitmq (#1190) 2021-10-07 20:25:36 -07:00
Dmitry Shmulevich 494596be0e
fix 'durable' setting in RabbitMQ (#1183) 2021-10-01 17:27:36 -07:00
Long Dai 988fed05ab
ci: standard linter config (#1102)
* ci: standard linter config

Signed-off-by: Long <long.dai@intel.com>

* Update utils.go

* fix pulsar issue

Signed-off-by: Long <long.dai@intel.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
2021-09-21 15:21:59 -07:00
Phil Kedy 8e6b36ecdf
Importing the retry and config packages from kit instead of internal (#940)
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
2021-06-22 09:38:55 -07:00
Taction 14870cb7bc
Add backoff for rabbitmq PubSub component (#862)
* Add backoff for rabbitmq

* fix lint

* fix lint

* remove backOffEnable config

* Delete backoff enable metadata

* Add a default config setting max retry to 0

* fix lint

Co-authored-by: Phil Kedy <phil.kedy@gmail.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
2021-06-10 00:19:46 -07:00
Taction 7512c77a28
Rabbitmq pubsub component stop has not be well handled (#860)
* fix pubsub rabbitmq stop

* fix lint

* Add read lock while reading stopped

* fix lint

Co-authored-by: Phil Kedy <phil.kedy@gmail.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
2021-06-09 23:23:06 -07:00
Phil Kedy 688df9bda4
Removed dependency on dapr/dapr in favor of dapr/kit. Fixed go mod dependencies afterwards. Go 1.16 in go.mod. Removed accidental log dependency. (#807) 2021-04-19 12:06:10 -07:00
Joni Collinge 9fd461b255 Merge branch 'master' into jjcollinge/pubsub-context 2021-03-23 17:45:05 +00:00
Phil Kedy a1a0ad2c25
Adding RabbitMQ to the conformance tests (#739)
* Initial pass at adding RabbitMQ to the conformance tests

* Fixing unit tests
2021-03-04 11:56:35 -08:00
Joni Collinge c054ae6ada Merge branch 'master' into jjcollinge/pubsub-context 2021-02-25 16:15:06 +00:00
Yaron Schneider d7eeb2413f
Fix RabbitMQ concurrency (#576)
* fix rabbitmq concurrency

* linter

* add concurrency validation

* added tests and validation
2021-01-07 19:29:58 -08:00
Yaron Schneider 7465e4092d
Add concurrency mode to rabbitMQ pub/sub (#575)
* add concurrency mode to rabbitMQ pub/sub

* linter

* simplify
2021-01-07 15:02:58 -08:00
Artur Souza e6dadfab6c
TTL in PubSub. (#565)
* TTL in PubSub.

* Handle message TTL only if component cannot handle it.

* Removig dead code for overflow check in pubsub expiration.
2020-12-29 14:28:52 -08:00
Trond Hindenes 660185b08c
Add support for prefetch (#562)
* Add support for prefetch

* Fixed test implementation

* Gofmt-ed files

* Re-arranged struct

* Moar tests
2020-12-21 10:42:16 -08:00
Joni Collinge 256f920918 fix lint 2020-11-30 16:47:01 +00:00
Joni Collinge 96a8a4d7ac Merge branch 'master' into jjcollinge/pubsub-context 2020-11-30 16:21:44 +00:00
Artur Souza 6266934d3f
Auto-reconnect rabbitmq pubsub (#519) 2020-11-09 12:27:53 -08:00
Joni Collinge 2e6b84ae40 Merge remote-tracking branch 'origin/master' into jjcollinge/pubsub-context 2020-11-02 09:05:16 +00:00
Yaron Schneider 182d204111
Add close method to pub/sub (#494)
* add close method to pub/sub

* linter
2020-10-12 19:06:33 -07:00
halspang f647d9eedb
Upgrade golang lint to 1.31 (#490)
Upgrade golang lint to 1.31.0

https://github.com/dapr/components-contrib/issues/439
2020-10-12 12:54:15 -07:00
Brightside Automation c344f68718 Merge branch 'master' into jjcollinge/pubsub-context 2020-08-19 14:46:03 +01:00
Yaron Schneider 677e551844
fix consumer exclusivity (#435) 2020-08-17 07:37:25 -07:00
jjcollinge 19442e67c8 update pubsub components to use new context 2020-07-28 10:03:23 +01:00
jjcollinge 410628af3d add context to pubsub handler signature 2020-07-07 12:37:15 +01:00
Mukundan Sundararajan 5c62707aba
Upgrade go version to 1.14.3 and linter version to 1.26.0 (#352)
* Upgrade to go 1.14.3 and linter version to 1.26.0
2020-05-29 15:26:33 -07:00
Young Bu Park ee97c3c56a
Use dapr logger (#238)
* Use dapr logger

* skip linter false alarm
2020-02-28 15:49:49 -08:00
Abhishek Gupta 9323c44ecf check etag for etcd update and delete ops (#175) 2020-01-09 12:33:23 -08:00
thinkerou a2f4b4c510 upgrade logrus to v1.4.2 (#150)
* fix conflict

* upgrade logrus to v1.4.2

* fix lint error

error: `depguard  `github.com/sirupsen/logrus` is in the blacklist`
2019-12-12 09:34:39 -08:00
Francisco Beltrao f89682397b Add Azure SignalR binding (#148)
* Add Azure SignalR binding

* Fixes from go lint

* Go lint

* Use "github.com/dgrijalva/jwt-go" for jwt
Fix bug parsing connection string
Normalize usage of len vs == in strings

* Consistent usage of http header Set
2019-12-03 09:08:53 -08:00