From c9f8c8c0bf0a9eca2e9d405b7c7e0458ac82a270 Mon Sep 17 00:00:00 2001 From: Donovan Brown Date: Thu, 8 Apr 2021 10:24:20 -0500 Subject: [PATCH 1/4] Fixed typo Just fixed a simply typo in the docs. --- .../supported-secret-stores/azure-keyvault.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault.md b/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault.md index db83a3a7d..555df3ea0 100644 --- a/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault.md +++ b/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault.md @@ -88,7 +88,7 @@ The above example uses secrets as plain strings. It is recommended to use a loca } ``` - **Save the both the appId and tenant from the output which will be used in the next step** + **Save both the appId and tenant from the output which will be used in the next step** 4. Get the Object Id for [your_service_principal_name] From e45e42ba2aab5d202288f89a372282b522f7848b Mon Sep 17 00:00:00 2001 From: Donovan Brown Date: Thu, 8 Apr 2021 10:30:37 -0500 Subject: [PATCH 2/4] Changing you to your in multiple places In many places 'you' should be 'your'. --- .../azure-keyvault-managed-identity.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md b/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md index fa1e015fe..bc792e139 100644 --- a/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md +++ b/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md @@ -70,7 +70,7 @@ The above example uses secrets as plain strings. It is recommended to use a loca This step is required only if the AKS Cluster is provisoned without the flag "--enable-managed-identity". If the cluster is provisioned with manahed identity, than is suggested to use the autogenerated managed identity that is associated to the Resource Group MC_*. ```bash - $identity = az identity create -g [your resource group] -n [you managed identity name] -o json | ConvertFrom-Json + $identity = az identity create -g [your resource group] -n [your managed identity name] -o json | ConvertFrom-Json ``` Below the command to retrieve the managed identity in the autogenerated scenario: @@ -134,19 +134,19 @@ The above example uses secrets as plain strings. It is recommended to use a loca apiVersion: "aadpodidentity.k8s.io/v1" kind: AzureIdentity metadata: - name: [you managed identity name] + name: [your managed identity name] spec: type: 0 - resourceID: [you managed identity id] - clientID: [you managed identity Client ID] + resourceID: [your managed identity id] + clientID: [your managed identity Client ID] --- apiVersion: "aadpodidentity.k8s.io/v1" kind: AzureIdentityBinding metadata: - name: [you managed identity name]-identity-binding + name: [your managed identity name]-identity-binding spec: - azureIdentity: [you managed identity name] - selector: [you managed identity selector] + azureIdentity: [your managed identity name] + selector: [your managed identity selector] ``` 10. Deploy the azure-identity-config.yaml: From d38ea8c5ef4ccfc4183d12a9cf9ed2db3bfc3cde Mon Sep 17 00:00:00 2001 From: Donovan Brown Date: Thu, 8 Apr 2021 10:35:53 -0500 Subject: [PATCH 3/4] Found another typo manahed should be managed --- .../supported-secret-stores/azure-keyvault-managed-identity.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md b/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md index bc792e139..21c561f67 100644 --- a/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md +++ b/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md @@ -67,7 +67,7 @@ The above example uses secrets as plain strings. It is recommended to use a loca 3. Create the managed identity(Optional) - This step is required only if the AKS Cluster is provisoned without the flag "--enable-managed-identity". If the cluster is provisioned with manahed identity, than is suggested to use the autogenerated managed identity that is associated to the Resource Group MC_*. + This step is required only if the AKS Cluster is provisoned without the flag "--enable-managed-identity". If the cluster is provisioned with managed identity, than is suggested to use the autogenerated managed identity that is associated to the Resource Group MC_*. ```bash $identity = az identity create -g [your resource group] -n [your managed identity name] -o json | ConvertFrom-Json From 3d5ac4bbb1cc5eaaeec73e79ad0b6b68d9116717 Mon Sep 17 00:00:00 2001 From: Donovan Brown Date: Thu, 8 Apr 2021 10:40:07 -0500 Subject: [PATCH 4/4] Found another error Cleaned up a sentence. --- .../azure-keyvault-managed-identity.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md b/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md index 21c561f67..125277aa1 100644 --- a/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md +++ b/daprdocs/content/en/operations/components/setup-secret-store/supported-secret-stores/azure-keyvault-managed-identity.md @@ -67,13 +67,13 @@ The above example uses secrets as plain strings. It is recommended to use a loca 3. Create the managed identity(Optional) - This step is required only if the AKS Cluster is provisoned without the flag "--enable-managed-identity". If the cluster is provisioned with managed identity, than is suggested to use the autogenerated managed identity that is associated to the Resource Group MC_*. + This step is required only if the AKS Cluster is provisoned without the flag "--enable-managed-identity". If the cluster is provisioned with managed identity, than it is suggested to use the autogenerated managed identity that is associated to the Resource Group MC_*. ```bash $identity = az identity create -g [your resource group] -n [your managed identity name] -o json | ConvertFrom-Json ``` - Below the command to retrieve the managed identity in the autogenerated scenario: + Below is the command to retrieve the managed identity in the autogenerated scenario: ```bash az aks show -g -n