From 3a375aaaa874e58373e0dd57ad1acf2694c474ac Mon Sep 17 00:00:00 2001 From: Bernd Verst <4535280+berndverst@users.noreply.github.com> Date: Thu, 4 Nov 2021 15:39:29 -0700 Subject: [PATCH 1/3] Localization Check in Links Validation Checks to ensure Microsoft Docs links aren't pinned to a particular localization --- .github/workflows/link_validation.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/link_validation.yaml b/.github/workflows/link_validation.yaml index e0bcbfae7..6aecd050d 100644 --- a/.github/workflows/link_validation.yaml +++ b/.github/workflows/link_validation.yaml @@ -27,3 +27,11 @@ jobs: - name: Check Markdown Files run: | for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name || exit 1 ;done + - name: Check Microsoft URLs do not pin localized versions + run: | + localized=$(find . -name '*.md' | xargs grep -ol "\.microsoft\.com/[[:alpha:]]\{2\}-[[:alnum:]]\{2\}/") + if [[ $(echo $localized) ]]; then + echo "The following files contain links to Microsoft Docs that pin a localized version:" + echo $localized + exit 1 + fi From c53caffc9c100c669ba0323361102c12e378a493 Mon Sep 17 00:00:00 2001 From: Bernd Verst <4535280+berndverst@users.noreply.github.com> Date: Thu, 4 Nov 2021 15:40:22 -0700 Subject: [PATCH 2/3] Update link_validation.yaml --- .github/workflows/link_validation.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link_validation.yaml b/.github/workflows/link_validation.yaml index 6aecd050d..2c91fe6fb 100644 --- a/.github/workflows/link_validation.yaml +++ b/.github/workflows/link_validation.yaml @@ -29,7 +29,7 @@ jobs: for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name || exit 1 ;done - name: Check Microsoft URLs do not pin localized versions run: | - localized=$(find . -name '*.md' | xargs grep -ol "\.microsoft\.com/[[:alpha:]]\{2\}-[[:alnum:]]\{2\}/") + localized=$(find . -name '*.md' | xargs grep -ol "\.microsoft\.com/[[:alpha:]]\{2\}-[[:alpha:]]\{2\}/") if [[ $(echo $localized) ]]; then echo "The following files contain links to Microsoft Docs that pin a localized version:" echo $localized From 9e82ab7e772739a8ae4c8b5bdb89ea04e12467e4 Mon Sep 17 00:00:00 2001 From: Bernd Verst <4535280+berndverst@users.noreply.github.com> Date: Thu, 4 Nov 2021 23:50:02 +0000 Subject: [PATCH 3/3] Add succes message for msft docs --- .github/workflows/link_validation.yaml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/link_validation.yaml b/.github/workflows/link_validation.yaml index 2c91fe6fb..3571c0c4a 100644 --- a/.github/workflows/link_validation.yaml +++ b/.github/workflows/link_validation.yaml @@ -16,6 +16,16 @@ jobs: PYTHON_VER: 3.7 steps: - uses: actions/checkout@v2 + - name: Check Microsoft URLs do not pin localized versions + run: | + localized=$(find . -name '*.md' | xargs grep -ol "\.microsoft\.com/[[:alpha:]]\{2\}-[[:alpha:]]\{2\}/") || true + if [ -z "$localized" ]; then + echo "All Microsoft Docs links ok." + else + echo "The following files contain links to Microsoft Docs that pin a localized version:" + echo $localized + exit 1 + fi - name: Set up Python ${{ env.PYTHON_VER }} uses: actions/setup-python@v2 with: @@ -27,11 +37,4 @@ jobs: - name: Check Markdown Files run: | for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name || exit 1 ;done - - name: Check Microsoft URLs do not pin localized versions - run: | - localized=$(find . -name '*.md' | xargs grep -ol "\.microsoft\.com/[[:alpha:]]\{2\}-[[:alpha:]]\{2\}/") - if [[ $(echo $localized) ]]; then - echo "The following files contain links to Microsoft Docs that pin a localized version:" - echo $localized - exit 1 - fi +