From 57032f1709dc16cd5183d14021609d415dded7bd Mon Sep 17 00:00:00 2001 From: Amulya Varote Date: Thu, 17 Mar 2022 17:29:44 -0700 Subject: [PATCH] Changes based on the review comments Signed-off-by: Amulya Varote Signed-off-by: Amulya Varote --- .../building-blocks/actors/actor-reentrancy.md | 6 ++++-- daprdocs/content/en/reference/api/actors_api.md | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/daprdocs/content/en/developing-applications/building-blocks/actors/actor-reentrancy.md b/daprdocs/content/en/developing-applications/building-blocks/actors/actor-reentrancy.md index 3aff1cc8f..d48059b84 100644 --- a/daprdocs/content/en/developing-applications/building-blocks/actors/actor-reentrancy.md +++ b/daprdocs/content/en/developing-applications/building-blocks/actors/actor-reentrancy.md @@ -20,12 +20,14 @@ The `maxStackDepth` parameter sets a value that controls how many reentrant call ## Enable Actor Reentrancy with Actor Configuration -The actor that will be reentrant must provide the appropriate configuration to use reentrancy. This is done by the actor's endpoint for `GET /dapr/config`, similar to other actor configuration elements. Here is a snipet of an actor written in Golang providing the configuration: +The actor that will be reentrant must provide configuration to use reentrancy. This is done by the actor's endpoint for `GET /dapr/config`, similar to other actor configuration elements. -{{< tabs Go Dotnet Python JavaScript >}} +{{< tabs Dotnet Java Python Go JavaScript >}} {{% codetab %}} +Here is a snippet of an actor written in Golang providing the reentrancy configuration via the HTTP API. Reentrancy has not yet been included into the Go SDK. + ```go type daprConfig struct { Entities []string `json:"entities,omitempty"` diff --git a/daprdocs/content/en/reference/api/actors_api.md b/daprdocs/content/en/reference/api/actors_api.md index c9fc12322..c68c6260e 100644 --- a/daprdocs/content/en/reference/api/actors_api.md +++ b/daprdocs/content/en/reference/api/actors_api.md @@ -461,7 +461,7 @@ actorIdleTimeout | Specifies how long to wait before deactivating an idle actor. actorScanInterval | A duration which specifies how often to scan for actors to deactivate idle actors. Actors that have been idle longer than the actorIdleTimeout will be deactivated. drainOngoingCallTimeout | A duration used when in the process of draining rebalanced actors. This specifies how long to wait for the current active actor method to finish. If there is no current actor method call, this is ignored. drainRebalancedActors | A bool. If true, Dapr will wait for `drainOngoingCallTimeout` to allow a current actor call to complete before trying to deactivate an actor. If false, do not wait. -reentrancy | A configuration object that holds the options for Actor Reentrancy +reentrancy | A configuration object that holds the options for actor reentrancy enabled | A flag that is needed to enable the reentrancy. maxStackDepth | A value that controls how many reentrant calls be made to the same actor.