Commit Graph

452 Commits

Author SHA1 Message Date
Nick Greenfield 486a5b66c6 Add docs to stop watching configuration updates
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
2022-01-24 12:19:41 -08:00
greenie-msft 604485977b
Upmerge v1.5 to v1.6 20220119 (#2119)
* moving middleware to samples

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updated middleware doc to point to updated sample location

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixing one more link after moving middleware code from quickstarts to samples repo

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com>
2022-01-19 16:26:44 -08:00
greenie-msft 65bdea43f5
Remove app-protocol from gRPC proxying (#2116)
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
2022-01-18 16:00:24 -08:00
Dmitry Shmulevich 818c0a622b
update state query API doc with usage limitations (#2101)
Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com>

Co-authored-by: Mark Fussell <mfussell@microsoft.com>

Co-authored-by: Mark Fussell <mfussell@microsoft.com>
2022-01-14 15:31:00 -08:00
Will Tsai baf59c9253 Merge branch 'v1.5' into v1.6
Signed-off-by: Will Tsai <william.wl.tsai@gmail.com>
2022-01-14 13:44:48 -08:00
Charlie Stanley e7aa517ba9 Update pubsub-message-ttl.md
Update python-sdk example to reflect dapr/python-sdk#299

Signed-off-by: Charlie Stanley <charlie.stanley@microsoft.com>
2022-01-03 12:20:52 -08:00
Dmitry Shmulevich 32559ec186
statestore query api: simplify query JSON (#2061)
Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com>
2021-12-28 16:50:48 -08:00
greenie-msft 7deff4f04e
Upmerge v1.5 to v1.6 20211227 (#2064)
* Added pub sub documentation

* Changed port number in the command

* Modified based on the review comments - 1

* Modified based on the review comments - 2

* Changed python commands

* Changed python commands

* Modified based on the review comments - 3

* Fix publish a topic examples

Step 3 and 4 of the "How-To: Publish & subscribe" publishes to the
wrong app id and pubsub. This commit fixes by changing the examples
that write to the app-id "testpubsub" to "orderprocessing"
and the pubsub "pubsub" to "order_pub_sub"

* Wrap oauth links in ignore comment

* Bumping tags to v1.5.0

* Update dapr versions for 1.5.1 hotfix

* Correct the default component init timeout

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Fix incorrect warning log-level

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Added bindings documentation

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Changed python commands

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Changed image for bindings

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Reverted a small change

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Added pub sub documentation

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Changed port number in the command

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Changed python commands

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Changed python commands

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified based on the review comments - 3

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Wrap oauth links in ignore comment

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Bumping tags to v1.5.0

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified based on the review comments -3

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified a line based on the review comment

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Fix publish a topic examples

Step 3 and 4 of the "How-To: Publish & subscribe" publishes to the
wrong app id and pubsub. This commit fixes by changing the examples
that write to the app-id "testpubsub" to "orderprocessing"
and the pubsub "pubsub" to "order_pub_sub"

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Update dapr versions for 1.5.1 hotfix

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified a line based on the review comment

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Modified based on the review comments

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>

* Added pub sub documentation

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Changed port number in the command

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added secrets store documentation

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Changed python commands

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Changed python commands

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 3

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Fix publish a topic examples

Step 3 and 4 of the "How-To: Publish & subscribe" publishes to the
wrong app id and pubsub. This commit fixes by changing the examples
that write to the app-id "testpubsub" to "orderprocessing"
and the pubsub "pubsub" to "order_pub_sub"

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added full code snippets for service invocation

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added full code snippets of secrets management

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added full code snippets of state management

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added full code snippets of pub sub

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Removed a line

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* resolved merge conflicts

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added full code snippets of secrets management

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added full code snippets of pub sub

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Removed a line

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added full code snippets of secrets management

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Added full code snippets of pub sub

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Solved merge conflicts

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Modified go secrets code

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>

* Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md

Co-authored-by: Will <witsai@microsoft.com>

* Added DCO sign-off guidance for contributing to Dapr

Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>

* Address PR feedback

Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>

* Add DCO check to PR template

Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>

* simplify git command for DCO

Signed-off-by: Will Tsai <william.wl.tsai@gmail.com>

* Fix header

* Display state value instead of StateResponse object (#2046)

Signed-off-by: Jun Tian <tianjun.cpp@gmail.com>

Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>

* add ForcePathStyle support for s3 binding (#2054)

Signed-off-by: rainfd <rainfd@live.cn>

Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* Remove requests dep (#2055)

* Add DCO check to PR template

Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>

* Remove requests dep

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: Nick Greenfield <nigreenf@microsoft.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* update endpoint in s3 binding doc (#2049)

* update endpoint in s3 binding doc

Signed-off-by: lizzzcai <lizzzcai1@gmail.com>

* fix jaeger link

Signed-off-by: lizzzcai <lizzzcai1@gmail.com>

* update endpoint example to match region

Signed-off-by: lizzzcai <lizzzcai1@gmail.com>

Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* Update autoscale-keda.md (#2047)

Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* Update service-mesh.md (#2044)

Minor typo

Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* Added missing HTTP verb to the documentation dapr/dapr#4030 (#2045)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* Update logs-troubleshooting.md (#2023)

The label name `dapr-placement` has been changed to `dapr-placement-server`.

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* update the DOTNET SDK

Signed-off-by: Mark Fussell <markfussell@gmail.com>

Co-authored-by: Amulya Varote <amulyavarote@r6415.redmond.corp.microsoft.com>
Co-authored-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
Co-authored-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>
Co-authored-by: David Millman <dave@cs.unc.edu>
Co-authored-by: emctl <emccudden@gmail.com>
Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Co-authored-by: Will <witsai@microsoft.com>
Co-authored-by: Will Tsai <william.wl.tsai@gmail.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Jun Tian <find_my_way@foxmail.com>
Co-authored-by: RainFD <rainfd@live.cn>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>
Co-authored-by: ChethanUK <chethan.u1@gmail.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Lize <lizzzcai1@gmail.com>
Co-authored-by: Andrew Cartwright <acartcat@gmail.com>
Co-authored-by: Shriroop Joshi <shriroopjoshi@users.noreply.github.com>
Co-authored-by: Christoph Hofmann <oss@hoffe.org>
Co-authored-by: Will 保哥 <doggy.huang@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com>
2021-12-28 15:20:48 -08:00
Andrew Cartwright 966509ed94
Update autoscale-keda.md (#2047)
Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>
2021-12-24 10:05:44 -08:00
ChethanUK ff5f20f23a
Remove requests dep (#2055)
* Add DCO check to PR template

Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>

* Remove requests dep

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: Nick Greenfield <nigreenf@microsoft.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>
2021-12-24 09:30:45 -08:00
Jun Tian 2a587fa2ab
Display state value instead of StateResponse object (#2046)
Signed-off-by: Jun Tian <tianjun.cpp@gmail.com>

Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
2021-12-24 09:07:03 -08:00
Aaron Crawfis 50ae5f1a1b
Fix header 2021-12-17 10:48:50 -08:00
greenie-msft 14d3a91357
Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md
Co-authored-by: Will <witsai@microsoft.com>
2021-12-09 15:18:32 -08:00
Amulya Varote b5f2a8764a Modified go secrets code
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-09 04:24:13 -08:00
Amulya Varote e4b3ad529b Solved merge conflicts
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote caf849f973 Modified based on the review comments - 1
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote efbf2e0ebb Added full code snippets of pub sub
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 5810831f15 Added full code snippets of secrets management
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 1534f7d5e5 Removed a line
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote c65e91f200 Modified based on the review comments - 1
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote e1bbdaa9ed Added full code snippets of pub sub
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote ec61461b00 Added full code snippets of secrets management
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 6662f1a322 Modified based on the review comments - 1
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 099ea6e99d resolved merge conflicts
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote bd6d5e75af Removed a line
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 3a7c140fe7 Modified based on the review comments - 1
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 5cb62329b0 Added full code snippets of pub sub
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 1f879395a9 Added full code snippets of state management
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 08048e58d7 Added full code snippets of secrets management
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 78848ef7bc Added full code snippets for service invocation
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
David Millman 2490c8165e Fix publish a topic examples
Step 3 and 4 of the "How-To: Publish & subscribe" publishes to the
wrong app id and pubsub. This commit fixes by changing the examples
that write to the app-id "testpubsub" to "orderprocessing"
and the pubsub "pubsub" to "order_pub_sub"

Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote b603d641fb Modified based on the review comments - 3
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 07759e7b1b Changed python commands
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 7500cc4900 Changed python commands
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote e4c14ea153 Modified based on the review comments - 2
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
greenie-msft 5106cd0e81 Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
greenie-msft 37ecbbb173 Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote ebd25617c0 Modified based on the review comments - 2
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote fb40e614a0 Modified based on the review comments - 1
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote f0b6ac5864 Modified based on the review comments - 1
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote f12b671731 Added secrets store documentation
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 4dbf126292 Modified based on the review comments - 1
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 32a1996acb Changed port number in the command
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 619ac7e5ad Added pub sub documentation
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
2021-12-08 23:37:04 -08:00
Amulya Varote 60917d0922 Modified based on the review comments
Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>
2021-12-08 10:14:41 -08:00
Amulya Varote 1aefafb1f7 Modified a line based on the review comment
Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>
2021-12-08 10:12:30 -08:00
David Millman 24be51f2a2 Fix publish a topic examples
Step 3 and 4 of the "How-To: Publish & subscribe" publishes to the
wrong app id and pubsub. This commit fixes by changing the examples
that write to the app-id "testpubsub" to "orderprocessing"
and the pubsub "pubsub" to "order_pub_sub"

Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>
2021-12-07 19:46:08 -08:00
Amulya Varote c45403806e Modified a line based on the review comment
Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>
2021-12-07 19:46:08 -08:00
Amulya Varote a5740071ae Modified based on the review comments -3
Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>
2021-12-07 19:46:08 -08:00
Amulya Varote 1b5d57ea64 Modified based on the review comments - 2
Signed-off-by: Amulya Varote <amulyavarote@MININT-8V4CL0S.redmond.corp.microsoft.com>
2021-12-07 19:46:07 -08:00