dapr
/
dotnet-sdk
mirror of https://github.com/dapr/dotnet-sdk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove async void in tests (#447) 

Fixes: #446

`async void` is almost always a bug in server-side programming. If these
tests were doing any networking then they would encounter concurrency
bugs or crash in the event of an exception.

Co-authored-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
This commit is contained in:
Ryan Nowak 2020-10-29 15:54:17 -07:00 committed by GitHub
parent 3b1538be9f
commit aa682eb462
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/Dapr.AspNetCore.Test/StateEntryModelBinderTest.cs
View File

@ -51,7 +51,7 @@ namespace Dapr.AspNetCore.Test
// Create Response & Respond // Create Response & Respond
var state = new Widget() { Size = "small", Color = "yellow", }; var state = new Widget() { Size = "small", Color = "yellow", };
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState(state, entry); await SendResponseWithState(state, entry);
// Get response and validate // Get response and validate
await task; await task;
@ -77,7 +77,7 @@ namespace Dapr.AspNetCore.Test
// Create Response & Respond // Create Response & Respond
var state = new Widget() { Size = "small", Color = "yellow", }; var state = new Widget() { Size = "small", Color = "yellow", };
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState(state, entry); await SendResponseWithState(state, entry);
// Get response and validate // Get response and validate
await task; await task;
@ -107,7 +107,7 @@ namespace Dapr.AspNetCore.Test
}; };
} }
private async void SendResponseWithState<T>(T state, TestHttpClient.Entry entry) private async Task SendResponseWithState<T>(T state, TestHttpClient.Entry entry)
{ {
var stateData = TypeConverters.ToJsonByteString(state); var stateData = TypeConverters.ToJsonByteString(state);
var stateResponse = new GetStateResponse(); var stateResponse = new GetStateResponse();

14
test/Dapr.Client.Test/InvokeApiTest.cs
View File

@ -130,7 +130,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var data = new Response() { Name = "Look, I was invoked!" }; var data = new Response() { Name = "Look, I was invoked!" };
SendResponse(data, entry); await SendResponse(data, entry);
// Validate Response // Validate Response
var invokedResponse = await task; var invokedResponse = await task;
@ -160,7 +160,7 @@ namespace Dapr.Client.Test
typeFromRequest.RequestParameter.Should().Be("Hello "); typeFromRequest.RequestParameter.Should().Be("Hello ");
// Create Response & Respond // Create Response & Respond
SendResponse<Response>(null, entry); await SendResponse<Response>(null, entry);
// Validate Response. // Validate Response.
var invokedResponse = await task; var invokedResponse = await task;
@ -218,7 +218,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var data = new Response() { Name = "Look, I was invoked!" }; var data = new Response() { Name = "Look, I was invoked!" };
SendResponse(data, entry); await SendResponse(data, entry);
// Validate Response // Validate Response
var invokedResponse = await task; var invokedResponse = await task;
@ -276,7 +276,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var response = new Response() { Name = "Look, I was invoked!" }; var response = new Response() { Name = "Look, I was invoked!" };
SendResponse(response, entry); await SendResponse(response, entry);
FluentActions.Awaiting(async () => await task).Should().NotThrow(); FluentActions.Awaiting(async () => await task).Should().NotThrow();
} }
@ -362,7 +362,7 @@ namespace Dapr.Client.Test
var json = envelope.Message.Data.Value.ToStringUtf8(); var json = envelope.Message.Data.Value.ToStringUtf8();
json.Should().Be(JsonSerializer.Serialize(invokeRequest, jsonOptions)); json.Should().Be(JsonSerializer.Serialize(invokeRequest, jsonOptions));
SendResponse(invokedResponse, entry, jsonOptions); await SendResponse(invokedResponse, entry, jsonOptions);
var response = await task; var response = await task;
response.Name.Should().Be(invokedResponse.Name); response.Name.Should().Be(invokedResponse.Name);
@ -407,7 +407,7 @@ namespace Dapr.Client.Test
var json = envelope.Message.Data.Value.ToStringUtf8(); var json = envelope.Message.Data.Value.ToStringUtf8();
json.Should().Be(JsonSerializer.Serialize(invokeRequest, jsonOptions)); json.Should().Be(JsonSerializer.Serialize(invokeRequest, jsonOptions));
SendResponse(invokedResponse, entry, jsonOptions); await SendResponse(invokedResponse, entry, jsonOptions);
var response = await task; var response = await task;
response.Name.Should().Be(invokedResponse.Name); response.Name.Should().Be(invokedResponse.Name);
@ -473,7 +473,7 @@ namespace Dapr.Client.Test
response.Name.Should().Be("unexpected"); response.Name.Should().Be("unexpected");
} }
private async void SendResponse<T>(T data, TestHttpClient.Entry entry, JsonSerializerOptions options = null) private async Task SendResponse<T>(T data, TestHttpClient.Entry entry, JsonSerializerOptions options = null)
{ {
var dataAny = TypeConverters.ToAny(data, options); var dataAny = TypeConverters.ToAny(data, options);
var dataResponse = new InvokeResponse(); var dataResponse = new InvokeResponse();

22
test/Dapr.Client.Test/StateApiTest.cs
View File

@ -35,7 +35,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var data = new Widget() { Size = "small", Color = "yellow", }; var data = new Widget() { Size = "small", Color = "yellow", };
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState(data, entry); await SendResponseWithState(data, entry);
// Get response and validate // Get response and validate
var state = await task; var state = await task;
@ -58,7 +58,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var data = "value"; var data = "value";
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithBulkState(key, data, entry); await SendResponseWithBulkState(key, data, entry);
// Get response and validate // Get response and validate
var state = await task; var state = await task;
@ -79,7 +79,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var data = new Widget() { Size = "small", Color = "yellow", }; var data = new Widget() { Size = "small", Color = "yellow", };
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState(data, entry, "Test_Etag"); await SendResponseWithState(data, entry, "Test_Etag");
// Get response and validate // Get response and validate
var (state, etag) = await task; var (state, etag) = await task;
@ -101,7 +101,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState<Widget>(null, entry); await SendResponseWithState<Widget>(null, entry);
// Get response and validate // Get response and validate
var state = await task; var state = await task;
@ -129,7 +129,7 @@ namespace Dapr.Client.Test
request.Consistency.Should().Be(expectedConsistencyMode); request.Consistency.Should().Be(expectedConsistencyMode);
// Create Response & Respond // Create Response & Respond
SendResponseWithState<Widget>(null, entry); await SendResponseWithState<Widget>(null, entry);
// Get response and validate // Get response and validate
var state = await task; var state = await task;
@ -361,7 +361,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var data = new Widget() { Size = "small", Color = "yellow", }; var data = new Widget() { Size = "small", Color = "yellow", };
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState(data, entry); await SendResponseWithState(data, entry);
// Get response and validate // Get response and validate
var state = await task; var state = await task;
@ -382,7 +382,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState<Widget>(null, entry); await SendResponseWithState<Widget>(null, entry);
var state = await task; var state = await task;
state.Key.Should().Be("test"); state.Key.Should().Be("test");
@ -403,7 +403,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var data = new Widget() { Size = "small", Color = "yellow", }; var data = new Widget() { Size = "small", Color = "yellow", };
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState(data, entry); await SendResponseWithState(data, entry);
var state = await task; var state = await task;
state.Key.Should().Be("test"); state.Key.Should().Be("test");
@ -443,7 +443,7 @@ namespace Dapr.Client.Test
// Create Response & Respond // Create Response & Respond
var data = new Widget() { Size = "small", Color = "yellow", }; var data = new Widget() { Size = "small", Color = "yellow", };
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
SendResponseWithState(data, entry); await SendResponseWithState(data, entry);
var state = await task; var state = await task;
state.Key.Should().Be("test"); state.Key.Should().Be("test");
@ -630,7 +630,7 @@ namespace Dapr.Client.Test
request.Options.Consistency.Should().Be(expectedConsistency); request.Options.Consistency.Should().Be(expectedConsistency);
} }
private async void SendResponseWithState<T>(T state, TestHttpClient.Entry entry, string etag = null) private async Task SendResponseWithState<T>(T state, TestHttpClient.Entry entry, string etag = null)
{ {
var stateDate = TypeConverters.ToJsonByteString(state); var stateDate = TypeConverters.ToJsonByteString(state);
var stateResponse = new Autogenerated.GetStateResponse(); var stateResponse = new Autogenerated.GetStateResponse();
@ -646,7 +646,7 @@ namespace Dapr.Client.Test
entry.Completion.SetResult(response); entry.Completion.SetResult(response);
} }
private async void SendResponseWithBulkState(string key, string state, TestHttpClient.Entry entry) private async Task SendResponseWithBulkState(string key, string state, TestHttpClient.Entry entry)
{ {
var stateDate = TypeConverters.ToJsonByteString(state); var stateDate = TypeConverters.ToJsonByteString(state);
var bulkResponse = new Autogenerated.GetBulkStateResponse(); var bulkResponse = new Autogenerated.GetBulkStateResponse();