pub/sub - rename refs to 'content' to 'data' (#318)

Co-authored-by: LM <lemai>
This commit is contained in:
Leon Mai 2020-05-28 21:09:51 -07:00 committed by GitHub
parent 6c27126223
commit ad4095c308
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 11 deletions

View File

@ -19,11 +19,11 @@ namespace Dapr.Client
/// Publishes an event to the specified topic. /// Publishes an event to the specified topic.
/// </summary> /// </summary>
/// <param name="topicName">The name of the topic the request should be published to.</param> /// <param name="topicName">The name of the topic the request should be published to.</param>
/// <param name="content">The contents of the event.</param> /// <param name="data">The event data.</param>
/// <param name="cancellationToken">A <see cref="CancellationToken" /> that can be used to cancel the operation.</param> /// <param name="cancellationToken">A <see cref="CancellationToken" /> that can be used to cancel the operation.</param>
/// <typeparam name="TContent">The data type of the object that will be serialized.</typeparam> /// <typeparam name="TData">The data type of the object that will be serialized.</typeparam>
/// <returns>A <see cref="Task" /> that will complete when the operation has completed.</returns> /// <returns>A <see cref="Task" /> that will complete when the operation has completed.</returns>
public abstract Task PublishEventAsync<TContent>(string topicName, TContent content, CancellationToken cancellationToken = default); public abstract Task PublishEventAsync<TData>(string topicName, TData data, CancellationToken cancellationToken = default);
/// <summary> /// <summary>
/// Publishes an event to the specified topic. /// Publishes an event to the specified topic.

View File

@ -40,11 +40,11 @@ namespace Dapr.Client
#region Publish Apis #region Publish Apis
/// <inheritdoc/> /// <inheritdoc/>
public override Task PublishEventAsync<TContent>(string topicName, TContent content, CancellationToken cancellationToken = default) public override Task PublishEventAsync<TData>(string topicName, TData data, CancellationToken cancellationToken = default)
{ {
ArgumentVerifier.ThrowIfNullOrEmpty(topicName, nameof(topicName)); ArgumentVerifier.ThrowIfNullOrEmpty(topicName, nameof(topicName));
ArgumentVerifier.ThrowIfNull(content, nameof(content)); ArgumentVerifier.ThrowIfNull(data, nameof(data));
return MakePublishRequest(topicName, content, cancellationToken); return MakePublishRequest(topicName, data, cancellationToken);
} }
/// <inheritdoc/> /// <inheritdoc/>

View File

@ -15,22 +15,22 @@ namespace Dapr.Client.Test
public class PublishEventApiTest public class PublishEventApiTest
{ {
[Fact] [Fact]
public async Task PublishEventAsync_CanPublishTopicWithContent() public async Task PublishEventAsync_CanPublishTopicWithData()
{ {
var httpClient = new TestHttpClient(); var httpClient = new TestHttpClient();
var daprClient = new DaprClientBuilder() var daprClient = new DaprClientBuilder()
.UseGrpcChannelOptions(new GrpcChannelOptions{ HttpClient = httpClient }) .UseGrpcChannelOptions(new GrpcChannelOptions{ HttpClient = httpClient })
.Build(); .Build();
var publishContent = new PublishContent() { PublishObjectParameter = "testparam" }; var publishData = new PublishData() { PublishObjectParameter = "testparam" };
var task = daprClient.PublishEventAsync<PublishContent>("test", publishContent); var task = daprClient.PublishEventAsync<PublishData>("test", publishData);
httpClient.Requests.TryDequeue(out var entry).Should().BeTrue(); httpClient.Requests.TryDequeue(out var entry).Should().BeTrue();
var envelope = await GrpcUtils.GetEnvelopeFromRequestMessageAsync<PublishEventEnvelope>(entry.Request); var envelope = await GrpcUtils.GetEnvelopeFromRequestMessageAsync<PublishEventEnvelope>(entry.Request);
var jsonFromRequest = envelope.Data.Value.ToStringUtf8(); var jsonFromRequest = envelope.Data.Value.ToStringUtf8();
envelope.Topic.Should().Be("test"); envelope.Topic.Should().Be("test");
jsonFromRequest.Should().Be(JsonSerializer.Serialize(publishContent)); jsonFromRequest.Should().Be(JsonSerializer.Serialize(publishData));
} }
[Fact] [Fact]
@ -51,7 +51,7 @@ namespace Dapr.Client.Test
jsonFromRequest.Should().Be("\"\""); jsonFromRequest.Should().Be("\"\"");
} }
private class PublishContent private class PublishData
{ {
public string PublishObjectParameter { get; set; } public string PublishObjectParameter { get; set; }
} }