Commit Graph

82 Commits

Author SHA1 Message Date
vinayada1 5741a25b37
Merge branch 'master' into binaryformatter 2020-11-30 12:35:25 -08:00
Ryan Nowak 116d984b4e
Rename and cleanup of HTTPExtension (#488)
* Rename and cleanup of HTTPExtension

Fixes: #421

This change renames `HTTPExtension`->`HttpInvocationOptions`. This is more
idiomatic in .NET and reflects existing naming conventions (options or
settings for parameters).

Also changes to use the `System.Net.Http.HttpMethod` type for the http
method, and globally prefer the term `method` over `verb`. Every .NET
API that I'm aware of uses 'method', as does rfc7231.

* One more rename
2020-11-30 12:11:44 -08:00
vinayada1 d869cfed74 fix review comments 2020-11-20 14:31:26 -08:00
vinayada1 819e598fab
Merge branch 'master' into binaryformatter 2020-11-19 15:07:58 -08:00
vinayada1 2ccc1e22d6 fix review comments - 3 2020-11-19 15:06:19 -08:00
vinayada1 9b0aefd7cf fix review comments 2020-11-19 15:06:19 -08:00
vinayada1 80f2319fe4
Handle rpc exception thrown for operation cancellation (#455)
* Handle cancelled cancellation token

* add UTs

* add secrets UT

* fix review comments

* invoke and await in one call

* fix await

* Add test for multiple calls to UseActors (#459)

Fixes: #411

The bug was actually addressed in PR #453 - this change adds a test that
verifies that we actually fixed it.

Co-authored-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>

* use grpcChannelOptions ThrowOperationCanceledOnCancellation

* Add doc

* add link to doc

Co-authored-by: Ryan Nowak <nowakra@gmail.com>
2020-11-19 11:22:33 -08:00
Dasith Wijesiriwardena f6f434d6e6
Fluent methods for creating and manipulating HTTPExtension (#473)
* HTTPExtension fluent methods

* add tests

Co-authored-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
2020-11-17 12:58:02 -08:00
vinayada1 88b7ad021d
Merge branch 'master' into binaryformatter 2020-11-16 15:11:31 -08:00
vinayada1 076ec11fb9 changes 2020-11-16 15:02:50 -08:00
Ryan Nowak 721ea4a1be
Add test for multiple calls to UseActors (#459)
Fixes: #411

The bug was actually addressed in PR #453 - this change adds a test that
verifies that we actually fixed it.

Co-authored-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
2020-11-16 13:00:38 -08:00
vinayada1 e17edb4dcc init commit for removing binary formatter 2020-11-10 16:51:12 -08:00
Ryan Nowak 7d1fa13101
Make ActorId deserializable (#457)
Fixes: #444

ActorId doesn't define a default constructor, and so it's not
deserializable via System.Text.Json.

This change implements a converter so that ActorId's API shape can work
with the serializer properly.

I added an integration test for ActorReference as well, but no library
changes we needed for that, ActorId was the blocker.
2020-11-05 15:10:38 -08:00
vinayada1 43563a4388 remove binaryformatter 2020-11-03 14:42:20 -08:00
vinayada1 4c926c9469
Rich error model (#432)
* add InvokeMethodRawAsync and InvokeMethodWithResponseAsync
Co-authored-by: Ryan Nowak <nowakra@gmail.com>
2020-10-30 13:59:33 -07:00
vinayada1 0ccddf73ff
Logging changes to use ILogger (#453)
* logging changes to use ILogger

Co-authored-by: Ryan Nowak <nowakra@gmail.com>
2020-10-30 13:09:32 -07:00
Ryan Nowak aa682eb462
Remove async void in tests (#447)
Fixes: #446

`async void` is almost always a bug in server-side programming. If these
tests were doing any networking then they would encounter concurrency
bugs or crash in the event of an exception.

Co-authored-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
2020-10-29 15:54:17 -07:00
Charlie Stanley ab3f45e7e1 Added codecov integration (#436) 2020-10-19 19:06:21 -07:00
Ryan Nowak cd781248c7 Remove static instance of ActorRuntime
Contributes to: #416

This change removes a mutable static instance - this is low-hanging
fruit design improvement and helps us make these features more flexible
in the future.
2020-10-15 16:53:32 -07:00
Ryan Nowak 51ab7ff181 Stop generating docs in samples and tests
Removes generation of documentation files for samples and tests. This is
a vestige from using the older Stylecop tool in this repo, which needs
the doc files to inspect.

The deleterious effect of this is getting warnings about missing
documentation on samples, and forcing contributors and maintainers to
write nonsense comments to workaround the warning.

Also removed references to stylecop, since we no longer use it.
2020-10-10 19:04:00 -07:00
Young Bu Park 3bb6165096
Upgrade grpc to 2.32.0 (#413) 2020-10-07 10:35:57 -07:00
Edwin van Wijk b3aef53d79
Fix use of marker services in DI registration (#403)
* Fix for issue #390

* Fix unit-test naming

Co-authored-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
2020-09-28 10:24:45 -07:00
Sander Molenkamp 100dbe9794
Send headers as metadata to sidecar (#397)
* Send headers as metadata to sidecar

* Add HTTP headers test

* Allow different kinds of dictionaries
2020-09-24 16:07:44 -07:00
Edwin van Wijk 55e168fac3
Add ability to specify default DaprClient options to AddDapr (#394)
* Add fix for issue 390

* Move JsonSerializer defaults to DaprClientBuilder ctor

* Update samples to reflect changes

* Update unit-tests to reflect latest changes

* Remove obsolete using statements

* Change internal fields to internal properties

* Change internal fields to internal properties
2020-09-24 10:36:47 -07:00
vinayada1 e93357cb9d
State Transaction API changes (#385)
* State Transaction API changes
* Add the optional fields as per API reference
* Fix review comments
* Added transactional state api to sample
2020-09-17 16:12:50 -07:00
Leon Mai bf0354bd39
Add metadata for get/delete state apis (#383)
Co-authored-by: LM <lemai>
2020-09-01 18:27:17 -07:00
Leon Mai 11f6ea45e1
Multi pubsub (#374)
* Prepping for multi pubsub

* Add pubsub name, some cleanup

* multi pubsub changes

Co-authored-by: Aman Bhardwaj <amanbha@microsoft.com>
Co-authored-by: LM <lemai>
2020-08-17 13:58:50 -07:00
Yaron Schneider 6671ab020c
Add bulk get to client (#372)
* Add bulk get to client

* change params, return type, class to struct

* change IList to IReadOnlyList, make parallelism nullable

* change GetBulkItem to BulkStateItem
2020-08-17 09:24:35 -07:00
Gokhan Altinoren aa52a5d6a2
Fixing an issue of a null reference exception where the model binder is checked against a null BindingSource (#371) 2020-08-17 08:57:48 -07:00
Aman Bhardwaj bb3d7326cb
adding tests for DaprHttpInteractor in Actors, removing unused code. (#364) 2020-08-07 12:43:59 -07:00
Aman Bhardwaj 1cd4500a2d
Adding support for DAPR_API_TOKEN (#359)
* Adding support for DAPR_API_TOKEN

* adding retry back for this PR
2020-08-04 15:15:18 -07:00
Aman Bhardwaj b6329539bc
Remove retry options from state apis. (#361)
* Removing retry options for state apis.

* getting latest proto from dapr/dapr
2020-08-04 14:32:16 -07:00
Christian Kaps fdf17b7dbb
Use protobuf packaging for the Any type (#358)
* Use protobuf packaging for the Any type

This pull request implements two converters which help with the type conversion between arbitrary types and the protobuf `Any` type. The C# protobuf library provides a mechanism to pack or unpack protobuf messages to `Any`. It provides the methods `Any.Pack` and `Any.Unpack` to serialize/deserialize messages based on `Google.Protobuf.IMessage`. For types that are not based on `Google.Protobuf.IMessage`, the existing JSON serialization/deserialization will be used.

I've also cleaned the existing codebase a little bit.

Fixes #268

* Fix suggested changes
2020-08-03 10:15:23 -07:00
Leon Mai 1974ab36a8
Remove secret store extension from building (#348)
* Remove secret store extension from building

* Remove code

Co-authored-by: LM <lemai>
Co-authored-by: Aman Bhardwaj <amanbha@users.noreply.github.com>
2020-07-25 09:22:36 -07:00
Christian Kaps 5b246c8665
Include the appcallback.proto into the Dapr.Client package (#349)
* Include the appcallback.proto into the Dapr.Client package

To implement service invocation for a gRPC API, a user must implement the AppCallback service on the callee site. Currently this must be done by integrating the `appcallpack.proto` file as also the depending `common.proto` file into the gRPC service application. The `Dapr.Client` package contains already the same `common.proto` file to generate the client classes. This results in a CS0433 error, because the `Dapr.Client` package and the generated AppCallback service will contain a `Dapr.Client.Autogen.Grpc.v1` namespace with the exact same classes.

This pull requests integrates the `appcallpack.proto` into the client package. With this fix the user does not need to integrate the proto files by itself.

See: https://gitter.im/Dapr/community?at=5f14b7e98a9a0a08cbab5d53

* Remove specific names
2020-07-25 09:20:34 -07:00
Leon Mai 041a2d1255
Update to sdk for changes in proto for bidirectional binding in runtime (#320)
* Update proto for bidirectional binding in runtime

* move arg check

Co-authored-by: LM <lemai>
2020-06-03 11:10:08 -07:00
Sander Molenkamp f3b5c7db81
Update client to latest proto files (#315)
* Update client to latest proto files

* Update PublishEventApiTest.cs

Merge conflict.

Co-authored-by: Leon Mai <lemai@microsoft.com>
2020-05-29 10:35:53 -07:00
Leon Mai ad4095c308
pub/sub - rename refs to 'content' to 'data' (#318)
Co-authored-by: LM <lemai>
2020-05-28 21:09:51 -07:00
Leon Mai 6c27126223
#312 - make changes corresponding to change in dapr runtime. The run… (#313)
* #312 - make changes corresponding to change in dapr runtime.  The runtime will no longer send an activate message.  The SDK should 'activate' an actor anytime it receives an actor method call

* spaces

* remove comment'

Co-authored-by: LM <lemai>
2020-05-16 17:06:49 -07:00
Aman Bhardwaj e773243487
Returning routes for pubsub from aspnetcore integration. (#309)
* Returning routes for pubsub from aspnetcore integration.

* adding ref to System.IO.Pipelines

* updating tests

* not using RawText, using segments in route.

* fixing tests

* Logging a warning for routes with parameters

* Using ILoggerFactory
2020-05-14 15:16:55 -07:00
Leon Mai 465c960b79
httpextension should use post if not specified (#303)
* httpextension should use post if not specified

* make constant

Co-authored-by: LM <lemai>
2020-05-06 17:45:56 -07:00
Leon Mai 44ca6496d8
Move to new invoke proto, specify contenttype in response to the dapr… (#295)
* Move to new invoke proto, specify contenttype in response to the dapr/config message, clarify sample

* Update for additional proto changes

* cr

Co-authored-by: LM <lemai>
2020-04-30 11:47:29 -07:00
Jérôme Piquot 767fba5675
Initializing ActorId with an empty string should throw an exception (#279)
* fix issue 277. Initializing ActorId with an empty string should throw an exception.

* add whitespace check to actorid constructor
2020-04-05 12:02:03 -07:00
Leon Mai 20fabb2141
Support more actor configuration (#269)
* 219 Support the granular Actor config such as actor idle time

* cleanup

* cr

* cr

* refactor

* remove now dead code

* Move setter into properties

Co-authored-by: LM <lemai>
2020-03-30 13:30:00 -07:00
Carlos Mendible f36b52107f
Secret Store configuration provider implementation for Microsoft.Extensions.Configuration (#238)
* Implementing Dapr Secret Store configuration provider

* Improved exception message

Co-authored-by: Aman Bhardwaj <amanbha@users.noreply.github.com>
2020-03-18 10:43:19 -07:00
Aman Bhardwaj 51fc48fb74
Adding & enhancing client apis over gRPC (#244)
* adding IDAprClient interface

* Adding DaprClientBuilder and adding methods for Publish

* updating the method name for publish

* Adding unit tests for publishevent api

* Removing individual clients for publish

* Renaming base class to DaprClient and implementation calss to DparClientGrpc

* Moving State api to grpc and adding helpers to unittest grpc calls.

* More DaprClient logic

* metadata, etag, options, etc are optional

* Revert "metadata, etag, options, etc are optional"

This reverts commit ea5dc12c5d.

* Default params, 2 new Try- methods, overload refactor for InvokeMethodAsync

* Move some classes/enums to different files.  Documentation

* Code refactor and changing tests to use grpc

* Adding tests with state options

* Adding test for getting etag and state

* More refactoring and adding INvokeBinding test

* Fixing tests and tidying up things.

* Updating solutions for renamed project

* Updating projects for rename.

* Oneclient secret (#245)

* ADding Secret Apis

* Using Task for secret

* Format (#242)

* Updating samples.slm

* awaint the call to grpc in common method so that common error handling can be done there.

* Addressing review comments

* fixing test.sln

* updating prod.sln

* Addressing review comments from James.

* Add doc and example for method invocation on http app

* Updating arg validation.

* Updating example.

Co-authored-by: LM <lemai>
Co-authored-by: Carlos Mendible <cmendible@gmail.com>
2020-03-09 20:52:12 -07:00
Carlos Landeras 334766c28a
Pass serializer options to InvokeMethodAsync<TRequest,TResponse> #234 (#235)
* Pass serializer options to InvokeMethodAsync<TRequest,TResponse>

* Fix invoke method serializer options + tests

* Change assertion to already defined response object
2020-02-26 09:20:52 -08:00
Nkosinathi Sangweni d7fea33c45
Malotho/making actorstestable (#229)
* Getting started with Actor testability

* Added unitests against the Actor Class.
This is to verify that there are no breaking changes, and that the actor class can take any ActorStateManager.

* removed the private constructor

* resolving an issue with causing a null reference exception.
This was caused by an incorrect order of assignment in the constructor.
2020-02-21 22:10:06 -08:00
Aman Bhardwaj ea51561f49
git gui, ading editor config and removing depenency on StyleCop.Analyzers (#228) 2020-02-18 13:21:12 -08:00
Aman Bhardwaj b1157cbc4f Revert "Malotho/making actorstestable (#220)"
This reverts commit 1bacce6734.
2020-02-15 09:41:37 -08:00