Remove deprecated method RenameActorReminder (#466)

Fixes #465

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

client/actor.go

@@ -194,45 +194,6 @@ func (c *GRPCClient) UnregisterActorReminder(ctx context.Context, in *Unregister
 	return nil
 }
 
-type RenameActorReminderRequest struct {
-	OldName   string
-	ActorType string
-	ActorID   string
-	NewName   string
-}
-
-// RenameActorReminder would rename the actor reminder.
-func (c *GRPCClient) RenameActorReminder(ctx context.Context, in *RenameActorReminderRequest) error {
-	if in == nil {
-		return errors.New("actor rename reminder invocation request param required")
-	}
-	if in.ActorType == "" {
-		return errors.New("actor rename reminder invocation actorType required")
-	}
-	if in.ActorID == "" {
-		return errors.New("actor rename reminder invocation actorID required")
-	}
-	if in.OldName == "" {
-		return errors.New("actor rename reminder invocation oldName required")
-	}
-	if in.NewName == "" {
-		return errors.New("actor rename reminder invocation newName required")
-	}
-
-	req := &pb.RenameActorReminderRequest{
-		ActorType: in.ActorType,
-		ActorId:   in.ActorID,
-		OldName:   in.OldName,
-		NewName:   in.NewName,
-	}
-
-	_, err := c.protoClient.RenameActorReminder(c.withAuthToken(ctx), req)
-	if err != nil {
-		return fmt.Errorf("error invoking rename actor reminder %s/%s: %w", in.ActorType, in.ActorID, err)
-	}
-	return nil
-}
-
 type RegisterActorTimerRequest struct {
 	ActorType string
 	ActorID   string

client/actor_test.go

@@ -257,65 +257,6 @@ func TestUnregisterActorReminder(t *testing.T) {
 	})
 }
 
-func TestRenameActorReminder(t *testing.T) {
-	ctx := context.Background()
-
-	registerReminderReq := &RegisterActorReminderRequest{
-		ActorID:   "fn",
-		Data:      []byte(`{hello}`),
-		ActorType: testActorType,
-		Name:      "oldName",
-		Period:    "2s",
-		DueTime:   "4s",
-		TTL:       "20s",
-	}
-
-	testClient.RegisterActorReminder(ctx, registerReminderReq)
-
-	renameReminderReq := &RenameActorReminderRequest{
-		ActorID:   "fn",
-		ActorType: testActorType,
-		OldName:   "oldName",
-		NewName:   "newName",
-	}
-
-	t.Run("invoke rename actor reminder without actorType", func(t *testing.T) {
-		renameReminderReq.ActorType = ""
-		err := testClient.RenameActorReminder(ctx, renameReminderReq)
-		renameReminderReq.ActorType = testActorType
-		assert.Error(t, err)
-	})
-
-	t.Run("invoke rename actor reminder without id ", func(t *testing.T) {
-		renameReminderReq.ActorID = ""
-		err := testClient.RenameActorReminder(ctx, renameReminderReq)
-		renameReminderReq.ActorID = "fn"
-		assert.Error(t, err)
-	})
-
-	t.Run("invoke rename actor reminder without oldName ", func(t *testing.T) {
-		renameReminderReq.OldName = ""
-		err := testClient.RenameActorReminder(ctx, renameReminderReq)
-		renameReminderReq.OldName = "oldName"
-		assert.Error(t, err)
-	})
-
-	t.Run("invoke rename actor reminder without newName ", func(t *testing.T) {
-		renameReminderReq.NewName = ""
-		err := testClient.RenameActorReminder(ctx, renameReminderReq)
-		renameReminderReq.NewName = "newName"
-		assert.Error(t, err)
-	})
-
-	t.Run("invoke rename actor reminder ", func(t *testing.T) {
-		assert.NoError(t, testClient.RenameActorReminder(ctx, renameReminderReq))
-	})
-
-	t.Run("invoke rename actor reminder with empty param", func(t *testing.T) {
-		assert.Error(t, testClient.RenameActorReminder(ctx, nil))
-	})
-}
-
 func TestUnregisterActorTimer(t *testing.T) {
 	ctx := context.Background()
 	in := &UnregisterActorTimerRequest{

client/client.go

@@ -192,9 +192,6 @@ type Client interface {
 	// UnregisterActorReminder unregisters an actor reminder.
 	UnregisterActorReminder(ctx context.Context, req *UnregisterActorReminderRequest) error
 
-	// RenameActorReminder rename an actor reminder.
-	RenameActorReminder(ctx context.Context, req *RenameActorReminderRequest) error
-
 	// InvokeActor calls a method on an actor.
 	InvokeActor(ctx context.Context, req *InvokeActorRequest) (*InvokeActorResponse, error)
 

client/client_test.go

@@ -418,10 +418,6 @@ func (s *testDaprServer) UnregisterActorReminder(ctx context.Context, req *pb.Un
 	return &empty.Empty{}, nil
 }
 
-func (s *testDaprServer) RenameActorReminder(ctx context.Context, req *pb.RenameActorReminderRequest) (*empty.Empty, error) {
-	return &empty.Empty{}, nil
-}
-
 func (s *testDaprServer) InvokeActor(context.Context, *pb.InvokeActorRequest) (*pb.InvokeActorResponse, error) {
 	return &pb.InvokeActorResponse{
 		Data: []byte("mockValue"),

go.mod

@@ -3,7 +3,7 @@ module github.com/dapr/go-sdk
 go 1.19
 
 require (
-	github.com/dapr/dapr v1.12.0-rc.4
+	github.com/dapr/dapr v1.12.1-0.20231013174004-b6540a1c464d
 	github.com/go-chi/chi/v5 v5.0.10
 	github.com/golang/mock v1.6.0
 	github.com/golang/protobuf v1.5.3

go.sum

@@ -1,6 +1,6 @@
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
-github.com/dapr/dapr v1.12.0-rc.4 h1:LOPbekXZ+21HTqlk6Kg4Bf/lFiqq9cRq/IrgZgvK4mM=
+github.com/dapr/dapr v1.12.1-0.20231013174004-b6540a1c464d h1:7cEumjY6oXcXX/wapRB69WMxS+weWMK2Po5+/il5XjY=
-github.com/dapr/dapr v1.12.0-rc.4/go.mod h1:JZGZh8T0rz75DZBX3zGESi1p9IWWM0ZAGAzaGMHp+5o=
+github.com/dapr/dapr v1.12.1-0.20231013174004-b6540a1c464d/go.mod h1:zHcMel+UwYnMWfvJwpaDr43p95JteXyvBsSjXNnPU+c=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/go-chi/chi/v5 v5.0.10 h1:rLz5avzKpjqxrYwXNfmjkrYYXOyLJd37pz53UFHC6vk=