diff --git a/service/grpc/topic.go b/service/grpc/topic.go index d7cdc55..9bc1e4e 100644 --- a/service/grpc/topic.go +++ b/service/grpc/topic.go @@ -150,7 +150,7 @@ func (s *Server) OnTopicEvent(ctx context.Context, in *runtimev1pb.TopicEventReq if retry { return &runtimev1pb.TopicEventResponse{Status: runtimev1pb.TopicEventResponse_RETRY}, err } - return &runtimev1pb.TopicEventResponse{Status: runtimev1pb.TopicEventResponse_DROP}, err + return &runtimev1pb.TopicEventResponse{Status: runtimev1pb.TopicEventResponse_DROP}, nil } return &runtimev1pb.TopicEventResponse{Status: runtimev1pb.TopicEventResponse_RETRY}, fmt.Errorf( "pub/sub and topic combination not configured: %s/%s", diff --git a/service/grpc/topic_test.go b/service/grpc/topic_test.go index 18bc8cf..8dbfd76 100644 --- a/service/grpc/topic_test.go +++ b/service/grpc/topic_test.go @@ -217,7 +217,7 @@ func TestTopicWithErrors(t *testing.T) { PubsubName: sub2.PubsubName, } resp, err := server.OnTopicEvent(ctx, in) - assert.Error(t, err) + assert.NoError(t, err) assert.Equal(t, resp.GetStatus(), runtime.TopicEventResponse_DROP) })