From c5625c4d53bceff298567d34b368c535f74a1c9d Mon Sep 17 00:00:00 2001 From: Javier Aliaga Date: Mon, 4 Aug 2025 17:51:17 +0200 Subject: [PATCH] chore: Apply suggestions Signed-off-by: Javier Aliaga --- .../workflows/TestNamedActivitiesWorkflow.java | 12 +++++++----- .../runtime/WorkflowActivityClassWrapperTest.java | 7 ++----- .../runtime/WorkflowRuntimeBuilderTest.java | 12 +++++------- 3 files changed, 14 insertions(+), 17 deletions(-) diff --git a/sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/TestNamedActivitiesWorkflow.java b/sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/TestNamedActivitiesWorkflow.java index 11c3fc021..c5ce2107c 100644 --- a/sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/TestNamedActivitiesWorkflow.java +++ b/sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/TestNamedActivitiesWorkflow.java @@ -31,18 +31,20 @@ public class TestNamedActivitiesWorkflow implements Workflow { TestWorkflowPayload workflowPayload = ctx.getInput(TestWorkflowPayload.class); workflowPayload.setWorkflowId(instanceId); - var payloadAfterA = ctx.callActivity("a", workflowPayload, TestWorkflowPayload.class).await(); + var payloadAfterA = ctx.callActivity("a", workflowPayload, TestWorkflowPayload.class) + .await(); - var payloadAfterB = ctx.callActivity("b", payloadAfterA, TestWorkflowPayload.class).await(); + var payloadAfterB = ctx.callActivity("b", payloadAfterA, TestWorkflowPayload.class) + .await(); var payloadAfterC = ctx.callActivity("c", payloadAfterB, TestWorkflowPayload.class) - .await(); + .await(); var payloadAfterD = ctx.callActivity("d", payloadAfterC, TestWorkflowPayload.class) - .await(); + .await(); var payloadAfterE = ctx.callActivity("e", payloadAfterD, TestWorkflowPayload.class) - .await(); + .await(); ctx.complete(payloadAfterE); }; diff --git a/sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapperTest.java b/sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapperTest.java index 687968e22..f42a1d651 100644 --- a/sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapperTest.java +++ b/sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapperTest.java @@ -6,10 +6,7 @@ import io.dapr.workflows.WorkflowActivityContext; import org.junit.Test; import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.times; -import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; +import static org.mockito.Mockito.*; public class WorkflowActivityClassWrapperTest { public static class TestActivity implements WorkflowActivity { @@ -22,7 +19,7 @@ public class WorkflowActivityClassWrapperTest { @Test public void getName() { - WorkflowActivityClassWrapper wrapper = new WorkflowActivityClassWrapper<>( TestActivity.class); + WorkflowActivityClassWrapper wrapper = new WorkflowActivityClassWrapper<>(TestActivity.class); assertEquals( "io.dapr.workflows.runtime.WorkflowActivityClassWrapperTest.TestActivity", diff --git a/sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowRuntimeBuilderTest.java b/sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowRuntimeBuilderTest.java index c9e2a5d78..4b83b520a 100644 --- a/sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowRuntimeBuilderTest.java +++ b/sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowRuntimeBuilderTest.java @@ -19,15 +19,13 @@ import io.dapr.workflows.WorkflowStub; import org.junit.jupiter.api.Test; import org.slf4j.Logger; -import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; -import static org.mockito.ArgumentMatchers.eq; -import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.times; -import static org.mockito.Mockito.verify; - import java.io.ByteArrayOutputStream; import java.io.PrintStream; +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; +import static org.mockito.ArgumentMatchers.eq; +import static org.mockito.Mockito.*; + public class WorkflowRuntimeBuilderTest { public static class TestWorkflow implements Workflow { @Override @@ -94,6 +92,6 @@ public class WorkflowRuntimeBuilderTest { .info(eq("Registered Workflow: {}"), eq("TestWorkflow")); verify(testLogger, times(1)) - .info(eq("Registered Activity: {}"), eq( "io.dapr.workflows.runtime.WorkflowRuntimeBuilderTest.TestActivity")); + .info(eq("Registered Activity: {}"), eq("io.dapr.workflows.runtime.WorkflowRuntimeBuilderTest.TestActivity")); } }