discourse
/
discourse-adplugin
mirror of https://github.com/discourse/discourse-adplugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #66 from gitcoinco/feature/only-request-on-id-provided 

Ensure CodeFund request is only made if the Property ID is provided
This commit is contained in:
Neil Lalonde 2018-06-22 16:46:22 -04:00 committed by GitHub
parent eb4f18aaa8 014ee3187b
commit 425b64a9c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@ -11,6 +11,7 @@ This is the official Discourse advertising plugin. It allows advertisements to
* [Google Adsense](http://www.google.com.au/adsense/start/why-adsense.html) * [Google Adsense](http://www.google.com.au/adsense/start/why-adsense.html)
* [Google Double Click for Publishers](https://www.google.com/dfp) * [Google Double Click for Publishers](https://www.google.com/dfp)
* [Amazon Affiliates](http://affiliate-program.amazon.com) - Banner and Product Link Ads * [Amazon Affiliates](http://affiliate-program.amazon.com) - Banner and Product Link Ads
* [CodeFund](https://codefund.io) - Ethical Ad Platform for Developers
## Quick Start in 3 Steps ## Quick Start in 3 Steps
@ -58,6 +59,7 @@ There are 2 easy steps for configuring your Discourse settings to enable adverti
<ul> <ul>
<li>Adsense - if using Adsense as your advertisement platform.</li> <li>Adsense - if using Adsense as your advertisement platform.</li>
<li>DFP - if using the DoubleClick for Publishers advertisement platform.</li> <li>DFP - if using the DoubleClick for Publishers advertisement platform.</li>
<li>CodeFund - if using the CodeFund ethical advertisement platform.</li>
</ul> </ul>
</ul> </ul>
@ -82,7 +84,9 @@ Only for Product Link and Banner Ads.
![](https://www.dropbox.com/sc/l67fb5c3tl8bq3d/AAAAMmccMW3kkIeBR7cBdWoFa?dl=1) ![](https://www.dropbox.com/sc/l67fb5c3tl8bq3d/AAAAMmccMW3kkIeBR7cBdWoFa?dl=1)
##### CodeFund Embed Tag to Discourse's Site Settings
![CodeFund Instructions](https://s3-us-west-2.amazonaws.com/codesponsor/discourse-codefund-instructions.png)
### Step 3 - See Your Ad ### Step 3 - See Your Ad

2
assets/javascripts/discourse/components/codefund-ad.js.es6
View File

@ -49,6 +49,8 @@ export default Ember.Component.extend({
adDetails: {}, adDetails: {},
_triggerAds() { _triggerAds() {
if (!propertyId) return;
this.set('adRequested', true); this.set('adRequested', true);
loadCodeFund().then((data) => { loadCodeFund().then((data) => {
_loaded = false; _loaded = false;