From 1573e6a6942dd7d66e49864801cd1c97e568eb35 Mon Sep 17 00:00:00 2001 From: Kris Date: Fri, 9 May 2025 12:34:53 -0400 Subject: [PATCH] UX: don't show AI suggestions in composer when inputs are disabled (#1331) --- .../components/suggestion-menus/ai-tag-suggester.gjs | 5 +++++ .../ai-category-suggestion.gjs | 10 +++++++++- .../after-composer-title-input/ai-title-suggestion.gjs | 4 +++- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/assets/javascripts/discourse/components/suggestion-menus/ai-tag-suggester.gjs b/assets/javascripts/discourse/components/suggestion-menus/ai-tag-suggester.gjs index d97f318a..952ae7ce 100644 --- a/assets/javascripts/discourse/components/suggestion-menus/ai-tag-suggester.gjs +++ b/assets/javascripts/discourse/components/suggestion-menus/ai-tag-suggester.gjs @@ -16,6 +16,7 @@ import { MIN_CHARACTER_COUNT } from "../../lib/ai-helper-suggestions"; export default class AiTagSuggester extends Component { @service siteSettings; @service toasts; + @service composer; @tracked loading = false; @tracked suggestions = null; @@ -24,6 +25,10 @@ export default class AiTagSuggester extends Component { @tracked content = null; get showSuggestionButton() { + if (this.composer.disableTagsChooser) { + return false; + } + const composerFields = document.querySelector(".composer-fields"); this.content = this.args.composer?.reply; const showTrigger = diff --git a/assets/javascripts/discourse/connectors/after-composer-category-input/ai-category-suggestion.gjs b/assets/javascripts/discourse/connectors/after-composer-category-input/ai-category-suggestion.gjs index 47cc9d88..b756a2af 100644 --- a/assets/javascripts/discourse/connectors/after-composer-category-input/ai-category-suggestion.gjs +++ b/assets/javascripts/discourse/connectors/after-composer-category-input/ai-category-suggestion.gjs @@ -1,4 +1,5 @@ import Component from "@glimmer/component"; +import { service } from "@ember/service"; import AiCategorySuggester from "../../components/suggestion-menus/ai-category-suggester"; import { showComposerAiHelper } from "../../lib/show-ai-helper"; @@ -12,7 +13,14 @@ export default class AiCategorySuggestion extends Component { ); } + @service composer; + } diff --git a/assets/javascripts/discourse/connectors/after-composer-title-input/ai-title-suggestion.gjs b/assets/javascripts/discourse/connectors/after-composer-title-input/ai-title-suggestion.gjs index 74ce20e2..df1bbd9d 100644 --- a/assets/javascripts/discourse/connectors/after-composer-title-input/ai-title-suggestion.gjs +++ b/assets/javascripts/discourse/connectors/after-composer-title-input/ai-title-suggestion.gjs @@ -13,6 +13,8 @@ export default class AiTitleSuggestion extends Component { } }