discourse
/
discourse-ai
mirror of https://github.com/discourse/discourse-ai.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: rewrites artifact spec with capybara waiters (#1347) 

Generally speaking we never want to do:

```
expect(element.text).to eq("foo")
```

As these are rspec matchers and do not add further Capybara-style waiting specifically for the text content to become present.
This commit is contained in:
Joffrey JAFFEUX 2025-05-19 23:27:15 +02:00 committed by GitHub
parent 3ac2359ff1
commit 296aa24df1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
spec/system/ai_bot/artifact_spec.rb
View File

@ -48,30 +48,26 @@ RSpec.describe "AI Artifact with Data Attributes", type: :system do
find(".ai-artifact__click-to-run button").click find(".ai-artifact__click-to-run button").click
artifact_element_selector = ".ai-artifact[data-ai-artifact-id='#{ai_artifact.id}']" artifact_element_selector = ".ai-artifact[data-ai-artifact-id='#{ai_artifact.id}']"
iframe_selector = "#{artifact_element_selector} iframe" artifact_element = find(artifact_element_selector)
expect(page).to have_css(iframe_selector) expect(artifact_element).to have_css("iframe[data-custom-message='hello-from-post']")
expect(artifact_element).to have_css("iframe[data-post-author-id='#{author.id}']")
iframe_element = find(iframe_selector)
expect(iframe_element["data-custom-message"]).to eq("hello-from-post")
expect(iframe_element["data-post-author-id"]).to eq(author.id.to_s)
# note: artifacts are within nested iframes for security reasons # note: artifacts are within nested iframes for security reasons
page.within_frame(iframe_element) do iframe_element = artifact_element.find("iframe")
within_frame(iframe_element) do
inner_iframe = find("iframe") inner_iframe = find("iframe")
page.within_frame(inner_iframe) do within_frame(inner_iframe) do
data_display_element = find("#data-display") data_selector = "#data-display"
expect(page).to have_selector(data_selector, text: /.+/)
expect(page).to have_no_selector(data_selector, text: "Waiting for data...")
expect(page).to have_no_selector(data_selector, text: "Error:")
expect(data_display_element.text).not_to be_empty artifact_data_json = find(data_selector).text
expect(data_display_element.text).not_to eq("Waiting for data...")
expect(data_display_element.text).not_to include("Error:")
artifact_data_json = data_display_element.text
artifact_data = JSON.parse(artifact_data_json) artifact_data = JSON.parse(artifact_data_json)
expect(artifact_data["customMessage"]).to eq("hello-from-post") expect(artifact_data["customMessage"]).to eq("hello-from-post")
expect(artifact_data["postAuthorId"]).to eq(author.id.to_s) expect(artifact_data["postAuthorId"]).to eq(author.id.to_s)
expect(artifact_data["username"]).to eq(user.username) expect(artifact_data["username"]).to eq(user.username)
end end
end end