From 60fe924ce04f1b3985b0657e1f3afac63e6c8927 Mon Sep 17 00:00:00 2001 From: Keegan George Date: Wed, 26 Mar 2025 14:24:02 -0700 Subject: [PATCH] DEV: Remove no longer needed click outside logic (#1223) The older design approach for sentiment analysis report needed the click outside logic. However, when the design was changed this logic was accidentally left behind. It is potentially causing some negative performance impacts. This PR removes the old unnecessary logic. --- .../components/admin-report-sentiment-analysis.gjs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs b/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs index ec1b993a..2623f685 100644 --- a/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs +++ b/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs @@ -1,6 +1,6 @@ import Component from "@glimmer/component"; import { tracked } from "@glimmer/tracking"; -import { fn, hash } from "@ember/helper"; +import { fn } from "@ember/helper"; import { on } from "@ember/modifier"; import { action } from "@ember/object"; import didInsert from "@ember/render-modifiers/modifiers/did-insert"; @@ -21,7 +21,6 @@ import discourseLater from "discourse/lib/later"; import { clipboardCopy } from "discourse/lib/utilities"; import Category from "discourse/models/category"; import Post from "discourse/models/post"; -import closeOnClickOutside from "discourse/modifiers/close-on-click-outside"; import { i18n } from "discourse-i18n"; import DTooltip from "float-kit/components/d-tooltip"; import DoughnutChart from "discourse/plugins/discourse-ai/discourse/components/doughnut-chart"; @@ -343,13 +342,6 @@ export default class AdminReportSentimentAnalysis extends Component { class="sentiment-analysis-table__row" role="button" {{on "click" (fn this.showDetails data)}} - {{closeOnClickOutside - (fn (mut this.selectedChart) null) - (hash - targetSelector=".admin-report-sentiment-analysis-details" - secondaryTargetSelector=".admin-report-sentiment-analysis" - ) - }} > {{#if data.category}}