From 6543c50758ef6d04ca84fabfa52bf92773086018 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 31 Mar 2023 12:04:17 +1100 Subject: [PATCH] FIX: stop returning self as a candidate for related topics (#31) --- lib/modules/embeddings/semantic_related.rb | 1 + spec/lib/modules/embeddings/semantic_related_spec.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/modules/embeddings/semantic_related.rb b/lib/modules/embeddings/semantic_related.rb index 974d3bf3..db60ce91 100644 --- a/lib/modules/embeddings/semantic_related.rb +++ b/lib/modules/embeddings/semantic_related.rb @@ -34,6 +34,7 @@ module DiscourseAi .visible .listable_topics .secured + .where("id <> ?", topic.id) .where(id: candidate_ids) .order("array_position(ARRAY#{candidate_ids}, id)") .limit(SiteSetting.ai_embeddings_semantic_related_topics) diff --git a/spec/lib/modules/embeddings/semantic_related_spec.rb b/spec/lib/modules/embeddings/semantic_related_spec.rb index 3bf8404c..b72a477e 100644 --- a/spec/lib/modules/embeddings/semantic_related_spec.rb +++ b/spec/lib/modules/embeddings/semantic_related_spec.rb @@ -29,6 +29,7 @@ describe DiscourseAi::Embeddings::SemanticRelated do expect(results).to include(normal_topic_1) expect(results).to include(normal_topic_2) expect(results).to include(normal_topic_3) + expect(results).to_not include(target) expect(results).to_not include(unlisted_topic) expect(results).to_not include(private_topic) expect(results).to_not include(secured_category_topic)