Fix invalid arguments passed to `find_by`.

This commit is contained in:
Guo Xiang Tan 2019-04-30 09:56:06 +08:00
parent 7b7432990a
commit 00a9cb1752
2 changed files with 12 additions and 1 deletions

View File

@ -3,7 +3,7 @@ module Jobs
sidekiq_options queue: 'low'
def execute(args)
user = User.find_by(args[:user_id])
user = User.find_by(id: args[:user_id])
raise Discourse::InvalidParameters.new(:user_id) if user.nil?
PendingAssignsReminder.new.remind(user)

View File

@ -0,0 +1,11 @@
require 'rails_helper'
RSpec.describe Jobs::RemindUser do
describe '#execute' do
it "should raise the right error when user_id is invalid" do
expect do
described_class.new.execute({})
end.to raise_error(Discourse::InvalidParameters)
end
end
end