discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: `upsert` was less safe under concurrency

This commit is contained in:
Robin Ward 2018-05-08 17:53:18 -04:00
parent 754209ce58
commit 3905f8f992
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/topic_assigner.rb
View File

@ -114,7 +114,9 @@ SQL
end end
def assign(assign_to, silent: false) def assign(assign_to, silent: false)
@topic.upsert_custom_fields(assigned_to_id: assign_to.id, assigned_by_id: @assigned_by.id) @topic.custom_fields["assigned_to_id"] = assign_to.id
@topic.custom_fields["assigned_by_id"] = @assigned_by.id
@topic.save!
first_post = @topic.posts.find_by(post_number: 1) first_post = @topic.posts.find_by(post_number: 1)
first_post.publish_change_to_clients!(:revised, reload_topic: true) first_post.publish_change_to_clients!(:revised, reload_topic: true)
@ -179,7 +181,9 @@ SQL
def unassign(silent: false) def unassign(silent: false)
if assigned_to_id = @topic.custom_fields["assigned_to_id"] if assigned_to_id = @topic.custom_fields["assigned_to_id"]
@topic.upsert_custom_fields(assigned_to_id: nil, assigned_by_id: nil) @topic.custom_fields["assigned_to_id"] = nil
@topic.custom_fields["assigned_by_id"] = nil
@topic.save!
post = @topic.posts.where(post_number: 1).first post = @topic.posts.where(post_number: 1).first
return unless post.present? return unless post.present?