From 3a58df219ca191e56723f9f774c36dd3dce770a8 Mon Sep 17 00:00:00 2001 From: Krzysztof Kotlarek Date: Wed, 29 Sep 2021 11:01:15 +1000 Subject: [PATCH] FIX: n+1 query on list of private messages assigned (#216) When getting a list of private messages assigned to groups/users, we should include :allowed_users to avoid n+1 --- plugin.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugin.rb b/plugin.rb index 2d87958..8ed9e50 100644 --- a/plugin.rb +++ b/plugin.rb @@ -294,7 +294,7 @@ after_initialize do sql = "topics.id IN (#{topic_ids_sql})" - list = list.where(sql, user_id: user.id) + list = list.where(sql, user_id: user.id).includes(:allowed_users) create_list(:assigned, { unordered: true }, list) end @@ -319,7 +319,7 @@ after_initialize do sql = "topics.id IN (#{topic_ids_sql})" - list = list.where(sql, group_id: group.id) + list = list.where(sql, group_id: group.id).includes(:allowed_users) create_list(:assigned, { unordered: true }, list) end