From 55f8d24b1fe672586cb077eb269ecb66de54c959 Mon Sep 17 00:00:00 2001 From: Natalie Tay Date: Tue, 15 Aug 2023 14:12:10 +0800 Subject: [PATCH] DEV: Increase the buffer used to determine whether to send out the reminder email (#499) Increase the buffer used to determine whether to send out the reminder email --- app/jobs/scheduled/enqueue_reminders.rb | 2 +- spec/jobs/scheduled/enqueue_reminders_spec.rb | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/jobs/scheduled/enqueue_reminders.rb b/app/jobs/scheduled/enqueue_reminders.rb index 13aea39..3e9596e 100644 --- a/app/jobs/scheduled/enqueue_reminders.rb +++ b/app/jobs/scheduled/enqueue_reminders.rb @@ -20,7 +20,7 @@ module Jobs Group.assign_allowed_groups.pluck(:id).join(",") end - REMINDER_BUFFER_MINUTES = 10 + REMINDER_BUFFER_MINUTES = 120 def user_ids global_frequency = SiteSetting.remind_assigns_frequency diff --git a/spec/jobs/scheduled/enqueue_reminders_spec.rb b/spec/jobs/scheduled/enqueue_reminders_spec.rb index 5dec108..bb19349 100644 --- a/spec/jobs/scheduled/enqueue_reminders_spec.rb +++ b/spec/jobs/scheduled/enqueue_reminders_spec.rb @@ -52,16 +52,20 @@ RSpec.describe Jobs::EnqueueReminders do user.custom_fields[ PendingAssignsReminder::REMINDERS_FREQUENCY ] = RemindAssignsFrequencySiteSettings::DAILY_MINUTES - user.custom_fields[PendingAssignsReminder::REMINDED_AT] = 1.days.ago + user.custom_fields[PendingAssignsReminder::REMINDED_AT] = 1.days.ago + + (Jobs::EnqueueReminders::REMINDER_BUFFER_MINUTES - 1) user.save - assign_multiple_tasks_to(user, assigned_on: 1.day.ago - 1.minute) + assign_multiple_tasks_to(user, assigned_on: 2.day.ago) assert_reminders_enqueued(1) end it "does not enqueue a reminder if it's too soon" do - user.upsert_custom_fields(PendingAssignsReminder::REMINDED_AT => 1.days.ago) + user.upsert_custom_fields( + PendingAssignsReminder::REMINDED_AT => + 1.days.ago + Jobs::EnqueueReminders::REMINDER_BUFFER_MINUTES, + ) assign_multiple_tasks_to(user) assert_reminders_enqueued(0)