Rearrange specs for frequency

This commit is contained in:
Nat 2023-08-08 13:27:10 +08:00
parent 8f04d82ae7
commit 6c3fd0f088
No known key found for this signature in database
GPG Key ID: C095C891379A319E
1 changed files with 43 additions and 41 deletions

View File

@ -36,8 +36,19 @@ RSpec.describe Jobs::EnqueueReminders do
assert_reminders_enqueued(0)
end
it "doesn't count assigns from deleted topics" do
deleted_post = Fabricate(:post)
assign_one_task_to(user, post: deleted_post)
(PendingAssignsReminder::REMINDER_THRESHOLD - 1).times { assign_one_task_to(user) }
deleted_post.topic.trash!
assert_reminders_enqueued(0)
end
describe "assignment frequency" do
it "does not enqueue a reminder if it's too soon" do
user.upsert_custom_fields(PendingAssignsReminder::REMINDED_AT => 2.days.ago)
user.upsert_custom_fields(PendingAssignsReminder::REMINDED_AT => 1.days.ago)
assign_multiple_tasks_to(user)
assert_reminders_enqueued(0)
@ -76,15 +87,6 @@ RSpec.describe Jobs::EnqueueReminders do
assert_reminders_enqueued(1)
end
it "doesn't count assigns from deleted topics" do
deleted_post = Fabricate(:post)
assign_one_task_to(user, post: deleted_post)
(PendingAssignsReminder::REMINDER_THRESHOLD - 1).times { assign_one_task_to(user) }
deleted_post.topic.trash!
assert_reminders_enqueued(0)
end
def assert_reminders_enqueued(expected_amount)