discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactored test

This commit is contained in:
Juan David Martinez 2025-03-14 17:16:41 -05:00
parent 6f7a7ab363
commit 7279e8e64b
No known key found for this signature in database
GPG Key ID: FE50F4B983E68D5B
1 changed files with 16 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
spec/system/assign_post_spec.rb
View File

@ -19,15 +19,18 @@ describe "Assign | Assigning posts", type: :system do
sign_in(admin) sign_in(admin)
end end
def assign_post(post, assignee)
topic_page.click_assign_post(post)
assign_modal.assignee = assignee
assign_modal.confirm
end
describe "with open topic" do describe "with open topic" do
before { SiteSetting.prioritize_full_name_in_ux = false } before { SiteSetting.prioritize_full_name_in_ux = false }
it "can assign and unassign" do it "can assign and unassign" do
visit "/t/#{topic.id}" visit "/t/#{topic.id}"
assign_post(post2, staff_user)
topic_page.click_assign_post(post2)
assign_modal.assignee = staff_user
assign_modal.confirm
expect(assign_modal).to be_closed expect(assign_modal).to be_closed
@ -65,9 +68,8 @@ describe "Assign | Assigning posts", type: :system do
it "shows the user's name after assign" do it "shows the user's name after assign" do
visit "/t/#{topic.id}" visit "/t/#{topic.id}"
topic_page.click_assign_post(post2) assign_post(post2, staff_user)
assign_modal.assignee = staff_user
assign_modal.confirm
expect(topic_page.find_post_assign(post1.post_number)).to have_content(staff_user.name) expect(topic_page.find_post_assign(post1.post_number)).to have_content(staff_user.name)
expect(topic_page.find_post_assign(post2.post_number)).to have_content(staff_user.name) expect(topic_page.find_post_assign(post2.post_number)).to have_content(staff_user.name)
end end
@ -78,9 +80,8 @@ describe "Assign | Assigning posts", type: :system do
staff_user.save staff_user.save
staff_user.reload staff_user.reload
topic_page.click_assign_post(post2) assign_post(post2, staff_user)
assign_modal.assignee = staff_user
assign_modal.confirm
expect(topic_page.find_post_assign(post1.post_number)).to have_content(staff_user.username) expect(topic_page.find_post_assign(post1.post_number)).to have_content(staff_user.username)
expect(topic_page.find_post_assign(post2.post_number)).to have_content(staff_user.username) expect(topic_page.find_post_assign(post2.post_number)).to have_content(staff_user.username)
end end
@ -92,9 +93,7 @@ describe "Assign | Assigning posts", type: :system do
it "assigned small action post has 'private-assign' in class attribute" do it "assigned small action post has 'private-assign' in class attribute" do
visit "/t/#{topic.id}" visit "/t/#{topic.id}"
topic_page.click_assign_post(post2) assign_post(post2, staff_user)
assign_modal.assignee = staff_user
assign_modal.confirm
expect(assign_modal).to be_closed expect(assign_modal).to be_closed
expect(topic_page).to have_assigned_post( expect(topic_page).to have_assigned_post(
@ -111,9 +110,7 @@ describe "Assign | Assigning posts", type: :system do
it "unassigns the topic on close" do it "unassigns the topic on close" do
visit "/t/#{topic.id}" visit "/t/#{topic.id}"
topic_page.click_assign_post(post2) assign_post(post2, staff_user)
assign_modal.assignee = staff_user
assign_modal.confirm
expect(assign_modal).to be_closed expect(assign_modal).to be_closed
expect(topic_page).to have_assigned_post(user: staff_user, at_post: 3) expect(topic_page).to have_assigned_post(user: staff_user, at_post: 3)
@ -131,9 +128,7 @@ describe "Assign | Assigning posts", type: :system do
it "can assign the previous assignee" do it "can assign the previous assignee" do
visit "/t/#{topic.id}" visit "/t/#{topic.id}"
topic_page.click_assign_post(post2) assign_post(post2, staff_user)
assign_modal.assignee = staff_user
assign_modal.confirm
expect(assign_modal).to be_closed expect(assign_modal).to be_closed
expect(topic_page).to have_assigned_post(user: staff_user, at_post: 3) expect(topic_page).to have_assigned_post(user: staff_user, at_post: 3)
@ -147,9 +142,7 @@ describe "Assign | Assigning posts", type: :system do
expect(page).to have_no_css("#post_5") expect(page).to have_no_css("#post_5")
expect(page).to have_no_css("#topic .assigned-to") expect(page).to have_no_css("#topic .assigned-to")
topic_page.click_assign_post(post2) assign_post(post2, staff_user)
assign_modal.assignee = staff_user
assign_modal.confirm
expect(page).to have_no_css("#post_5") expect(page).to have_no_css("#post_5")
expect(topic_page.find_post_assign(post1.post_number)).to have_content(staff_user.username) expect(topic_page.find_post_assign(post1.post_number)).to have_content(staff_user.username)
@ -162,10 +155,7 @@ describe "Assign | Assigning posts", type: :system do
it "reassigns the topic on open" do it "reassigns the topic on open" do
visit "/t/#{topic.id}" visit "/t/#{topic.id}"
topic_page.click_assign_post(post2) assign_post(post2, staff_user)
assign_modal.assignee = staff_user
assign_modal.confirm
expect(assign_modal).to be_closed expect(assign_modal).to be_closed
expect(topic_page).to have_assigned_post(user: staff_user, at_post: 3) expect(topic_page).to have_assigned_post(user: staff_user, at_post: 3)