From 7c18124a32dd75143c873eb359a166acb61a6e72 Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Thu, 31 Aug 2023 12:51:51 +1000 Subject: [PATCH] DEV: Fix REMINDER_BUFFER_MINUTES const reassignment warning (#506) Without ||=, ruby warns the const is being reassigned all the time. --- app/jobs/scheduled/enqueue_reminders.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/jobs/scheduled/enqueue_reminders.rb b/app/jobs/scheduled/enqueue_reminders.rb index 3e9596e..bead65c 100644 --- a/app/jobs/scheduled/enqueue_reminders.rb +++ b/app/jobs/scheduled/enqueue_reminders.rb @@ -2,6 +2,8 @@ module Jobs class EnqueueReminders < ::Jobs::Scheduled + REMINDER_BUFFER_MINUTES ||= 120 + every 1.day def execute(_args) @@ -20,8 +22,6 @@ module Jobs Group.assign_allowed_groups.pluck(:id).join(",") end - REMINDER_BUFFER_MINUTES = 120 - def user_ids global_frequency = SiteSetting.remind_assigns_frequency frequency =