From 7d83a98b45bfe3b3317cc9f6179f59eea5ea7837 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Wed, 23 Feb 2022 18:23:52 +0100 Subject: [PATCH] DEV: Resolve small TODOs; fix a typo (#296) --- plugin.rb | 11 +++-------- spec/lib/assigner_spec.rb | 14 ++------------ 2 files changed, 5 insertions(+), 20 deletions(-) diff --git a/plugin.rb b/plugin.rb index c803ea2..bb86f22 100644 --- a/plugin.rb +++ b/plugin.rb @@ -37,14 +37,9 @@ after_initialize do require 'assigner' require 'pending_assigns_reminder' - # TODO: Drop when Discourse stable 2.8.0 is released - if respond_to?(:register_group_param) - register_group_param(:assignable_level) - end - if respond_to?(:register_groups_callback_for_users_search_controller_action) - register_groups_callback_for_users_search_controller_action(:assignable_groups) do |groups, user| - groups.assignable(user) - end + register_group_param(:assignable_level) + register_groups_callback_for_users_search_controller_action(:assignable_groups) do |groups, user| + groups.assignable(user) end reloadable_patch do |plugin| diff --git a/spec/lib/assigner_spec.rb b/spec/lib/assigner_spec.rb index 427f0ea..4db6669 100644 --- a/spec/lib/assigner_spec.rb +++ b/spec/lib/assigner_spec.rb @@ -9,16 +9,6 @@ RSpec.describe Assigner do let(:pm_post) { Fabricate(:private_message_post) } let(:pm) { pm_post.topic } - # TODO later remove that stuff - def assert_publish_topic_state(topic, user) - message = MessageBus.track_publish("/private-messages/assigned") do - yield - end.first - - expect(message.data[:topic_id]).to eq(topic.id) - expect(message.user_ids).to eq([user.id]) - end - context "assigning and unassigning" do let(:post) { Fabricate(:post) } let(:topic) { post.topic } @@ -118,8 +108,8 @@ RSpec.describe Assigner do expect(assigned_to?(another_mod)).to eq(true) end - def assigned_to?(asignee) - assigner.assign(asignee).fetch(:success) + def assigned_to?(assignee) + assigner.assign(assignee).fetch(:success) end it "doesn't assign if the user has too many assigned topics" do