From 7fe45c8eb565b490749699019af0030901a5590b Mon Sep 17 00:00:00 2001
From: Kris <kris.aubuchon@discourse.org>
Date: Thu, 19 Oct 2023 20:40:55 -0400
Subject: [PATCH] UX: simplify markup to fix j/k highlighting (#516)

This cleans up the markup a bit, so instead of a `div` as a table child we use the `td` and removes the internal wrapper. This fixes an issue with a double highlight while using j/k navigation highlighting caused by the nested `td`.
---
 .../discourse/components/assigned-topic-list-column.gjs         | 2 --
 assets/javascripts/discourse/raw-views/assign-topic-buttons.gjs | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/assets/javascripts/discourse/components/assigned-topic-list-column.gjs b/assets/javascripts/discourse/components/assigned-topic-list-column.gjs
index f160688..92d44c2 100644
--- a/assets/javascripts/discourse/components/assigned-topic-list-column.gjs
+++ b/assets/javascripts/discourse/components/assigned-topic-list-column.gjs
@@ -5,7 +5,6 @@ import { action } from "@ember/object";
 
 export default class AssignedTopicListColumn extends Component {
   <template>
-    <td class="topic-list-data">
       {{#if @topic.assigned_to_user}}
         <AssignActionsDropdown
           @topic={{@topic}}
@@ -24,7 +23,6 @@ export default class AssignedTopicListColumn extends Component {
       {{else}}
         <AssignActionsDropdown @topic={{@topic}} @unassign={{this.unassign}} />
       {{/if}}
-    </td>
   </template>
 
   @service taskActions;
diff --git a/assets/javascripts/discourse/raw-views/assign-topic-buttons.gjs b/assets/javascripts/discourse/raw-views/assign-topic-buttons.gjs
index d96a8fd..7991568 100644
--- a/assets/javascripts/discourse/raw-views/assign-topic-buttons.gjs
+++ b/assets/javascripts/discourse/raw-views/assign-topic-buttons.gjs
@@ -12,7 +12,7 @@ export default class extends EmberObject {
     if (ASSIGN_LIST_ROUTES.includes(this.router.currentRouteName)) {
       return rawRenderGlimmer(
         this,
-        "div.assign-topic-buttons",
+        "td.assign-topic-buttons",
         <template><AssignedTopicListColumn @topic={{@data.topic}} /></template>,
         { topic: this.topic }
       );