discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix flaky system tests 

Why this change?

For some reason, toggling the topic admin menu via the button in the
footer is causing the test to be flaky. I don't have enough time to
figure out the root cause but we want to avoid these tests being flaky.
As such we'll use the topic admin menu in the timeline instead to close
the topic.
This commit is contained in:
Alan Guo Xiang Tan 2023-07-05 14:23:16 +08:00
parent 47a1170ec5
commit 897f9aa627
No known key found for this signature in database
GPG Key ID: 3F656E28E3AADEF1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/system/assign_topic_spec.rb
View File

@ -60,7 +60,7 @@ describe "Assign | Assigning topics", type: :system, js: true do
expect(topic_page).to have_assigned(user: staff_user, at_post: 2)
find(".topic-footer-main-buttons .toggle-admin-menu").click
find(".timeline-controls .toggle-admin-menu").click
find(".topic-admin-close").click
expect(find("#post_3")).to have_content(
@ -79,7 +79,7 @@ describe "Assign | Assigning topics", type: :system, js: true do
expect(topic_page).to have_assigned(user: staff_user, at_post: 2)
find(".topic-footer-main-buttons .toggle-admin-menu").click
find(".timeline-controls .toggle-admin-menu").click
find(".topic-admin-close").click
expect(find("#post_3")).to have_content(
@ -108,7 +108,7 @@ describe "Assign | Assigning topics", type: :system, js: true do
expect(topic_page).to have_assigned(user: staff_user, at_post: 2)
find(".topic-footer-main-buttons .toggle-admin-menu").click
find(".timeline-controls .toggle-admin-menu").click
find(".topic-admin-close").click
expect(find("#post_3")).to have_content(
@ -117,7 +117,7 @@ describe "Assign | Assigning topics", type: :system, js: true do
expect(page).to have_no_css("#post_4")
expect(page).to have_no_css("#topic .assigned-to")
find(".topic-footer-main-buttons .toggle-admin-menu").click
find(".timeline-controls .toggle-admin-menu").click
find(".topic-admin-open").click
expect(find("#post_4")).to have_content(