From 8b0596fc87b1991f4d9e228d38adcfde2f280578 Mon Sep 17 00:00:00 2001
From: Martin Brennan <mjrbrennan@gmail.com>
Date: Tue, 29 Jun 2021 10:12:19 +1000
Subject: [PATCH] FIX: Assign topic button not working (#164)

Since this commit
https://github.com/discourse/discourse-assign/commit/195dcc92cb3bab9dd7b7457efb7beca06959baae
the updateUsername function was missing an @action decorator. This adds
it back and extends the assign acceptance tests to click the
mobile/desktop assign buttons and open the modal and click the
suggestion to save the assignment.
---
 .../controllers/assign-user.js.es6            |  1 +
 .../acceptance/assign-enabled-test.js.es6     | 67 ++++++++++++++++++-
 2 files changed, 66 insertions(+), 2 deletions(-)

diff --git a/assets/javascripts/discourse-assign/controllers/assign-user.js.es6 b/assets/javascripts/discourse-assign/controllers/assign-user.js.es6
index 1d6fa03..563b520 100644
--- a/assets/javascripts/discourse-assign/controllers/assign-user.js.es6
+++ b/assets/javascripts/discourse-assign/controllers/assign-user.js.es6
@@ -79,6 +79,7 @@ export default Controller.extend({
       .catch(popupAjaxError);
   },
 
+  @action
   updateUsername(selected) {
     this.set("model.username", selected.firstObject);
   },
diff --git a/test/javascripts/acceptance/assign-enabled-test.js.es6 b/test/javascripts/acceptance/assign-enabled-test.js.es6
index 9ed1644..ac09694 100644
--- a/test/javascripts/acceptance/assign-enabled-test.js.es6
+++ b/test/javascripts/acceptance/assign-enabled-test.js.es6
@@ -11,13 +11,76 @@ acceptance("Assign mobile", function (needs) {
   needs.settings({ assign_enabled: true });
   needs.hooks.beforeEach(() => clearTopicFooterButtons());
 
+  needs.pretender((server, helper) => {
+    server.get("/assign/suggestions", () => {
+      return helper.response({
+        success: true,
+        assign_allowed_groups: false,
+        suggestions: [
+          {
+            id: 19,
+            username: "eviltrout",
+            name: "Robin Ward",
+            avatar_template:
+              "/user_avatar/meta.discourse.org/eviltrout/{size}/5275_2.png",
+          },
+        ],
+      });
+    });
+
+    server.put("/assign/assign", () => {
+      return helper.response({ success: true });
+    });
+  });
+
   test("Footer dropdown contains button", async (assert) => {
     updateCurrentUser({ can_assign: true });
-    const menu = selectKit(".topic-footer-mobile-dropdown");
-
     await visit("/t/internationalization-localization/280");
+    const menu = selectKit(".topic-footer-mobile-dropdown");
     await menu.expand();
 
     assert.ok(menu.rowByValue("assign").exists());
+    await menu.selectRowByValue("assign");
+    assert.ok(exists(".assign.modal-body"), "assign modal opens");
+
+    await click(".assign-suggestions .avatar");
+  });
+});
+
+acceptance("Assign desktop", function (needs) {
+  needs.user();
+  needs.settings({ assign_enabled: true });
+  needs.hooks.beforeEach(() => clearTopicFooterButtons());
+
+  needs.pretender((server, helper) => {
+    server.get("/assign/suggestions", () => {
+      return helper.response({
+        success: true,
+        assign_allowed_groups: false,
+        suggestions: [
+          {
+            id: 19,
+            username: "eviltrout",
+            name: "Robin Ward",
+            avatar_template:
+              "/user_avatar/meta.discourse.org/eviltrout/{size}/5275_2.png",
+          },
+        ],
+      });
+    });
+
+    server.put("/assign/assign", () => {
+      return helper.response({ success: true });
+    });
+  });
+
+  test("Footer dropdown contains button", async (assert) => {
+    updateCurrentUser({ can_assign: true });
+    await visit("/t/internationalization-localization/280");
+    await click("#topic-footer-button-assign");
+
+    assert.ok(exists(".assign.modal-body"), "assign modal opens");
+
+    await click(".assign-suggestions .avatar");
   });
 });