discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: broken suggestions (#189) 

We need to pass name to assignUser because it is used in 2 places.
One is multiselect and another are suggestions.
This commit is contained in:
Krzysztof Kotlarek 2021-08-27 12:57:17 +10:00 committed by GitHub
parent 1306a69b06
commit 9d7d39705e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
assets/javascripts/discourse-assign/controllers/assign-user.js.es6
View File

@ -39,27 +39,27 @@ export default Controller.extend({
}, },
@action @action
assignUser(assignee) { assignUser(name) {
if (this.isBulkAction) { if (this.isBulkAction) {
this.bulkAction(assignee.name); this.bulkAction(name);
return; return;
} }
if (this.allowedGroupsForAssignment.includes(assignee.name)) { if (this.allowedGroupsForAssignment.includes(name)) {
this.setProperties({ this.setProperties({
"model.username": null, "model.username": null,
"model.group_name": assignee.name, "model.group_name": name,
"model.allowedGroups": this.taskActions.allowedGroups, "model.allowedGroups": this.taskActions.allowedGroups,
}); });
} else { } else {
this.setProperties({ this.setProperties({
"model.username": assignee.name, "model.username": name,
"model.group_name": null, "model.group_name": null,
"model.allowedGroups": this.taskActions.allowedGroups, "model.allowedGroups": this.taskActions.allowedGroups,
}); });
} }
if (assignee.name) { if (name) {
return this.assign(); return this.assign();
} }
}, },
@ -107,6 +107,6 @@ export default Controller.extend({
@action @action
assignUsername(selected) { assignUsername(selected) {
this.assignUser({ name: selected.firstObject }); this.assignUser(selected.firstObject);
}, },
}); });

2
assets/javascripts/discourse/templates/modal/assign-user.hbs
View File

@ -19,7 +19,7 @@
}} }}
<div class="assign-suggestions"> <div class="assign-suggestions">
{{#each assignSuggestions as |user|}} {{#each assignSuggestions as |user|}}
<a href {{action "assignUser" user}}> <a href {{action "assignUser" user.username }}>
{{avatar user imageSize="small"}} {{avatar user imageSize="small"}}
</a> </a>
{{/each}} {{/each}}