discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: properly check key values for shortcuts (#463) 

- Update angle bracket components to use vanilla attributes where possible
- Update how we check for key value after changing to `on "change"` from `onChange`
This commit is contained in:
Isaac Janzen 2023-04-28 13:02:13 -05:00 committed by GitHub
parent 11988a9e68
commit ba47a238ac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
assets/javascripts/discourse-assign/controllers/assign-user.js
View File

@ -72,7 +72,7 @@ export default Controller.extend(ModalFunctionality, {
}, },
@action @action
handleTextAreaKeydown(value, event) { handleTextAreaKeydown(event) {
if ((event.ctrlKey || event.metaKey) && event.key === "Enter") { if ((event.ctrlKey || event.metaKey) && event.key === "Enter") {
this.assign(); this.assign();
} }

16
assets/javascripts/discourse/templates/modal/assign-user.hbs
View File

@ -1,4 +1,4 @@
<DModalBody @class="assign"> <DModalBody class="assign">
<div> <div>
<div class="control-group {{if this.assigneeError 'assignee-error'}}"> <div class="control-group {{if this.assigneeError 'assignee-error'}}">
<label>{{i18n "discourse_assign.assign_modal.assignee_label"}}</label> <label>{{i18n "discourse_assign.assign_modal.assignee_label"}}</label>
@ -61,16 +61,16 @@
</DModalBody> </DModalBody>
<div class="modal-footer"> <div class="modal-footer">
{{d-button <DButton
label=(if @label={{if
model.reassign model.reassign
"discourse_assign.reassign.title" "discourse_assign.reassign.title"
"discourse_assign.assign_modal.assign" "discourse_assign.assign_modal.assign"
) }}
icon=inviteIcon @icon={{inviteIcon}}
action=(action "assign") @action={{this.assign}}
class="btn-primary" class="btn-primary"
disabled=disabled @disabled={{disabled}}
}} />
<DModalCancel @close={{route-action "closeModal"}} /> <DModalCancel @close={{route-action "closeModal"}} />
</div> </div>