FIX: skip notifications when topic is not found (#634)
Fixes a bug where the topic may already be deleted before the notification job runs, causing the job to fail.
This commit is contained in:
parent
77dc3abc12
commit
db60986342
|
@ -68,6 +68,7 @@ module DiscourseAssign
|
||||||
end
|
end
|
||||||
|
|
||||||
def call
|
def call
|
||||||
|
return if topic.nil?
|
||||||
Assigner.publish_topic_tracking_state(topic, user.id)
|
Assigner.publish_topic_tracking_state(topic, user.id)
|
||||||
unless mark_as_read?
|
unless mark_as_read?
|
||||||
PostAlerter.new(post).create_notification_alert(
|
PostAlerter.new(post).create_notification_alert(
|
||||||
|
|
|
@ -24,6 +24,20 @@ RSpec.describe DiscourseAssign::CreateNotification do
|
||||||
create_notification
|
create_notification
|
||||||
end
|
end
|
||||||
|
|
||||||
|
context "when topic is not found" do
|
||||||
|
before { assignment.topic = nil }
|
||||||
|
|
||||||
|
it "does not publish topic tracking state" do
|
||||||
|
Assigner.expects(:publish_topic_tracking_state).never
|
||||||
|
create_notification
|
||||||
|
end
|
||||||
|
|
||||||
|
it "does not create a notification alert" do
|
||||||
|
alerter.expects(:create_notification_alert).never
|
||||||
|
create_notification
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
context "when `mark_as_read` is false" do
|
context "when `mark_as_read` is false" do
|
||||||
let(:excerpt) do
|
let(:excerpt) do
|
||||||
I18n.t(
|
I18n.t(
|
||||||
|
|
Loading…
Reference in New Issue