discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Skip enqueuing reminders if no groups are allowed. (#39) 

* FIX: Skip enqueuing reminders if no groups are allowed.

With an empty SiteSetting.assign_allowed_on_groups, it used to generate
an invalid query containing "group_users.group_id IN ()".
This commit is contained in:
Dan Ungureanu 2019-07-10 10:58:35 +03:00 committed by Régis Hanol
parent 22129d191f
commit dea72e708b
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jobs/scheduled/enqueue_reminders.rb
View File

@ -12,7 +12,7 @@ module Jobs
private private
def skip_enqueue? def skip_enqueue?
SiteSetting.remind_assigns_frequency.nil? || !SiteSetting.assign_enabled? SiteSetting.remind_assigns_frequency.nil? || !SiteSetting.assign_enabled? || SiteSetting.assign_allowed_on_groups.blank?
end end
def allowed_group_ids def allowed_group_ids

8
spec/jobs/scheduled/enqueue_reminders_spec.rb
View File

@ -16,6 +16,14 @@ RSpec.describe Jobs::EnqueueReminders do
assert_reminders_enqueued(0) assert_reminders_enqueued(0)
end end
it 'does not enqueue reminders when no groups are allowed to assign' do
SiteSetting.assign_allowed_on_groups = ''
assign_multiple_tasks_to(user)
assert_reminders_enqueued(0)
end
it 'enqueues a reminder when the user has more than one task' do it 'enqueues a reminder when the user has more than one task' do
assign_multiple_tasks_to(user) assign_multiple_tasks_to(user)