discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Try to make system tests more stable (#492) 

Why this change?

We have been seeing tests failures due to errors like

```
Capybara::ElementNotFound:
  Unable to find css "#topic-footer-button-assign"
```

when running our system tests in CI. However, I can't quite figure out
why that is happening and have invested way too much time to do so.
Therefore, I'm trying to fix this by closing a topic via the topic
timeline controls instead of the footer button instead.
This commit is contained in:
Alan Guo Xiang Tan 2023-07-12 08:31:24 +08:00 committed by GitHub
parent 1c079b792b
commit eb3b97b834
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/system/assign_topic_spec.rb
View File

@ -63,7 +63,7 @@ describe "Assign | Assigning topics", type: :system, js: true do
expect(assign_modal).to be_closed expect(assign_modal).to be_closed
expect(topic_page).to have_assigned(user: staff_user, at_post: 2) expect(topic_page).to have_assigned(user: staff_user, at_post: 2)
find("#topic-footer-buttons .toggle-admin-menu").click find(".timeline-controls .toggle-admin-menu").click
find(".topic-admin-close").click find(".topic-admin-close").click
expect(find("#post_3")).to have_content( expect(find("#post_3")).to have_content(
@ -83,7 +83,7 @@ describe "Assign | Assigning topics", type: :system, js: true do
expect(assign_modal).to be_closed expect(assign_modal).to be_closed
expect(topic_page).to have_assigned(user: staff_user, at_post: 2) expect(topic_page).to have_assigned(user: staff_user, at_post: 2)
find("#topic-footer-buttons .toggle-admin-menu").click find(".timeline-controls .toggle-admin-menu").click
find(".topic-admin-close").click find(".topic-admin-close").click
expect(find("#post_3")).to have_content( expect(find("#post_3")).to have_content(
@ -113,7 +113,7 @@ describe "Assign | Assigning topics", type: :system, js: true do
expect(assign_modal).to be_closed expect(assign_modal).to be_closed
expect(topic_page).to have_assigned(user: staff_user, at_post: 2) expect(topic_page).to have_assigned(user: staff_user, at_post: 2)
find("#topic-footer-buttons .toggle-admin-menu").click find(".timeline-controls .toggle-admin-menu").click
find(".topic-admin-close").click find(".topic-admin-close").click
expect(find("#post_3")).to have_content( expect(find("#post_3")).to have_content(
@ -122,7 +122,7 @@ describe "Assign | Assigning topics", type: :system, js: true do
expect(page).to have_no_css("#post_4") expect(page).to have_no_css("#post_4")
expect(page).to have_no_css("#topic .assigned-to") expect(page).to have_no_css("#topic .assigned-to")
find("#topic-footer-buttons .toggle-admin-menu").click find(".timeline-controls .toggle-admin-menu").click
find(".topic-admin-open").click find(".topic-admin-open").click
expect(find("#post_4")).to have_content( expect(find("#post_4")).to have_content(