From f89420d00e4ae5eae6b6d5310b5b37ab13336a0f Mon Sep 17 00:00:00 2001
From: Jarek Radosz <jradosz@gmail.com>
Date: Fri, 30 Jun 2023 19:18:15 +0200
Subject: [PATCH] DEV: Remove unused `assignUser` action (#483)

---
 .../controllers/assign-user.js                | 15 +---------
 .../discourse/templates/modal/assign-user.hbs |  2 +-
 .../controllers/assign-user-test.js           | 29 -------------------
 3 files changed, 2 insertions(+), 44 deletions(-)

diff --git a/assets/javascripts/discourse-assign/controllers/assign-user.js b/assets/javascripts/discourse-assign/controllers/assign-user.js
index 6b54b5f..a3cc5c9 100644
--- a/assets/javascripts/discourse-assign/controllers/assign-user.js
+++ b/assets/javascripts/discourse-assign/controllers/assign-user.js
@@ -126,20 +126,7 @@ export default class AssignUser extends Controller.extend(ModalFunctionality) {
   }
 
   @action
-  assignUser(name) {
-    this.setGroupOrUser(name);
-
-    if (name) {
-      return this.assign();
-    }
-  }
-
-  @action
-  assignUsername(selected) {
-    this.setGroupOrUser(selected.firstObject);
-  }
-
-  setGroupOrUser(name) {
+  assignUsername([name]) {
     this.set("assigneeError", false);
     this.set("model.allowedGroups", this.taskActions.allowedGroups);
 
diff --git a/assets/javascripts/discourse/templates/modal/assign-user.hbs b/assets/javascripts/discourse/templates/modal/assign-user.hbs
index 2a75dcb..4fba99c 100644
--- a/assets/javascripts/discourse/templates/modal/assign-user.hbs
+++ b/assets/javascripts/discourse/templates/modal/assign-user.hbs
@@ -5,7 +5,7 @@
       <AssigneeChooser
         autocomplete="off"
         @value={{this.assigneeName}}
-        @onChange={{action "assignUsername"}}
+        @onChange={{this.assignUsername}}
         autofocus="autofocus"
         @showUserStatus={{true}}
         @options={{hash
diff --git a/test/javascripts/controllers/assign-user-test.js b/test/javascripts/controllers/assign-user-test.js
index 02306b9..5bd41af 100644
--- a/test/javascripts/controllers/assign-user-test.js
+++ b/test/javascripts/controllers/assign-user-test.js
@@ -7,35 +7,6 @@ import { getOwner } from "discourse-common/lib/get-owner";
 module("Unit | Controller | assign-user", function (hooks) {
   setupRenderingTest(hooks);
 
-  test("assigning a user via suggestions makes API call and closes the modal", async function (assert) {
-    pretender.get("/assign/suggestions", () =>
-      response({
-        suggestions: [],
-        assign_allowed_on_groups: ["nat"],
-        assign_allowed_for_groups: [],
-      })
-    );
-
-    pretender.put("/assign/assign", () => response({}));
-
-    let modalClosed = false;
-    const controller = getOwner(this).lookup("controller:assign-user");
-    controller.setProperties({
-      model: {
-        target: EmberObject.create({}),
-      },
-      allowedGroupsForAssignment: ["nat"],
-      taskActions: { allowedGroups: [] },
-    });
-    controller.set("actions.closeModal", () => {
-      modalClosed = true;
-    });
-
-    await controller.assignUser("nat");
-
-    assert.true(modalClosed);
-  });
-
   test("assigning a user by selector does not close the modal", async function (assert) {
     pretender.get("/assign/suggestions", () =>
       response({