From fe80298ae5af4104528ad142ef80cbb31a5976c3 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Wed, 12 Jun 2019 10:20:34 +0200 Subject: [PATCH] FIX: prevents messageBus subscriptions to leak --- .../initializers/extend-for-assigns.js.es6 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6 b/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6 index adf540e..bb70abb 100644 --- a/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6 +++ b/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6 @@ -200,9 +200,12 @@ function initialize(api) { this.appEvents.trigger("header:update-topic", topic); }); }, + unsubscribe() { - this._super(); - if (!this.get("content.id")) return; + this._super(...arguments); + + if (!this.get("model.id")) return; + this.messageBus.unsubscribe("/staff/topic-assignment"); } });