Commit Graph

335 Commits

Author SHA1 Message Date
Keegan George 32f6747264
FIX: Missing actions icon (#453) 2023-03-13 10:45:06 -07:00
Kris 22000f2a5e
UX: fix status alignment after core change (#451) 2023-03-10 16:49:10 -05:00
David Taylor d2cc2c4345
DEV: Make basic-assigned-topic-list a real component (#444)
Re-exporting the BasicTopicList component as-is leads to unexpected behavior when colocating templates because `BasicAssignedTopicList` === `BasicTopicList`. Extending it gives the component its own identity.

Similar to 8ba7b0727a
2023-02-14 13:39:15 +00:00
David Taylor 8ba7b0727a
DEV: Make assigned-topic-list a real component (#442)
Re-exporting the TopicList component as-is leads to unexpected behavior when colocating templates because `AssignedTopicList` === `TopicList`. Extending it gives the component its own identity.
2023-02-13 17:54:30 +00:00
Kris c6e6a883f6
UX: remove whitespace in assign tag (#440) 2023-02-08 09:29:50 -05:00
Kris e724a7ee69
UX: class for small posts when assigns are private (#400)
The goal is to add a class so when assigns are not public, their descriptions can be styled similar to whispers... this is a light way to reassure admins of assign message visibility.
2023-02-02 15:11:53 +08:00
Bianca Nenciu f34bc92b40
FIX: Do not expand if assignee username present (#434)
This does not work as expected and can lead to a worse user experience.
2023-01-25 10:08:34 +02:00
chapoi 0c0fcbc5af
UX: fix list being limited by modal size (#435) 2023-01-24 13:19:01 +01:00
chapoi 4934df94e2
UX: add ellipsis for assign modal (#433)
* UX: add ellipsis for assign modal

* UX: remove suggestions label
2023-01-23 18:48:17 +01:00
chapoi 0d695df595
UX: fixing alignment issue (#432)
* UX: fixing alignment issue
2023-01-23 18:47:00 +01:00
Bianca Nenciu 02b9d9423e
UX: Add suggestions label to assign modal (#429) 2023-01-18 17:43:23 +02:00
Jan Cernik 896d0e3445
FIX: Broken posts when assigning a closed topic (#425)
The previous behavior was:
1. Assign a topic to someone
2. Close the topic with the setting unassign_on_close enabled
3. Assign the topic to the same user as before

This caused small broken or empty posts to be displayed.

This commit also introduces system specs
2023-01-17 08:09:35 -03:00
Bianca Nenciu 6672ad1ff4
FEATURE: Automatically open assignee chooser (#427) 2023-01-13 17:22:13 +02:00
chapoi 509ee637cf
UX: fix text alignment assign modal dropdown (#422) 2023-01-06 14:09:27 +01:00
Ted Johansson 31389d713a
FIX: Build correct assign tag links when using subfolders (#420)
The tag links added to the topic header extras aren't aware of
subfolder usage. This change fixes that.
2023-01-05 16:04:14 +08:00
David Taylor 4070985316
DEV: Update eslint-config-discourse, use prettier for hbs (#414) 2023-01-04 13:34:49 +01:00
Bianca Nenciu 993f7faa8d
FIX: Reset assignee error when modal is shown (#407) 2022-12-21 17:24:17 +02:00
Bianca Nenciu a4ce90e855
UX: Improve assign modal design (#403)
Implements a new design that improves the user experience:

- add a clear cancel button
- add an indication the note is optional
- change the plus icon to a search icon
- show an error when the user tries to assign without choosing an assignee
- move suggestions to default search results
- focus search input when modal is displayed
2022-12-21 14:49:24 +02:00
Alan Guo Xiang Tan feca27b6bd
FEATURE: Make plugin compatible with redesigned user messages (#399) 2022-12-07 06:22:14 +08:00
Bianca Nenciu af146fea54
FIX: Show group icon for group notifications (#384)
The same "user-plus" icon was used for both user and group assigned
notifications.
2022-10-03 21:13:34 +03:00
Andrei Prigorshnev c5ad176aaf
FEATURE: show user status when assigning user (#382) 2022-09-28 17:31:31 +04:00
Osama Sayegh cef3d23766
DEV: Make the assign tab in the user menu link to the assign page (#380)
As of 12ebdf0ff0, it's possible to make tabs in the experimental user menu link to a page when they're clicked on when they're active. This commit makes the assign tab links to `/my/activity/assigned` when it's active.
2022-09-19 17:11:37 +03:00
Krzysztof Kotlarek 0d9aa9c5fa
FIX: Move types of the assign notification list to the tab class (#376)
This change is needed following this commit in core: 661a903a0b

Co-authored-by: OsamaSayegh <asooomaasoooma90@gmail.com>
2022-09-02 18:48:45 +03:00
Krzysztof Kotlarek 0d586bb93c
FIX: use grouped_unread_notifications (#373)
Use `grouped_unread_notifications` instead of `grouped_unread_high_priority_notifications`

Related PR: https://github.com/discourse/discourse/pull/18132
2022-08-31 11:16:13 +10:00
Osama Sayegh 7b08ab425c
DEV: Apply model transformations for the assigns list in the experimental user menu (#372) 2022-08-26 13:33:25 +08:00
Osama Sayegh e6e222d8bc
FEATURE: Add assigns tab to the experimental user menu (#366)
This commit adds a tab for assignments in the experimental user menu. The assignments tab behaves very similarly to the bookmarks and messages tab in core: it displays the user's unread assign notifications first and then fills the rest of available space in the menu with assignments (same content that the current user menu displays).

More details of the experimental user menu can be found in https://github.com/discourse/discourse/pull/17379.
2022-08-17 11:57:15 +03:00
Rafael dos Santos Silva 7a2fde72c6
FEATURE: Assign Status (#363)
Adds a new plugin setting that when enabled adds a status field for every assignment. This setting defaults to off.

The possible status for an assignment are customizable via yet another new setting, and the first one on this list will be the default status for new assignments.

The status is not yet show anywhere except the assign modal and the small action posts in topics at the moment. Adding status to the assignment list for users and groups will be handled in the near future.


Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2022-08-04 14:50:18 -03:00
Martin Brennan a29a02abe7
FEATURE: Allow submitting the assign modal with ctrl+enter (#362)
This commit allows submitting the assign modal with
control/meta+enter when the textarea is focused.
2022-07-28 16:18:44 +10:00
Alan Guo Xiang Tan 148b4b0089
Revert "FEATURE: Register assigned link under sidebar topics section. (#341)" (#359)
This reverts commit 959525b079.

Product design to drop from Sidebar
2022-07-22 15:40:05 +08:00
Jarek Radosz 0adea550c0
DEV: Fix leaky tests (#358) 2022-07-21 03:41:32 +02:00
Alan Guo Xiang Tan 86141dfe3d
Revert "UX: Don't display assign user menu glyph when sidebar is enabled (#356)" (#357)
This reverts commit 479fcfb411.

Link in user menu dropdown is kept in favor of link in experimental
sidebar
2022-07-08 15:44:45 +08:00
Alan Guo Xiang Tan 479fcfb411
UX: Don't display assign user menu glyph when sidebar is enabled (#356)
Assignments can already be accessed via sidebar.
2022-07-05 15:50:46 +08:00
Natalie Tay 4c7384e88f
FIX: Fix a bug where a note change was ending in a full blown whisper (#352) 2022-06-18 01:45:47 +08:00
Natalie Tay 1ef8e70314
FIX: Don't reuse assign note when reassigning (#351) 2022-06-18 01:35:58 +08:00
Natalie Tay 169f13e239
FEATURE: Allows note to be edited (#350) 2022-06-18 00:06:23 +08:00
Isaac Janzen 201f115387
DEV: Remove 'htmlSafe' string prototype extensions (#344)
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
2022-06-01 11:08:26 -05:00
Alan Guo Xiang Tan 959525b079
FEATURE: Register assigned link under sidebar topics section. (#341) 2022-05-26 09:13:40 +08:00
Natalie Tay 6db2e0991b
FIX: Only assign when suggestion is clicked (#334) 2022-05-12 20:55:37 +08:00
Natalie Tay 5503499514
FIX: Assigning a user without notes assigns and closes the modal (#329) 2022-05-11 16:17:33 +08:00
Natalie Tay b314882a6b
FEATURE: Show note in tooltip (#327) 2022-05-05 15:04:57 +08:00
Natalie Tay 1ac2dfbae2
FEATURE: Add assign note (#326) 2022-05-05 13:21:14 +08:00
Kris d2241049e1
UX: show posers on group assign list (#325) 2022-04-29 13:43:40 -04:00
Penar Musaraj b1b7023141
FIX: User link on post assign/unassign (#322) 2022-04-27 13:19:34 -04:00
Natalie Tay 21d89179ea
FIX: Hide footer action button when user cannot assign (#319) 2022-04-26 15:00:00 +08:00
Kris 7a854fe504
UX: Show posters on assigned topic list (#315) 2022-04-14 16:20:09 -04:00
Jordan Vidrine d8d2dc950a
UX: Additional refactor for topic-list prep (#310) 2022-03-23 10:42:55 -05:00
Rafael dos Santos Silva 099845ffbd
FIX: Add missing notification title (#306) 2022-03-18 16:42:57 -03:00
Jordan Vidrine 8c382b02c1
UX: Topic list refactor (#299) 2022-03-09 16:46:10 -06:00
Jarek Radosz 264620985e
DEV: Lose the es6 suffix (#298) 2022-03-05 17:19:50 +01:00
Penar Musaraj 87026078b4
A11Y: Use `autocomplete=off` for search inputs (#290) 2022-02-03 13:50:42 +01:00
Krzysztof Kotlarek 594dad6b83
FEATURE: holiday icon for suggestions (#278)
When user is on holiday, mark avatar with calendar icon.
In this case, urgent topics can be assigned to an available team member.
2022-01-17 09:10:08 +11:00
Arpit Jalan 5a426e6836
FIX: bulk assign modal was broken (#276)
When trying to bulk assign topics to a user via bulk topics action modal
the modal was broken because the key "model.description" was missing.

This commit adds key "model.description" and adds a new locale for it to
indicate that this action will be performed on multiple topics.
2022-01-04 14:32:37 +05:30
Krzysztof Kotlarek 1a1dffc5e8
FEATURE: active flag for assignments (#264)
When topic is closed, we mark assignments as "inactive". Then when it is reopen and setting reassign_on_open is enabled, we bring back previous assignments.

We were already using custom fields for archive message and move to inbox. I changed custom fields solution to use active flag on Assignment model
2021-12-13 08:36:14 +01:00
Andrei Prigorshnev 3a76a465a0
DEV: use the empty-state component (#261) 2021-12-09 00:23:10 +04:00
Joffrey JAFFEUX 2930cda049
FIX: correctly position dropdown in modal on desktop (#260) 2021-12-03 12:22:29 +01:00
janzenisaac 5910fd5569
FIX: Refactor assign / reassign to combine logic (#250)
* Refactor and combine assign / reassign logic
2021-12-02 13:12:00 -06:00
Krzysztof Kotlarek 91d0712b04
FIX: improvements for assign to post (#258)
1. When post is assigned to current user, unassign icon is not hidden
2. Link under names lead to topic (when topic assignment) and to post (when post assignment)
2021-12-01 08:54:13 +11:00
Jordan Vidrine a9a427150e
FIX: Adjust mobile list for recent topic list changes (#257) 2021-11-23 17:47:31 -06:00
janzenisaac 09d254b369
FIX: Update aria-labels on mobile / dropdown (#254)
- Update aria labels on mobile and for re-assign dropdown
- Fixes: https://dev.discourse.org/t/quicker-assign-to-self-when-group-is-assigned/54647/33?u=isaacjanzen
2021-11-19 11:55:14 -06:00
Jarek Radosz f56037cdf0
FIX: Selecting a user was clearing search terms (#252)
Regressed in #211?
2021-11-18 18:52:38 +01:00
Natalie Tay 3d2a9d1e87
Show custom topic tracking message when the user 'never' automatically tracks topics and gets assigned (#249)
* Show more precise topic tracking message when the user never tracks any topics and gets assigned
2021-11-18 09:44:53 +08:00
Jarek Radosz f88c419a8c
FIX: Broken assigned topics search (#251)
regressed in #239
2021-11-18 01:58:01 +01:00
Krzysztof Kotlarek 89a61b58f8
FIX: use customOptions property (#240)
Change after https://github.com/discourse/discourse/pull/14933
2021-11-17 17:12:37 +11:00
Jordan Vidrine ebe693ae96
REFACTOR: Topic list changes (#248)
* REFACTOR: Topic list changes
2021-11-16 14:50:31 -06:00
janzenisaac 6354215341
UX: Have mobile icons match desktop (#243) 2021-11-15 11:53:56 -06:00
janzenisaac 54bd6bd2c3
UX: Update reassign dropdown styles (#242)
- Make drop down options regular font weight
- Add icon to drop down options
2021-11-15 10:47:29 -06:00
janzenisaac 28fbcac11e
FIX: Update Re-assign view permissions (#241)
Only show mobile re-assign options if user has permission to assign

Fixes: https://meta.discourse.org/t/discourse-assign/58044/155?u=isaacjanzen
2021-11-15 09:58:48 -06:00
Jarek Radosz ab0c63b1fb
DEV: Fix a computed property override (#239) 2021-11-15 00:41:30 +01:00
Jarek Radosz 5fc1dee14d
DEV: `mobile-nav` no longer uses `currentPath` arg (#238) 2021-11-15 00:40:19 +01:00
janzenisaac ec9405df5c
FIX: Return proper aria-labels (#237)
- Add proper aria label to dropdown
- Make sure footer button aria-labels are returned

fixes : https://dev.discourse.org/t/quicker-assign-to-self-when-group-is-assigned/54647/24?u=isaacjanzen
2021-11-13 14:58:35 -06:00
janzenisaac 98103586b2
FEATURE: Reassign workflow (#231)
Build a new workflow that adds a dropdown in place of the old assign button with the ability to

Re-assign a new user / group to an assigned topic
Re-assign yourself to an assigned topic
Unassign a user / group from an assigned topic
2021-11-12 10:09:47 -06:00
Martin Brennan 0e4649d507
DEV: Update code for eslint object-shorthand-rule (#236)
See 4f7aba06c0
2021-11-10 12:04:26 +11:00
Krzysztof Kotlarek 69dac06a82
FIX: correctly update UI when post is assigned/unassigned (#233)
Update topic title, first post and related post
2021-11-09 08:40:43 +11:00
Krzysztof Kotlarek a4b1847eff
FEATURE: display indirect assignments in the first post (#227)
A link in the first post will allow going to a specific post assigned to a user or group.
2021-11-03 10:35:10 +11:00
Krzysztof Kotlarek c396605d2f
FEATURE: assign to post (#224)
Ability to assign an individual post to a user or group
2021-11-01 09:27:13 +11:00
Krzysztof Kotlarek dc8f43fbb1
FEATURE: Assignment target is polymorphic (#218)
Change `topic_id` to polymorphic approach (In the next step we will allow assigning to individual post)

`topic_id` column is still used for efficient display of assigned users on topic list (to avoid scanning posts)
2021-10-14 09:22:29 +11:00
Jarek Radosz 58315230f0
UX: Remove an obsolete css class from an element (#220)
1. It's not needed in the new advanced search interface
2. It causes problems in some cases
2021-10-12 17:22:02 +11:00
Penar Musaraj dd2eae8f9c
DEV: Update bulk select in group topics list (#214) 2021-09-23 10:50:36 -04:00
Penar Musaraj 74b9f3d22c
UX: Fix input styling in group assignments page (#213) 2021-09-21 14:25:01 -04:00
Bianca Nenciu 85fa1f90aa
FIX: Refresh first post after assign and unassign (#212)
The first post showed the assign status when it was loaded and did not
update if it changed. The page had to be refreshed for the text to be
updated.
2021-09-17 10:37:36 +10:00
Robin Ward 7082e32122
FIX: Tests were broken on Ember CLI (#211)
The first issue is using `updateCurrentUser` when code was conditional
in an initializer. Instead we need to use `needs.user()`.

The second issue was trickier to track down but we were using an
observer in a syncrhnous way which is not allowed in newer Embers. This
removes the observer (and some dead code around it!) so that we can
execute that code synchronously.
2021-09-16 08:46:44 -04:00
Penar Musaraj 83635ced6f
DEV: Remove displayNewPosts (deprecated in core) (#208) 2021-09-15 08:29:48 -04:00
Martin Brennan 5f7adcc786
FIX: Allow Never selection for frequency of assigned topic reminders (#204)
If the user selected Never for their frequency of assigned topic
reminder PMs, the option automatically set back to the default
value (Monthly) because of the user of the `or` computed helper,
which considered the 0 value of Never to be falsey.

This is the same problem that occurred in core which was fixed by
d3779d4cf7

We need to be careful around using the `or` helper if any of the
options could be considered falsey.
2021-09-15 08:31:59 +10:00
Penar Musaraj 463b1c2cf0
DEV: Add `pluginId` in one last `modifyClass` call (#207) 2021-09-14 15:50:15 -04:00
Penar Musaraj 86a2b1d574
UX: Fix input alignment following core changes (#200) 2021-09-14 09:41:08 -04:00
Krzysztof Kotlarek 62d87f0084
FEATURE: better UI for group assignments (#197)
On the group assignment page, we should be able to display
- all topics assigned to that group + to user belonging to that group
- all topics assigned directly to group
- all topics assigned to individual user
2021-09-09 12:18:18 +10:00
Krzysztof Kotlarek 5954c625ef
FEATURE: advance search groups (#198)
Allow advance search filter to select topics assigned to specific group
2021-09-08 11:39:15 +10:00
Krzysztof Kotlarek 375f7ba78d
FEATURE: new assignable group option instead of messageable (#195)
V1 of group assign was using "who can message" to determine if group can be assigned.

This PR is introducing new separate setting "who can assign"
2021-09-08 10:30:13 +10:00
Robin Ward f541158b64
DEV: Add `pluginId` for more stable tests (#196) 2021-09-02 15:46:32 -04:00
Krzysztof Kotlarek b42ec9f779
FIX: correct group icons and notification message (#193)
* New group icon
* Group assignment notification displays group name instead of who assigned
2021-08-31 08:17:43 +10:00
Krzysztof Kotlarek 9d7d39705e
FIX: broken suggestions (#189)
We need to pass name to assignUser because it is used in 2 places.
One is multiselect and another are suggestions.
2021-08-27 12:57:17 +10:00
Krzysztof Kotlarek 1306a69b06
FIX: whisper small actions are blank (#188)
assigned_group and unassigned_group has to be added to decorator to properly display whispers
2021-08-27 11:34:44 +10:00
Jarek Radosz d807491df2
FEATURE: Assign to group (#182)
Ability to assign groups.

To assign group, user must have a right to send a message to that group.

In addition, 2 jobs were introduced, - AssignNotification and UnassignNotification to inform interested users in the background about the new assignment.
2021-08-27 09:25:38 +10:00
Andrei Prigorshnev 29d4b8fd5c
FEATURE: improve blank page syndrome (#187) 2021-08-25 19:51:45 +04:00
Joffrey JAFFEUX a8495e9d7a
FIX: makes dropdown use absolute positioning (#185) 2021-08-16 12:19:48 +02:00
Joffrey JAFFEUX 92a1167a68
FIX: explicit assign on user selection (#184)
Also drops autofocus as it's the first item in the form
2021-08-16 10:56:01 +02:00
Jarek Radosz ad95725987
FIX: Hide Unassigned if user doesn't have access (#179)
There's no need to display the "Unassigned" button for regular users when `assigns_public` is `false`.
2021-07-30 20:58:39 +02:00
Jarek Radosz 9ecc1581fd
DEV: Remove old review queue code (#178)
I think it should have been deleted with https://github.com/discourse/discourse-assign/pull/47? That's where e.g. `assign_locks_flags` site setting was removed.
2021-07-30 14:43:28 +02:00
Penar Musaraj c572e21493
UX: Add quick search suggestion entries (#175) 2021-07-21 14:00:43 -04:00
Jarek Radosz dfb30fc104
FIX: TagsHtmlCallback params can be undefined (#174) 2021-07-20 13:53:17 +02:00