Commit Graph

48 Commits

Author SHA1 Message Date
Bianca Nenciu 927fdca0a0 DEV: Test if assign_allowed_on_groups contains only visible groups
Follow-up to 7d4b515524.
2019-09-11 14:10:58 +03:00
Roman Rizzi d268d4f817
Fix: Enforce new rules when assigning a topic. (#46)
* assign_to user must be allowed to assign.
* assign_to user must have access to the topic
2019-09-05 10:31:52 -03:00
romanrizzi 8792cf51bd DEV: Assign allowed groups are sent alongside suggestions. After the migration happens, we'll need to still have access to the allowed group names so we can search users. 2019-07-19 14:49:45 -03:00
Roman Rizzi 64324ce9db
DEV: use group ids to allow assign on groups [Undo Revert] (#41)
* DEV: use group ids to allow assign on groups (#38) [Undo Revert]

This reverts commit 8f92c5f9bd.

* Set the  default inside a migration based on the core migration. Improve migration check to work against tests-passed/beta/stable.

* Update db/migrate/20190718144722_set_assign_allowed_on_groups_default.rb

Co-Authored-By: Robin Ward <robin.ward@gmail.com>
2019-07-19 10:30:44 -03:00
Roman Rizzi 8f92c5f9bd
Revert "DEV: use group ids to allow assign on groups (#38)" (#40)
This reverts commit b256d462bf.
2019-07-16 11:59:33 -03:00
Roman Rizzi b256d462bf
DEV: use group ids to allow assign on groups (#38)
* DEV: use group ids to allow assign on groups

* FIX: Dinamically sets the default value to support older versions
2019-07-16 11:33:04 -03:00
Dan Ungureanu dea72e708b FIX: Skip enqueuing reminders if no groups are allowed. (#39)
* FIX: Skip enqueuing reminders if no groups are allowed.

With an empty SiteSetting.assign_allowed_on_groups, it used to generate
an invalid query containing "group_users.group_id IN ()".
2019-07-10 09:58:35 +02:00
Sam Saffron e4be0f02b7 Revert "Staff is always allowed to assign (#36)"
This reverts commit bb200f5fbd.
Unfortunately that commit broke assign
2019-06-18 16:00:10 +10:00
Roman Rizzi bb200f5fbd
Staff is always allowed to assign (#36) 2019-06-17 10:11:00 -03:00
Roman Rizzi f312ece4a9
Feature: Allow assign on groups (#31)
* Feature: Allow assign on groups

* Use type: group_list option

* Track group changes and update the setting accordingly. Restrict reminders frequency to assign allowed users instead of staff
2019-06-04 09:21:33 -03:00
Roman Rizzi abe8142038
FEATURE: Users can override reminders frequency (#30)
* FEATURE: Users can override reminders frequency

* Changes:
- Avoid creating a user custom field when the used didn't override the frequency
- Sanitize frequency value using coercion
- Minor fixes

* Sanitize query and user query single
2019-05-27 10:53:37 -03:00
romanrizzi c882b097f8 Remove 'Unassign All' feature 2019-05-15 15:57:28 -03:00
Roman Rizzi 4b7a99f017
Disable flagging behaviour in favor of the new reviewable API (#34) 2019-05-14 16:29:50 -03:00
Guo Xiang Tan 8fca0f61e8 Add frozen string literal comment to files. 2019-05-13 10:30:21 +08:00
Roman Rizzi f330120f90
Assigned topics are now ordered by topics.bumped_at (#32) 2019-05-07 12:43:47 -03:00
Roman Rizzi e3b2e5bdb6 FEATURE: Display PMs in assigned activity and differentiate them. (#27)
* FEATURE: Display PMs in assigned activity and differentiate them.

* FEATURE: Unassign/Re-assign tasks from the activity view

* Remove bulkAssign. Reuse assign/unassign with a service. Change PM icon position

* Reuse ListItemDefaults instead of duplicating code.

* Conditionally show/hide feature if list items defaults is present in core
2019-05-07 16:30:47 +10:00
Sam Saffron f5a19501cc DEV: correct spec to meet new design
We now allow self assigns unlimited, but limit
other people once you reach limit
2019-05-03 13:48:43 +10:00
Roman Rizzi 8583287faf
FEATURE: Limit the amount of assigned topics an user can have. (#29)
* FEATURE: Limit the amount of assigned topics an user can have.

* Do not enfore the limit when self-assigning

* Avoid computing the query when self-assigning. Do not count self-assigns when enforcing the limit
2019-05-02 10:44:11 -03:00
Guo Xiang Tan 8b06b7cb4c FIX: Only send reminders to moderators and admins. 2019-04-30 12:00:59 +08:00
Guo Xiang Tan 65c0b3c192 FIX: Don't count deleted topic in assignment count. 2019-04-30 11:23:13 +08:00
Guo Xiang Tan 00a9cb1752 Fix invalid arguments passed to `find_by`. 2019-04-30 09:56:06 +08:00
Roman Rizzi 7b7432990a FEATURE: Remind users of assigned tasks. (#28)
* FEATURE: Remind users of assigned tasks.

* User an user custom field instead of adding a new column

* Improve tests. fix assigns count and display oldest assigned topics correctly. Do not remind about recently assigned tasks
2019-04-30 10:02:26 +10:00
Bianca Nenciu 801b1cd48c FIX: Check if topic is assigned before assigning again. (#25) 2019-03-15 18:49:22 +01:00
Gerhard Schlager 5527457ce2 FIX: Do not unassign on topic open 2019-01-10 20:58:20 +01:00
Gerhard Schlager a308e2a445 FIX: Do not assign the same user more than once
This prevents resending assignment notification emails.
2019-01-04 21:24:08 +01:00
Saurabh Patel b20b4c088d FIX: add translations and check for message and if assignment is successful in spec (#22) 2018-12-06 18:04:31 +11:00
Saurabh Patel a2e7fc4cac FIX: do not assign to same when already assigned 2018-12-06 16:46:08 +11:00
Sam cd6f61683e FIX: do not include username in assign push notification 2018-12-05 08:42:02 +11:00
Sam 2d5359055d FIX: properly send push notifications on assign
Previously we would rely on a quirk in core where whisper small actions
would get a notification, this behavior was removed and now we must
be explicit, it provides a much more consistent assign notification
2018-12-04 17:55:58 +11:00
Maja Komel baddb3c630 FIX: don't assign system user when automatic assign by mention is enabled (#20) 2018-12-03 12:37:36 +01:00
Bianca Nenciu 0299deaf25 FIX: Unassign on autoclose. 2018-11-21 15:49:07 +02:00
Guo Xiang Tan 88d5346aad DEV: Minor fixes to spec. 2018-10-05 12:55:55 +08:00
Vinoth Kannan 004cf718b9 SPEC: Do not raise error if topic not exist 2018-10-05 09:37:28 +05:30
Guo Xiang Tan ed1f942c52 FIX: Don't set notification level to `watching` when already watching. 2018-09-07 15:00:53 +08:00
Guo Xiang Tan 7663268584 FIX: Change notification_level back to tracking only if set by plugin. 2018-09-04 15:30:53 +08:00
Sam 8ad7304bdd FIX: can now correctly unassign corrupt topics
if a topic is somehow assigned to an array we can correctly unassign
2018-09-04 15:10:17 +10:00
Guo Xiang Tan 9bea971196 FEATURE: Assigning a user to a topic will make user watch the topic. 2018-08-03 16:24:59 +08:00
Guo Xiang Tan 2da69df8c9 Fix specs for Rails 5.2. 2018-06-08 09:14:30 +08:00
Guo Xiang Tan 4e53bf1962 FIX: Include `assigned_messages_count` only when viewing assigned list. 2018-05-24 11:49:49 +08:00
Guo Xiang Tan e48ed99dfe Show assigned messages count as long as assigns is enabled. 2018-05-24 10:51:04 +08:00
Guo Xiang Tan 22108df6be FEATURE: Display link with count to user's assigned messages page. 2018-05-23 18:16:36 +08:00
Robin Ward 754209ce58 Add "Unassign All" button to user's assigned topics view 2018-05-04 13:41:04 -04:00
Arpit Jalan c24083df5c Remove 'archive' tab for assigned topics. 2018-03-26 22:49:34 +05:30
Guo Xiang Tan 463f77bb2a FEATURE: Add live updates for "assigned" private messages. 2018-03-07 23:02:13 +08:00
Guo Xiang Tan 93b7d7e195 Fix plugin tests. 2018-03-06 21:42:32 +08:00
Guo Xiang Tan 733503e67f FIX: Display group archive topics for groups that the user is in. 2017-12-01 12:21:25 +08:00
Guo Xiang Tan 81244a6a47 FEATURE: Add `archive` tab for assigned topics. 2017-12-01 11:25:54 +08:00
Sam 70911cbd43 preload email correctly (not backwards compat with stable) 2017-08-29 12:49:31 -04:00