Commit Graph

14 Commits

Author SHA1 Message Date
Martin Brennan 5f7adcc786
FIX: Allow Never selection for frequency of assigned topic reminders (#204)
If the user selected Never for their frequency of assigned topic
reminder PMs, the option automatically set back to the default
value (Monthly) because of the user of the `or` computed helper,
which considered the 0 value of Never to be falsey.

This is the same problem that occurred in core which was fixed by
d3779d4cf7

We need to be careful around using the `or` helper if any of the
options could be considered falsey.
2021-09-15 08:31:59 +10:00
Krzysztof Kotlarek 62d87f0084
FEATURE: better UI for group assignments (#197)
On the group assignment page, we should be able to display
- all topics assigned to that group + to user belonging to that group
- all topics assigned directly to group
- all topics assigned to individual user
2021-09-09 12:18:18 +10:00
Andrei Prigorshnev bdff555968
DEV: add a prefix with the plugin name to spec names (#180) 2021-07-30 22:39:38 +04:00
Jarek Radosz 53d3bda543
DEV: Update tests (#177)
Included:

* DEV: Add "assigned topic" test
* DEV: Update and re-enable disabled test
* DEV: Add missing imports
* DEV: Fix typos
* DEV: Don't use find()
* DEV: Use the hbs helper
2021-07-23 17:02:21 +02:00
Martin Brennan 8b0596fc87
FIX: Assign topic button not working (#164)
Since this commit
195dcc92cb
the updateUsername function was missing an @action decorator. This adds
it back and extends the assign acceptance tests to click the
mobile/desktop assign buttons and open the modal and click the
suggestion to save the assignment.
2021-06-29 10:12:19 +10:00
discoursebot ab568be98b
DEV: Update CI workflows (#128)
* DEV: Update CI workflows
* DEV: Fix linting

Co-authored-by: justindirose <justindirose@users.noreply.github.com>
Co-authored-by: Justin DiRose <justin@justindirose.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2021-01-21 22:39:54 +01:00
Roman Rizzi b824e19e91
REFACTOR: Use the new format for acceptance tests. (#126) 2020-12-30 17:02:45 -03:00
Joffrey JAFFEUX 598c717009
DEV: apply coding standards (#109) 2020-09-04 13:24:23 +02:00
Joffrey JAFFEUX 02c6fa6d24
DEV: uses new topic-button API (#43) 2019-07-19 10:20:55 +02:00
Joffrey JAFFEUX 5bbca9b925 DEV: new API s/replaceCurrentUser/updateCurrentUser 2019-06-14 14:38:10 +02:00
Joffrey JAFFEUX d9178cf60c FIX: new select-kit test-helper 2019-06-06 09:34:42 +02:00
Roman Rizzi f312ece4a9
Feature: Allow assign on groups (#31)
* Feature: Allow assign on groups

* Use type: group_list option

* Track group changes and update the setting accordingly. Restrict reminders frequency to assign allowed users instead of staff
2019-06-04 09:21:33 -03:00
Bianca Nenciu 097bda91a9 DEV: Fix heisentests. (#18) 2018-11-27 11:54:19 +01:00
Sam 646b310064 split into 2 files so its easier to use rake autospec 2018-11-23 11:27:56 +11:00