Commit Graph

233 Commits

Author SHA1 Message Date
Jarek Radosz 195dcc92cb
DEV: Post-release cleanup (#163)
Included:

* DEV: Post-release cleanup
* DEV: Tests cleanup
* DEV: Import cleanup
* DEV: Drop a compatibility fix
* DEV: Use index_by
* DEV: Use ember imports
* DEV: Use discourseDebounce
* DEV: Use @action
* DEV: Use the optional chaining operator
* DEV: Fix an invalid test
* DEV: Use `discourseModule`
* DEV: Add .prettierrc
* DEV: Sync up the version number
2021-06-28 17:37:27 +02:00
Penar Musaraj 6ae6d576c4
DEV: Remove SCSS color vars fallbacks (#159) 2021-05-12 08:55:32 -04:00
Mark VanLandingham c0d651764f
UX: Improve quick access copy when no topics present (#151) 2021-04-23 11:00:22 -05:00
Osama Sayegh a90e7ab7e2
FIX: Add autofocus to users chooser on the assign modal (#148)
The users chooser on the assign modal is the primary input field on the modal, so it makes to shift focus to it when the modal is opened. This PR needs 0f807ba85b in core to work properly, but it won't cause errors (won't have any effects) if it's deployed to a site that doesn't have that commit.
2021-02-23 14:05:34 +03:00
Roman Rizzi 394f857096
FIX: Use Ember's debounce on stable. (#147)
We need to wrap the new debounce function inside a try block to avoid throwing a "module not found" exception.
2021-02-22 12:55:16 -03:00
Osama Sayegh b1b8c94f56
DEV: Migrate from {{user-selector}} to {{email-group-user-chooser}} (#146) 2021-02-15 12:34:55 +03:00
Jarek Radosz b560cf1002 DEV: Fix template linting issues 2021-02-10 12:14:38 +01:00
Kris ea0ac1a7fc
Adjust button padding to account for avatar (#139)
Follow up to f7bb92b
2021-01-28 10:27:54 -05:00
Kris f7bb92bf51
UX: update button padding for core button update (#138) 2021-01-27 16:46:37 -05:00
Joffrey JAFFEUX 1e7c6eceed
DEV: prettier 2.2.1 (#136) 2021-01-27 10:45:35 +01:00
Roman Rizzi 0bf73af1d7
UX: Redirect to the login page if trying to view assigned topics as anon (#133) 2021-01-22 16:16:35 -03:00
Roman Rizzi 1663b3ab18
Use the new discourseDebounce function wrapper. (#124)
We recently merged a Discourse core's PR to replace usages of Ember's debounce and discourseDebounce with a new debounce wrapper. The new wrapper works exactly like Ember's debounce but internally calls "run" when called in test mode.

This PR replaces all usages of other debounce functions with the new wrapper and fallbacks to Ember's debounce for backward-compatibility.
2020-12-22 14:34:03 -03:00
Joe 55ceec2ac3
UX: adds margins to assign tag in composer-popup (#119)
This PR adds some margins to the assign tags in the composer-popup.

Before 

<img src="https://user-images.githubusercontent.com/33972521/100543762-02948f00-328d-11eb-8147-3cc5d53eaf72.png" width=500>

After

<img src="https://user-images.githubusercontent.com/33972521/100543767-09230680-328d-11eb-98e5-278d96623b37.png" width=500>
2020-11-30 01:13:56 +08:00
Robin Ward 53c5933b93
FIX: `onChange` needs an action (#117)
Before this fix it was impossible for a user to change their preference
for reminder frequency.
2020-10-30 11:49:56 -04:00
Joffrey JAFFEUX 977f7592f4
FIX: removes the need for intermediate property and updates code (#114)
Before this commit, changing the value of the reminder frequency on a user notifications page was not working.

This commit also get rid of a few deprecations warning.
2020-09-30 11:10:15 +02:00
jjaffeux 6c14a0288b DEV: linting 2020-09-22 17:07:15 +02:00
jjaffeux 7e023968b8 DEV: removes superfluous arguments 2020-09-22 16:23:23 +02:00
David Taylor c4aefd5917
REFACTOR: Use core `default_results` function (#111)
This significantly reduces the amount of logic we need to carry in the discourse-assign plugin. One side effect is that I had to rename the 'q' parameter to 'search', so that it matches core's implementation.
2020-09-16 12:18:14 +01:00
jjaffeux 445e94de4c DEV: this is now fixed in core 2020-09-16 11:08:16 +02:00
jjaffeux 6a449367f5 FIX: keeps updateInRegex public 2020-09-15 12:23:08 +02:00
jjaffeux 8192b888d5 FIX: missing conditional 2020-09-15 12:18:53 +02:00
jjaffeux 1cc42e5c9a FIX: makes updates of search term work with core update 2020-09-15 12:02:51 +02:00
jjaffeux bf98811165 FIX: ensures autofocus is working 2020-09-11 16:48:00 +02:00
Ahmed Gagan d9826cc608
FIX: Input helper loosing focus and default selecting 'Everyone' tab in 'group-assigned' tab (#112) 2020-09-11 15:06:37 +01:00
Ahmed Gagan 303274eae3
FEATURE: Advanced search filters for assigned topics (#102)
Adds three new search modifiers:

- in:assigned for assigned topics
- in:unassigned for unassigned topics
- assigned:{username} to list topics assigned to a specific user

These modifiers are all made available in the advanced search sidebar
2020-09-11 12:15:50 +01:00
Ahmed Gagan 3e3dc3815b
FEATURE: Assign bulk actions for topics lists (#110)
- Allows unassigning and reassigning topics using bulk actions
- Adds bulk actions UI to the group assigned page
2020-09-11 11:49:25 +01:00
David Taylor e78537ac46
DEV: Apply prettier 2020-09-09 18:41:42 +01:00
Ahmed Gagan 43c68f6ffd
FEATURE: Allow filtering topics in the user assigned list (#108) 2020-09-09 18:28:14 +01:00
Joffrey JAFFEUX 598c717009
DEV: apply coding standards (#109) 2020-09-04 13:24:23 +02:00
Ahmed Gagan cd31a821fc
UX: Only show assigned tab for groups where all users can assign (#103) 2020-08-28 15:18:25 +01:00
Ahmed Gagan 2fad129af5
UX: Ensure equal margin around topic search box (#106) 2020-08-21 14:39:18 +01:00
Ahmed Gagan b88723a3b1
FIX: Correct sorting issues 2020-08-20 12:07:24 +01:00
Ahmed Gagan 141ef6a882
FIX: Remember sort and topic-search when switching users (#98) 2020-08-14 12:31:34 +01:00
Ahmed Gagan 98bc01be16
UX: Load topic filter results while typing (#101)
This matches the user sidebar filter behaviour
2020-08-14 11:40:23 +01:00
Ahmed Gagan 99c2c48c08
DEV: Refactors following code review (#100) 2020-08-14 11:37:34 +01:00
David Taylor 83ff23c98e
UX: Ensure bottom of usernames/names are never cut off 2020-08-13 17:00:50 +01:00
David Taylor 18284b9a2e
UX: Update group assigned user dropdown styling for mobile 2020-08-13 01:58:46 +01:00
David Taylor 4091211198
UX: New layout for group assigned user sidebar 2020-08-13 01:23:08 +01:00
David Taylor 17bf41e775
UX: Align user and topic search boxes 2020-08-13 00:01:14 +01:00
Ahmed Gagan 069adc1af7
FEATURE: Allow searching topics in group assigned tab (#97) 2020-08-12 23:40:04 +01:00
Ahmed Gagan f250dca93f
FEATURE: Allow filtering users in group assigned tab (#95) 2020-08-12 23:39:14 +01:00
Ahmed Gagan a844da7656
FIX: Refresh members and tab count when assignments change 2020-08-12 23:07:05 +01:00
Kris 7abf37cc78
Update for refactored quick access panels (#96)
Related to 1972364d0f
2020-08-10 16:34:38 -04:00
Ahmed Gagan cb9ca82644
FIX: Remember scroll position in long assigned lists 2020-08-05 13:18:09 +01:00
Ahmed Gagan 050143960c
FEATURE: Link user card from assigned list avatar (#93) 2020-08-05 12:19:20 +01:00
Ahmed Gagan 96c3d9d12e
UX: Scroll to top of assigned list when switching users 2020-08-04 16:26:10 +01:00
Ahmed Gagan 6dbf3e2bcb
FEATURE: Allow sorting assigned topic lists 2020-08-04 15:48:33 +01:00
Penar Musaraj 36adc0b14c
DEV: Switch to CSS custom properties for colors in scss
Preparing the plugin for an upcoming core change. Note that this change
is backwards-compatible.
2020-08-03 12:57:55 -04:00
Ahmed Gagan 301be24c13
UX: Rename group tab from Assignments to Assigned (#88) 2020-07-27 12:26:12 +01:00
Kris 26682ccec4
UX: Improving styling so names/usernames fit better (#86) 2020-07-23 13:13:55 +01:00
Ahmed Gagan cd3e5763d1
UX: Hide group tab when there are no assignments, add everyone count (#83) 2020-07-21 16:26:40 +01:00
Ahmed Gagan 816f3c0e97
FEATURE: Per-member counts in group assignment summary (#80) 2020-07-21 12:55:34 +01:00
Ahmed Gagan 4d5169c445
UX: Remember scroll position in assign lists (#82) 2020-07-21 12:53:26 +01:00
Jarek Radosz 68bebd77f6 DEV: Prettier fix 2020-07-17 18:20:29 +02:00
Ahmed Gagan fa08157e30
UX: Use username/name in group member list according to site setting (#75) 2020-07-17 16:18:17 +01:00
Ahmed Gagan bc26f099fa
FIX: Group assignments dropdown on mobile (#76) 2020-07-14 11:55:07 +01:00
Ahmed Gagan 027d5dd40a
FIX: Resolve missing variable in assigned-topic-list dropdown (#74) 2020-07-13 12:38:04 +01:00
Ahmed Gagan 43759bd8ef
FIX: Group name with capital letter throws 404 error (#73) 2020-07-10 11:33:48 +01:00
David Taylor 48cda7bb79
FIX: Do not raise an error for anon user on group page 2020-07-10 10:20:10 +01:00
Ahmed Gagan ae83f70e21
FEATURE: Assignments summary tab for groups (#70) 2020-07-10 09:45:18 +01:00
Robin Ward f5e53f8d22 FIX: Linting 2020-07-07 11:36:45 -04:00
Robin Ward a991684943 FIX: Add `getURL` back in
I think the failure was unrelated
2020-07-07 11:26:23 -04:00
Sam Saffron c49a1288b2
Revert "Import getURL to fix deprecation warnings (#72)"
This reverts commit e3a6a64193.

This sadly broke our build
2020-07-07 11:43:15 +10:00
Jarek Radosz 1a083e8b88
DEV: Fix the `getURL` deprecation warning (#69) 2020-07-06 17:01:44 +02:00
Mark VanLandingham e3a6a64193
Import getURL to fix deprecation warnings (#72) 2020-07-06 09:27:01 -05:00
Jarek Radosz bc6669150d
FIX: Don't set assign button's height (#71)
"we can't use flex for buttons yet" – now we can, and we do! e71f5e8951

Fixes an issue with assign button height in some themes.
2020-07-03 12:33:59 +02:00
jjaffeux e71bca3bff FIX: removes css hack 2020-05-22 17:03:12 +02:00
jjaffeux 1761f749e1 FIX: doesn't need to be dependant on isPrivateMessage 2020-05-20 15:02:58 +02:00
jjaffeux be6dcfa38d FIX: removes PM check 2020-05-20 14:54:30 +02:00
jjaffeux 705b30c093 UX: always display assign button in dropdown on mobile 2020-05-20 14:07:37 +02:00
jjaffeux cddc0a2eb5 UX: displays avatar instead of icon on desktop 2020-05-19 10:51:20 +02:00
jjaffeux 88f0c37702 FIX: remove icon size height, as it impacts other buttons indirectly 2020-05-13 22:48:59 +02:00
jjaffeux 3df853f5fb FIX: uses same style for mobile PMs than desktop 2020-05-13 11:01:36 +02:00
jjaffeux 8b7f89823d UX: improves assignee display on button and dropdown
- Changes the title attribute to display the name of the assignee
- Displays the assignee’s username in the row when  on mobile view
- Tweaks positioning to attempt good alignment
- Slightly increases icon size to have visually the same size than other topic footer buttons icons
2020-05-12 15:49:13 +02:00
jjaffeux c271178f73 UX: keeps showing icon for more consistency 2020-05-12 09:30:44 +02:00
jjaffeux 2123cfc40e UX: slightly better alignement of the avatar img 2020-05-12 09:02:55 +02:00
Joffrey JAFFEUX af11fdca47
FEATURE: displays assignee avatar in button and dropdown (#66) 2020-05-11 19:02:22 +02:00
jjaffeux c553c039f0 DEV: adds a task action bypassing the modal 2020-05-08 11:53:51 +02:00
David Taylor 07c13651c6
FIX: Correct assign user autocomplete logic
Previously we were only autocompleting users which were in the same group as the acting user.
2020-04-28 13:55:17 +01:00
Justin DiRose 71fe8a54c0
FEATURE: Add 'g a' as keyboard shortcut to assigned list (#64) 2020-04-23 13:03:45 -05:00
Martin Brennan e7d5c88c8b
FEATURE: Add assigned to user to bookmark serializers (#62)
Add assigned to user to bookmark serializers, and also add to JS bookmark model for the route to assigned user.
2020-03-12 15:21:48 +10:00
Penar Musaraj 3675a5e273
DEV: use site settings from container (#60)
This is a bit more robust, site settings are not always injected (for example in raw handlebars templates).
2020-02-25 17:06:54 -05:00
Kris 73ad40cd1d UX: Additional wrapper to fix mobile modal spacing, related to de559f3 2020-02-20 12:35:57 -05:00
Penar Musaraj 11794fd00a DEV: Find/replace deprecated decorators 2020-02-19 11:53:36 -05:00
jjaffeux b302d7566b FIX: prevents crash if assign_allowed_on_groups is empty 2020-01-22 09:50:40 +01:00
jjaffeux 7933a29fa0 FIX: @ember/object is not yet available in stable 2020-01-15 16:06:50 +01:00
Blake Erickson 18d6bcdcbd
FIX: Update topic-list-item to reflect changes in core (#59)
* FIX: Update topic-list-item to reflect changes in core

This PR in discourse core:

https://github.com/discourse/discourse/pull/8589

makes a breaking change in this plugin. This is a fix for it.

* add backwards compatible fix

* Apply prettier fix
2020-01-06 16:39:16 -07:00
romanrizzi c4f878a70c Minor improvements to the assigned-to-filter connector 2019-12-04 16:51:49 -03:00
Joffrey JAFFEUX 2f2cbd1e11 FIX: model might be a POJO and not a post model 2019-12-03 11:51:35 +01:00
Roman Rizzi 3593f9ef67
FEATURE: Filter reviewables by assigned user (#58) 2019-11-25 13:48:09 -03:00
Dan Ungureanu 434605f03f
FIX: Make it compatible with sub-folder installs 2019-11-25 14:53:17 +02:00
Sam Saffron b4d8001dc8 FIX: currentURL is unstable for in route transitions
If you transition just using query params but leave the rest of the route
alone, sometimes router.currentURL will not update.

This in turn causes active not to work correctly.
2019-11-06 16:36:26 +11:00
Sam Saffron 68ff24739b DEV: attempt a more cautious lookup
This was failing the test suite somehow, despite voting using the same
pattern.
2019-11-01 15:26:16 +11:00
Sam Saffron e0de9238a1 FEATURE: new category setting to add "Unassigned" navigation menu
When a category is used exclusively for managing topic assignments it can
be very useful to list all the unassigned topics. This introduces a new
category setting that allows admins to opt for this new navigation item.

It works both on mobile and desktop.

This uses an amended nav item API, to experience this fully you need latest
versions of Discourse.
2019-11-01 14:15:28 +11:00
Sam Saffron bc5469c6c6 Revert "FEATURE: new category setting to add "Unassigned" navigation menu"
This reverts commit 600e1b6544.

The level of hack here is just to high, this destabilizes tests. We need a
proper pattern.
2019-10-30 18:16:12 +11:00
Sam Saffron abc21b7734 Revert "DEV: make pre-initializer a bit safer"
This reverts commit 029a26733a.

This whole experiment is too unstable
2019-10-30 18:13:30 +11:00
Sam Saffron 029a26733a DEV: make pre-initializer a bit safer
Was noticing custom fields could be null is some cases so this ensures we
never reach to it if missing
2019-10-30 17:55:50 +11:00
Sam Saffron ce63380eb5 DEV: Missed running prettier automatically
This is not fixed in my dev environment
2019-10-30 17:07:40 +11:00
Sam Saffron 600e1b6544 FEATURE: new category setting to add "Unassigned" navigation menu
When a category is used exclusively for managing topic assignments it can
be very useful to list all the unassigned topics. This introduces a new
category setting that allows admins to opt for this new navigation item.

It works both on mobile and desktop.

Unfortunately Discourse is lacking internal APIs for cleanly adding NavItems

We will look at improving this soon.
2019-10-30 16:37:13 +11:00
romanrizzi a6df22bb32 DEV: Remove old backward-compatibility code 2019-10-09 15:21:00 -03:00