Commit Graph

244 Commits

Author SHA1 Message Date
Krzysztof Kotlarek 69dac06a82
FIX: correctly update UI when post is assigned/unassigned (#233)
Update topic title, first post and related post
2021-11-09 08:40:43 +11:00
Krzysztof Kotlarek a4b1847eff
FEATURE: display indirect assignments in the first post (#227)
A link in the first post will allow going to a specific post assigned to a user or group.
2021-11-03 10:35:10 +11:00
Krzysztof Kotlarek c396605d2f
FEATURE: assign to post (#224)
Ability to assign an individual post to a user or group
2021-11-01 09:27:13 +11:00
Krzysztof Kotlarek dc8f43fbb1
FEATURE: Assignment target is polymorphic (#218)
Change `topic_id` to polymorphic approach (In the next step we will allow assigning to individual post)

`topic_id` column is still used for efficient display of assigned users on topic list (to avoid scanning posts)
2021-10-14 09:22:29 +11:00
Jarek Radosz 58315230f0
UX: Remove an obsolete css class from an element (#220)
1. It's not needed in the new advanced search interface
2. It causes problems in some cases
2021-10-12 17:22:02 +11:00
Penar Musaraj dd2eae8f9c
DEV: Update bulk select in group topics list (#214) 2021-09-23 10:50:36 -04:00
Penar Musaraj 74b9f3d22c
UX: Fix input styling in group assignments page (#213) 2021-09-21 14:25:01 -04:00
Bianca Nenciu 85fa1f90aa
FIX: Refresh first post after assign and unassign (#212)
The first post showed the assign status when it was loaded and did not
update if it changed. The page had to be refreshed for the text to be
updated.
2021-09-17 10:37:36 +10:00
Robin Ward 7082e32122
FIX: Tests were broken on Ember CLI (#211)
The first issue is using `updateCurrentUser` when code was conditional
in an initializer. Instead we need to use `needs.user()`.

The second issue was trickier to track down but we were using an
observer in a syncrhnous way which is not allowed in newer Embers. This
removes the observer (and some dead code around it!) so that we can
execute that code synchronously.
2021-09-16 08:46:44 -04:00
Penar Musaraj 83635ced6f
DEV: Remove displayNewPosts (deprecated in core) (#208) 2021-09-15 08:29:48 -04:00
Martin Brennan 5f7adcc786
FIX: Allow Never selection for frequency of assigned topic reminders (#204)
If the user selected Never for their frequency of assigned topic
reminder PMs, the option automatically set back to the default
value (Monthly) because of the user of the `or` computed helper,
which considered the 0 value of Never to be falsey.

This is the same problem that occurred in core which was fixed by
d3779d4cf7

We need to be careful around using the `or` helper if any of the
options could be considered falsey.
2021-09-15 08:31:59 +10:00
Penar Musaraj 463b1c2cf0
DEV: Add `pluginId` in one last `modifyClass` call (#207) 2021-09-14 15:50:15 -04:00
Penar Musaraj 86a2b1d574
UX: Fix input alignment following core changes (#200) 2021-09-14 09:41:08 -04:00
Krzysztof Kotlarek 62d87f0084
FEATURE: better UI for group assignments (#197)
On the group assignment page, we should be able to display
- all topics assigned to that group + to user belonging to that group
- all topics assigned directly to group
- all topics assigned to individual user
2021-09-09 12:18:18 +10:00
Krzysztof Kotlarek 5954c625ef
FEATURE: advance search groups (#198)
Allow advance search filter to select topics assigned to specific group
2021-09-08 11:39:15 +10:00
Krzysztof Kotlarek 375f7ba78d
FEATURE: new assignable group option instead of messageable (#195)
V1 of group assign was using "who can message" to determine if group can be assigned.

This PR is introducing new separate setting "who can assign"
2021-09-08 10:30:13 +10:00
Robin Ward f541158b64
DEV: Add `pluginId` for more stable tests (#196) 2021-09-02 15:46:32 -04:00
Krzysztof Kotlarek b42ec9f779
FIX: correct group icons and notification message (#193)
* New group icon
* Group assignment notification displays group name instead of who assigned
2021-08-31 08:17:43 +10:00
Krzysztof Kotlarek 9d7d39705e
FIX: broken suggestions (#189)
We need to pass name to assignUser because it is used in 2 places.
One is multiselect and another are suggestions.
2021-08-27 12:57:17 +10:00
Krzysztof Kotlarek 1306a69b06
FIX: whisper small actions are blank (#188)
assigned_group and unassigned_group has to be added to decorator to properly display whispers
2021-08-27 11:34:44 +10:00
Jarek Radosz d807491df2
FEATURE: Assign to group (#182)
Ability to assign groups.

To assign group, user must have a right to send a message to that group.

In addition, 2 jobs were introduced, - AssignNotification and UnassignNotification to inform interested users in the background about the new assignment.
2021-08-27 09:25:38 +10:00
Andrei Prigorshnev 29d4b8fd5c
FEATURE: improve blank page syndrome (#187) 2021-08-25 19:51:45 +04:00
Joffrey JAFFEUX a8495e9d7a
FIX: makes dropdown use absolute positioning (#185) 2021-08-16 12:19:48 +02:00
Joffrey JAFFEUX 92a1167a68
FIX: explicit assign on user selection (#184)
Also drops autofocus as it's the first item in the form
2021-08-16 10:56:01 +02:00
Jarek Radosz ad95725987
FIX: Hide Unassigned if user doesn't have access (#179)
There's no need to display the "Unassigned" button for regular users when `assigns_public` is `false`.
2021-07-30 20:58:39 +02:00
Jarek Radosz 9ecc1581fd
DEV: Remove old review queue code (#178)
I think it should have been deleted with https://github.com/discourse/discourse-assign/pull/47? That's where e.g. `assign_locks_flags` site setting was removed.
2021-07-30 14:43:28 +02:00
Penar Musaraj c572e21493
UX: Add quick search suggestion entries (#175) 2021-07-21 14:00:43 -04:00
Jarek Radosz dfb30fc104
FIX: TagsHtmlCallback params can be undefined (#174) 2021-07-20 13:53:17 +02:00
Jarek Radosz 4e657b97df
FIX: Make tagsHtml callback respect tagName option (#173)
Makes the assigned icon and label non-interactive in search results dropdown.
2021-07-20 12:37:33 +02:00
Martin Brennan 8b0596fc87
FIX: Assign topic button not working (#164)
Since this commit
195dcc92cb
the updateUsername function was missing an @action decorator. This adds
it back and extends the assign acceptance tests to click the
mobile/desktop assign buttons and open the modal and click the
suggestion to save the assignment.
2021-06-29 10:12:19 +10:00
Jarek Radosz 195dcc92cb
DEV: Post-release cleanup (#163)
Included:

* DEV: Post-release cleanup
* DEV: Tests cleanup
* DEV: Import cleanup
* DEV: Drop a compatibility fix
* DEV: Use index_by
* DEV: Use ember imports
* DEV: Use discourseDebounce
* DEV: Use @action
* DEV: Use the optional chaining operator
* DEV: Fix an invalid test
* DEV: Use `discourseModule`
* DEV: Add .prettierrc
* DEV: Sync up the version number
2021-06-28 17:37:27 +02:00
Mark VanLandingham c0d651764f
UX: Improve quick access copy when no topics present (#151) 2021-04-23 11:00:22 -05:00
Osama Sayegh a90e7ab7e2
FIX: Add autofocus to users chooser on the assign modal (#148)
The users chooser on the assign modal is the primary input field on the modal, so it makes to shift focus to it when the modal is opened. This PR needs 0f807ba85b in core to work properly, but it won't cause errors (won't have any effects) if it's deployed to a site that doesn't have that commit.
2021-02-23 14:05:34 +03:00
Roman Rizzi 394f857096
FIX: Use Ember's debounce on stable. (#147)
We need to wrap the new debounce function inside a try block to avoid throwing a "module not found" exception.
2021-02-22 12:55:16 -03:00
Osama Sayegh b1b8c94f56
DEV: Migrate from {{user-selector}} to {{email-group-user-chooser}} (#146) 2021-02-15 12:34:55 +03:00
Jarek Radosz b560cf1002 DEV: Fix template linting issues 2021-02-10 12:14:38 +01:00
Joffrey JAFFEUX 1e7c6eceed
DEV: prettier 2.2.1 (#136) 2021-01-27 10:45:35 +01:00
Roman Rizzi 0bf73af1d7
UX: Redirect to the login page if trying to view assigned topics as anon (#133) 2021-01-22 16:16:35 -03:00
Roman Rizzi 1663b3ab18
Use the new discourseDebounce function wrapper. (#124)
We recently merged a Discourse core's PR to replace usages of Ember's debounce and discourseDebounce with a new debounce wrapper. The new wrapper works exactly like Ember's debounce but internally calls "run" when called in test mode.

This PR replaces all usages of other debounce functions with the new wrapper and fallbacks to Ember's debounce for backward-compatibility.
2020-12-22 14:34:03 -03:00
Robin Ward 53c5933b93
FIX: `onChange` needs an action (#117)
Before this fix it was impossible for a user to change their preference
for reminder frequency.
2020-10-30 11:49:56 -04:00
Joffrey JAFFEUX 977f7592f4
FIX: removes the need for intermediate property and updates code (#114)
Before this commit, changing the value of the reminder frequency on a user notifications page was not working.

This commit also get rid of a few deprecations warning.
2020-09-30 11:10:15 +02:00
jjaffeux 6c14a0288b DEV: linting 2020-09-22 17:07:15 +02:00
jjaffeux 7e023968b8 DEV: removes superfluous arguments 2020-09-22 16:23:23 +02:00
David Taylor c4aefd5917
REFACTOR: Use core `default_results` function (#111)
This significantly reduces the amount of logic we need to carry in the discourse-assign plugin. One side effect is that I had to rename the 'q' parameter to 'search', so that it matches core's implementation.
2020-09-16 12:18:14 +01:00
jjaffeux 445e94de4c DEV: this is now fixed in core 2020-09-16 11:08:16 +02:00
jjaffeux 6a449367f5 FIX: keeps updateInRegex public 2020-09-15 12:23:08 +02:00
jjaffeux 8192b888d5 FIX: missing conditional 2020-09-15 12:18:53 +02:00
jjaffeux 1cc42e5c9a FIX: makes updates of search term work with core update 2020-09-15 12:02:51 +02:00
jjaffeux bf98811165 FIX: ensures autofocus is working 2020-09-11 16:48:00 +02:00
Ahmed Gagan d9826cc608
FIX: Input helper loosing focus and default selecting 'Everyone' tab in 'group-assigned' tab (#112) 2020-09-11 15:06:37 +01:00
Ahmed Gagan 303274eae3
FEATURE: Advanced search filters for assigned topics (#102)
Adds three new search modifiers:

- in:assigned for assigned topics
- in:unassigned for unassigned topics
- assigned:{username} to list topics assigned to a specific user

These modifiers are all made available in the advanced search sidebar
2020-09-11 12:15:50 +01:00
Ahmed Gagan 3e3dc3815b
FEATURE: Assign bulk actions for topics lists (#110)
- Allows unassigning and reassigning topics using bulk actions
- Adds bulk actions UI to the group assigned page
2020-09-11 11:49:25 +01:00
David Taylor e78537ac46
DEV: Apply prettier 2020-09-09 18:41:42 +01:00
Ahmed Gagan 43c68f6ffd
FEATURE: Allow filtering topics in the user assigned list (#108) 2020-09-09 18:28:14 +01:00
Joffrey JAFFEUX 598c717009
DEV: apply coding standards (#109) 2020-09-04 13:24:23 +02:00
Ahmed Gagan cd31a821fc
UX: Only show assigned tab for groups where all users can assign (#103) 2020-08-28 15:18:25 +01:00
Ahmed Gagan 2fad129af5
UX: Ensure equal margin around topic search box (#106) 2020-08-21 14:39:18 +01:00
Ahmed Gagan b88723a3b1
FIX: Correct sorting issues 2020-08-20 12:07:24 +01:00
Ahmed Gagan 141ef6a882
FIX: Remember sort and topic-search when switching users (#98) 2020-08-14 12:31:34 +01:00
Ahmed Gagan 98bc01be16
UX: Load topic filter results while typing (#101)
This matches the user sidebar filter behaviour
2020-08-14 11:40:23 +01:00
Ahmed Gagan 99c2c48c08
DEV: Refactors following code review (#100) 2020-08-14 11:37:34 +01:00
David Taylor 4091211198
UX: New layout for group assigned user sidebar 2020-08-13 01:23:08 +01:00
Ahmed Gagan 069adc1af7
FEATURE: Allow searching topics in group assigned tab (#97) 2020-08-12 23:40:04 +01:00
Ahmed Gagan f250dca93f
FEATURE: Allow filtering users in group assigned tab (#95) 2020-08-12 23:39:14 +01:00
Ahmed Gagan a844da7656
FIX: Refresh members and tab count when assignments change 2020-08-12 23:07:05 +01:00
Kris 7abf37cc78
Update for refactored quick access panels (#96)
Related to 1972364d0f
2020-08-10 16:34:38 -04:00
Ahmed Gagan cb9ca82644
FIX: Remember scroll position in long assigned lists 2020-08-05 13:18:09 +01:00
Ahmed Gagan 050143960c
FEATURE: Link user card from assigned list avatar (#93) 2020-08-05 12:19:20 +01:00
Ahmed Gagan 96c3d9d12e
UX: Scroll to top of assigned list when switching users 2020-08-04 16:26:10 +01:00
Ahmed Gagan 6dbf3e2bcb
FEATURE: Allow sorting assigned topic lists 2020-08-04 15:48:33 +01:00
Ahmed Gagan 301be24c13
UX: Rename group tab from Assignments to Assigned (#88) 2020-07-27 12:26:12 +01:00
Kris 26682ccec4
UX: Improving styling so names/usernames fit better (#86) 2020-07-23 13:13:55 +01:00
Ahmed Gagan cd3e5763d1
UX: Hide group tab when there are no assignments, add everyone count (#83) 2020-07-21 16:26:40 +01:00
Ahmed Gagan 816f3c0e97
FEATURE: Per-member counts in group assignment summary (#80) 2020-07-21 12:55:34 +01:00
Ahmed Gagan 4d5169c445
UX: Remember scroll position in assign lists (#82) 2020-07-21 12:53:26 +01:00
Jarek Radosz 68bebd77f6 DEV: Prettier fix 2020-07-17 18:20:29 +02:00
Ahmed Gagan fa08157e30
UX: Use username/name in group member list according to site setting (#75) 2020-07-17 16:18:17 +01:00
Ahmed Gagan bc26f099fa
FIX: Group assignments dropdown on mobile (#76) 2020-07-14 11:55:07 +01:00
Ahmed Gagan 027d5dd40a
FIX: Resolve missing variable in assigned-topic-list dropdown (#74) 2020-07-13 12:38:04 +01:00
Ahmed Gagan 43759bd8ef
FIX: Group name with capital letter throws 404 error (#73) 2020-07-10 11:33:48 +01:00
David Taylor 48cda7bb79
FIX: Do not raise an error for anon user on group page 2020-07-10 10:20:10 +01:00
Ahmed Gagan ae83f70e21
FEATURE: Assignments summary tab for groups (#70) 2020-07-10 09:45:18 +01:00
Robin Ward f5e53f8d22 FIX: Linting 2020-07-07 11:36:45 -04:00
Robin Ward a991684943 FIX: Add `getURL` back in
I think the failure was unrelated
2020-07-07 11:26:23 -04:00
Sam Saffron c49a1288b2
Revert "Import getURL to fix deprecation warnings (#72)"
This reverts commit e3a6a64193.

This sadly broke our build
2020-07-07 11:43:15 +10:00
Jarek Radosz 1a083e8b88
DEV: Fix the `getURL` deprecation warning (#69) 2020-07-06 17:01:44 +02:00
Mark VanLandingham e3a6a64193
Import getURL to fix deprecation warnings (#72) 2020-07-06 09:27:01 -05:00
jjaffeux 1761f749e1 FIX: doesn't need to be dependant on isPrivateMessage 2020-05-20 15:02:58 +02:00
jjaffeux be6dcfa38d FIX: removes PM check 2020-05-20 14:54:30 +02:00
jjaffeux 705b30c093 UX: always display assign button in dropdown on mobile 2020-05-20 14:07:37 +02:00
jjaffeux cddc0a2eb5 UX: displays avatar instead of icon on desktop 2020-05-19 10:51:20 +02:00
jjaffeux 3df853f5fb FIX: uses same style for mobile PMs than desktop 2020-05-13 11:01:36 +02:00
jjaffeux 8b7f89823d UX: improves assignee display on button and dropdown
- Changes the title attribute to display the name of the assignee
- Displays the assignee’s username in the row when  on mobile view
- Tweaks positioning to attempt good alignment
- Slightly increases icon size to have visually the same size than other topic footer buttons icons
2020-05-12 15:49:13 +02:00
jjaffeux c271178f73 UX: keeps showing icon for more consistency 2020-05-12 09:30:44 +02:00
Joffrey JAFFEUX af11fdca47
FEATURE: displays assignee avatar in button and dropdown (#66) 2020-05-11 19:02:22 +02:00
jjaffeux c553c039f0 DEV: adds a task action bypassing the modal 2020-05-08 11:53:51 +02:00
David Taylor 07c13651c6
FIX: Correct assign user autocomplete logic
Previously we were only autocompleting users which were in the same group as the acting user.
2020-04-28 13:55:17 +01:00
Justin DiRose 71fe8a54c0
FEATURE: Add 'g a' as keyboard shortcut to assigned list (#64) 2020-04-23 13:03:45 -05:00
Martin Brennan e7d5c88c8b
FEATURE: Add assigned to user to bookmark serializers (#62)
Add assigned to user to bookmark serializers, and also add to JS bookmark model for the route to assigned user.
2020-03-12 15:21:48 +10:00
Penar Musaraj 3675a5e273
DEV: use site settings from container (#60)
This is a bit more robust, site settings are not always injected (for example in raw handlebars templates).
2020-02-25 17:06:54 -05:00