FIX: correctly check settings are set

2018-09-03 15:01:40 +02:00 · 2018-09-03 15:01:40 +02:00 · 4dedaaa06d
parent c8f642418c
commit 4dedaaa06d
1 changed files with 3 additions and 1 deletions
--- a/jobs/scheduled/update_mattermost_usernames.rb
+++ b/jobs/scheduled/update_mattermost_usernames.rb
@ -7,7 +7,9 @@ module Jobs
      post_id = SiteSetting.discourse_simple_calendar_holiday_post_id
      server = SiteSetting.discourse_simple_calendar_mattermost_server

-      return unless api_key && post_id && server
+      if api_key.blank? || post_id.blank? || server.blank?
+        return
+      end

      # Fetch all mattermost users
      response = Excon.get("#{server}/api/v4/users", headers: {