diff --git a/assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-channel.js.es6 b/assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-channel.js.es6 index 5bb4a5e..691b921 100644 --- a/assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-channel.js.es6 +++ b/assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-channel.js.es6 @@ -4,11 +4,10 @@ import InputValidation from 'discourse/models/input-validation'; import { default as computed, observes, on } from 'ember-addons/ember-computed-decorators'; export default Ember.Controller.extend(ModalFunctionality, { - @on('init') setupKeydown() { Ember.run.schedule('afterRender', () => { - $('#chat_integration_edit_channel_modal').keydown(e => { + $('#chat-integration-edit-channel-modal').keydown(e => { if (e.keyCode === 13) { this.send('save'); } @@ -19,9 +18,9 @@ export default Ember.Controller.extend(ModalFunctionality, { // The validation property must be defined at runtime since the possible parameters vary by provider @observes('model') setupValidations() { - if(this.get('model.provider')){ + if (this.get('model.provider')) { const theKeys = this.get('model.provider.channel_parameters').map( ( param ) => param['key'] ); - Ember.defineProperty(this,'paramValidation', Ember.computed(`model.channel.data.{${theKeys.join(',')}},this._paramValidation`)); + Ember.defineProperty(this,'paramValidation', Ember.computed(`model.channel.data.${theKeys.join(',')}`, this._paramValidation)); } }, @@ -74,11 +73,11 @@ export default Ember.Controller.extend(ModalFunctionality, { let invalid = false; Object.keys(paramValidation).forEach(key =>{ - if (!validations[key]) { + if (!paramValidation[key]) { invalid = true; } - if (!validations[key]['ok']) { + if (!paramValidation[key]['ok']) { invalid = true; } }); diff --git a/assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-rule.js.es6 b/assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-rule.js.es6 index 46a4c83..80a4224 100644 --- a/assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-rule.js.es6 +++ b/assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-rule.js.es6 @@ -8,7 +8,7 @@ export default Ember.Controller.extend(ModalFunctionality, { @on('init') setupKeydown() { Ember.run.schedule('afterRender', () => { - $('#chat_integration_edit_channel_modal').keydown(e => { + $('#chat-integration-edit-channel-modal').keydown(e => { if (e.keyCode === 13) { this.send('save'); } diff --git a/assets/javascripts/admin/controllers/modals/admin-plugins-chat-test.js.es6 b/assets/javascripts/admin/controllers/modals/admin-plugins-chat-test.js.es6 index b6395b1..b027c31 100644 --- a/assets/javascripts/admin/controllers/modals/admin-plugins-chat-test.js.es6 +++ b/assets/javascripts/admin/controllers/modals/admin-plugins-chat-test.js.es6 @@ -1,5 +1,6 @@ import ModalFunctionality from 'discourse/mixins/modal-functionality'; import { ajax } from 'discourse/lib/ajax'; +import { popupAjaxError } from 'discourse/lib/ajax-error'; import { default as computed, on } from "ember-addons/ember-computed-decorators"; export default Ember.Controller.extend(ModalFunctionality, { diff --git a/assets/javascripts/admin/templates/modal/admin-plugins-chat-edit-channel.hbs b/assets/javascripts/admin/templates/modal/admin-plugins-chat-edit-channel.hbs index cf44e5d..52b19bb 100644 --- a/assets/javascripts/admin/templates/modal/admin-plugins-chat-edit-channel.hbs +++ b/assets/javascripts/admin/templates/modal/admin-plugins-chat-edit-channel.hbs @@ -1,4 +1,4 @@ -{{#d-modal-body id="chat_integration_edit_channel_modal" title="chat_integration.edit_channel_modal.title"}} +{{#d-modal-body id="chat-integration-edit-channel-modal" title="chat_integration.edit_channel_modal.title"}}