From 039d886d60331a7c10b66ca271f2125afb08da66 Mon Sep 17 00:00:00 2001 From: Bianca Nenciu Date: Mon, 1 Apr 2024 14:08:43 +0300 Subject: [PATCH] Apply code suggestions --- lib/docs/query.rb | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/docs/query.rb b/lib/docs/query.rb index 39d9a81..cd4a6b9 100644 --- a/lib/docs/query.rb +++ b/lib/docs/query.rb @@ -225,24 +225,20 @@ module Docs Category.preload_user_fields!(@guardian, categories) - categories = categories.index_by(&:id) - - categories_object = [] - - category_counts.each do |id, count| + categories.map do |category| + count = category_counts[category.id] active = @filters[:category] && @filters[:category].include?(id.to_s) - categories_object << if @guardian.can_lazy_load_categories? + if @guardian.can_lazy_load_categories? BasicCategorySerializer .new(categories[id], scope: @guardian, root: false) .as_json - .merge(id:, count:, active:) + .merge(count:, active:) else - category_object = { id:, count:, active: } + { id: category.id, count:, active: } end end - - categories_object.sort_by { |category| [category[:active] ? 0 : 1, -category[:count]] } + .sort_by { |category| [category[:active] ? 0 : 1, -category[:count]] } end def load_more_url