DEV: Improve patterns per feedback

This commit is contained in:
Justin DiRose 2019-09-16 14:40:53 -05:00
parent e2b6d2ddb5
commit 1b9ea64f15
5 changed files with 25 additions and 18 deletions

View File

@ -1,7 +1,5 @@
export default Ember.Component.extend({ export default Ember.Component.extend({
click() { click() {
const topic = this.get("topic"); this.set("selectedTopic", this.topic.id);
this.set("selectedTopic", topic.id);
} }
}); });

View File

@ -2,8 +2,7 @@ import { default as computed } from "ember-addons/ember-computed-decorators";
export default Ember.Component.extend({ export default Ember.Component.extend({
classNames: "knowledge-explorer-topic", classNames: "knowledge-explorer-topic",
@computed("topic") originalPostContent: Ember.computed.readOnly(
originalPostContent(topic) { "topic.post_stream.posts.firstObject.cooked"
return topic.post_stream.posts[0].cooked; )
}
}); });

View File

@ -3,12 +3,16 @@
{{knowledge-explorer-topic topic=topic}} {{knowledge-explorer-topic topic=topic}}
{{else}} {{else}}
<div class="knowledge-explorer-search"> <div class="knowledge-explorer-search">
{{knowledge-explorer-search searchResults=searchResults searchTerm=searchTerm filterTags=filterTags}} {{knowledge-explorer-search
searchResults=searchResults
searchTerm=searchTerm
filterTags=filterTags
}}
</div> </div>
<div class="knowledge-explorer-browse"> <div class="knowledge-explorer-browse">
{{knowledge-explorer-tag-list {{knowledge-explorer-tag-list
tags=tags tags=tags
filterTags=filterTags filterTags=filterTags
}} }}
<div class="knowledge-explorer-results"> <div class="knowledge-explorer-results">
{{#if hasSearchResults}} {{#if hasSearchResults}}
@ -16,10 +20,16 @@
<div class="result-count no-result">{{i18n 'search.no_results'}}</div> <div class="result-count no-result">{{i18n 'search.no_results'}}</div>
{{else}} {{else}}
<div class="result-count">{{i18n 'knowledge_explorer.search.results' count=searchCount}}</div> <div class="result-count">{{i18n 'knowledge_explorer.search.results' count=searchCount}}</div>
{{knowledge-explorer-topic-list topics=searchResults selectedTopic=selectedTopic}} {{knowledge-explorer-topic-list
topics=searchResults
selectedTopic=selectedTopic
}}
{{/if}} {{/if}}
{{else}} {{else}}
{{knowledge-explorer-topic-list topics=topics selectedTopic=selectedTopic}} {{knowledge-explorer-topic-list
topics=topics
selectedTopic=selectedTopic
}}
{{/if}} {{/if}}
</div> </div>
</div> </div>

View File

@ -3,21 +3,21 @@
width: 80%; width: 80%;
margin: 0 auto; margin: 0 auto;
.knowledge-explorer-nav-link { .knowledge-explorer-nav-link {
font-weight: bold; font-weight: 700;
&.return { &.return {
font-size: .8em; font-size: $font-down-1;
&::before { &::before {
content: "«"; content: "«";
margin-right: 3px; margin-right: 5px;
} }
} }
&.more { &.more {
float: right; float: right;
font-size: 1.2em; font-size: $font-up-1;
padding: 10px 0; padding: 10px 0;
&::after { &::after {
content: "»"; content: "»";
margin-left: 3px; margin-left: 5px;
} }
} }
} }

View File

@ -1,7 +1,7 @@
.mobile-view { .mobile-view {
.knowledge-explorer { .knowledge-explorer {
.knowledge-explorer-topic { .knowledge-explorer-topic {
width: calc(100vw - 35px); width: calc(100vw - .75em);
margin: 10px 0; margin: 10px 0;
} }
.knowledge-explorer-search { .knowledge-explorer-search {