FEATURE: Move to '/e'

'/knowledge-explorer' was proving a bit too verbose, so we're changing
it to '/e'. The former route should redirect to the new one.
This commit is contained in:
Justin DiRose 2020-07-13 10:23:21 -05:00
parent 8d1c1fee3e
commit 25ca793555
No known key found for this signature in database
GPG Key ID: 4B811FB264021800
5 changed files with 12 additions and 11 deletions

View File

@ -1,3 +1,3 @@
export default function() { export default function() {
this.route("knowledgeExplorer", { path: "/knowledge-explorer" }); this.route("knowledgeExplorer", { path: "/e" });
} }

View File

@ -17,7 +17,7 @@ export default {
if (params.orderColumn) filters.push(`order=${params.orderColumn}`); if (params.orderColumn) filters.push(`order=${params.orderColumn}`);
if (params.page) filters.push(`page=${params.page}`); if (params.page) filters.push(`page=${params.page}`);
let promise = ajax(`/knowledge-explorer.json?${filters.join("&")}`); let promise = ajax(`/e.json?${filters.join("&")}`);
if (params.selectedTopic) { if (params.selectedTopic) {
promise = promise.then(data => { promise = promise.then(data => {

View File

@ -6,7 +6,8 @@ module ::KnowledgeExplorer
config.after_initialize do config.after_initialize do
Discourse::Application.routes.append do Discourse::Application.routes.append do
mount ::KnowledgeExplorer::Engine, at: '/knowledge-explorer' mount ::KnowledgeExplorer::Engine, at: '/e'
get '/knowledge-explorer', to: redirect("/e")
end end
end end
end end

View File

@ -168,7 +168,7 @@ module KnowledgeExplorer
filters.push('page=1') filters.push('page=1')
end end
"/knowledge-explorer.json?#{filters.join('&')}" "/e.json?#{filters.join('&')}"
end end
end end
end end

View File

@ -18,7 +18,7 @@ describe KnowledgeExplorer::KnowledgeExplorerController do
describe 'knowledge explorer data' do describe 'knowledge explorer data' do
context 'when any user' do context 'when any user' do
it 'should return the right response' do it 'should return the right response' do
get '/knowledge-explorer.json' get '/e.json'
expect(response.status).to eq(200) expect(response.status).to eq(200)
@ -41,7 +41,7 @@ describe KnowledgeExplorer::KnowledgeExplorerController do
end end
it 'should not show topics in private categories without permissions' do it 'should not show topics in private categories without permissions' do
get '/knowledge-explorer.json' get '/e.json'
json = JSON.parse(response.body) json = JSON.parse(response.body)
topics = json['topics']['topic_list']['topics'] topics = json['topics']['topic_list']['topics']
@ -53,7 +53,7 @@ describe KnowledgeExplorer::KnowledgeExplorerController do
admin = Fabricate(:admin) admin = Fabricate(:admin)
sign_in(admin) sign_in(admin)
get '/knowledge-explorer.json' get '/e.json'
json = JSON.parse(response.body) json = JSON.parse(response.body)
topics = json['topics']['topic_list']['topics'] topics = json['topics']['topic_list']['topics']
@ -64,7 +64,7 @@ describe KnowledgeExplorer::KnowledgeExplorerController do
context 'when filtering by tag' do context 'when filtering by tag' do
it 'should return a list filtered by tag' do it 'should return a list filtered by tag' do
get '/knowledge-explorer.json?tags=test' get '/e.json?tags=test'
expect(response.status).to eq(200) expect(response.status).to eq(200)
@ -86,7 +86,7 @@ describe KnowledgeExplorer::KnowledgeExplorerController do
end end
it 'should return a list filtered by category' do it 'should return a list filtered by category' do
get "/knowledge-explorer.json?category=#{category2.id}" get "/e.json?category=#{category2.id}"
expect(response.status).to eq(200) expect(response.status).to eq(200)
@ -116,7 +116,7 @@ describe KnowledgeExplorer::KnowledgeExplorerController do
end end
it 'should correctly filter topics' do it 'should correctly filter topics' do
get "/knowledge-explorer.json?search=banana" get "/e.json?search=banana"
expect(response.status).to eq(200) expect(response.status).to eq(200)
@ -130,7 +130,7 @@ describe KnowledgeExplorer::KnowledgeExplorerController do
expect(topics.size).to eq(2) expect(topics.size).to eq(2)
get "/knowledge-explorer.json?search=walk" get "/e.json?search=walk"
json = JSON.parse(response.body) json = JSON.parse(response.body)
topics = json['topics']['topic_list']['topics'] topics = json['topics']['topic_list']['topics']