From 2a2e36bbe24a0486248e9261041a682aae40c2e7 Mon Sep 17 00:00:00 2001 From: jjaffeux Date: Wed, 23 Sep 2020 14:45:15 +0200 Subject: [PATCH] REFACTORING: replacing itself by itself is unecessary --- .../discourse/controllers/knowledge-explorer.js.es6 | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/assets/javascripts/discourse/controllers/knowledge-explorer.js.es6 b/assets/javascripts/discourse/controllers/knowledge-explorer.js.es6 index 6f1dba9..f4419ea 100644 --- a/assets/javascripts/discourse/controllers/knowledge-explorer.js.es6 +++ b/assets/javascripts/discourse/controllers/knowledge-explorer.js.es6 @@ -130,10 +130,7 @@ export default Ember.Controller.extend({ updateSelectedTags(tag) { let filter = this.filterTags; if (filter && filter.includes(tag.id)) { - filter = filter - .replace(tag.id, "") - .replace("|", "|") - .replace(/^\|+|\|+$/g, ""); + filter = filter.replace(tag.id, "").replace(/^\|+|\|+$/g, ""); } else if (filter) { filter = `${filter}|${tag.id}`; } else { @@ -150,10 +147,7 @@ export default Ember.Controller.extend({ updateSelectedCategories(category) { let filter = this.filterCategories; if (filter && filter.includes(category.id)) { - filter = filter - .replace(category.id, "") - .replace("|", "|") - .replace(/^\|+|\|+$/g, ""); + filter = filter.replace(category.id, "").replace(/^\|+|\|+$/g, ""); } else if (filter) { filter = `${filter}|${category.id}`; } else {