From 699d057b9487b368019a10adeae8c8fc210a5ca6 Mon Sep 17 00:00:00 2001 From: Justin DiRose Date: Mon, 27 Jul 2020 11:22:28 -0500 Subject: [PATCH] FIX: Links were not clickable after load more The event listener function was running on the incorrect lifecycle hook. Should've been didRender. This commit also fixes a small bug where in some cases the screen would not scroll all the way to the top. --- .../discourse/components/knowledge-explorer-topic-list.js.es6 | 2 +- .../javascripts/discourse/controllers/knowledge-explorer.js.es6 | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/assets/javascripts/discourse/components/knowledge-explorer-topic-list.js.es6 b/assets/javascripts/discourse/components/knowledge-explorer-topic-list.js.es6 index 0abf7ff..33e9653 100644 --- a/assets/javascripts/discourse/components/knowledge-explorer-topic-list.js.es6 +++ b/assets/javascripts/discourse/components/knowledge-explorer-topic-list.js.es6 @@ -13,7 +13,7 @@ export default Ember.Component.extend({ }, // need to handle clicks here since links are in a raw view - didInsertElement() { + didRender() { const topicLinks = this.element.getElementsByClassName( "knowledge-explorer-topic-link" ); diff --git a/assets/javascripts/discourse/controllers/knowledge-explorer.js.es6 b/assets/javascripts/discourse/controllers/knowledge-explorer.js.es6 index 1090764..727ad88 100644 --- a/assets/javascripts/discourse/controllers/knowledge-explorer.js.es6 +++ b/assets/javascripts/discourse/controllers/knowledge-explorer.js.es6 @@ -109,6 +109,8 @@ export default Ember.Controller.extend({ selectedTopic: topicId }); + window.scrollTo(0, 0); + KnowledgeExplorer.getTopic(topicId).then(result => { this.setProperties({ topic: Topic.create(result),