From b2404797f23dc47f65d2f6ade5e470a4aecf6fb9 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Thu, 8 Dec 2022 09:44:03 +0800 Subject: [PATCH] DEV: Update experimental sidebar site setitng to follow core (#115) --- assets/javascripts/discourse/initializers/setup-docs.js | 2 +- test/javascripts/acceptance/docs-sidebar-test.js | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/assets/javascripts/discourse/initializers/setup-docs.js b/assets/javascripts/discourse/initializers/setup-docs.js index f0036f3..ae85743 100644 --- a/assets/javascripts/discourse/initializers/setup-docs.js +++ b/assets/javascripts/discourse/initializers/setup-docs.js @@ -43,7 +43,7 @@ export default { }); withPluginApi("1.2.0", (api) => { - if (siteSettings.enable_experimental_sidebar_hamburger) { + if (siteSettings.navigation_menu !== "legacy") { api.addCommunitySectionLink({ name: "docs", route: "docs.index", diff --git a/test/javascripts/acceptance/docs-sidebar-test.js b/test/javascripts/acceptance/docs-sidebar-test.js index f66733a..d2a4bff 100644 --- a/test/javascripts/acceptance/docs-sidebar-test.js +++ b/test/javascripts/acceptance/docs-sidebar-test.js @@ -16,8 +16,7 @@ acceptance("Docs - Sidebar with docs disabled", function (needs) { needs.site({ docs_path: DOCS_URL_PATH }); needs.settings({ docs_enabled: false, - enable_experimental_sidebar_hamburger: true, - enable_sidebar: true, + navigation_menu: "sidebar", }); test("docs sidebar link is hidden", async function (assert) { @@ -39,8 +38,7 @@ acceptance("Docs - Sidebar with docs enabled", function (needs) { needs.site({ docs_path: DOCS_URL_PATH }); needs.settings({ docs_enabled: true, - enable_experimental_sidebar_hamburger: true, - enable_sidebar: true, + navigation_menu: "sidebar", }); needs.pretender((server, helper) => {