From c2f27d1e3b8d09c4f90a49a1575e07ce7d291b09 Mon Sep 17 00:00:00 2001
From: Penar Musaraj <pmusaraj@gmail.com>
Date: Wed, 24 May 2023 16:06:09 -0400
Subject: [PATCH] FIX: Toggling categories was requiring two clicks (#134)

---
 assets/javascripts/discourse/controllers/docs-index.js | 2 +-
 test/javascripts/acceptance/docs-test.js               | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/assets/javascripts/discourse/controllers/docs-index.js b/assets/javascripts/discourse/controllers/docs-index.js
index 8a8b65e..c4b7420 100644
--- a/assets/javascripts/discourse/controllers/docs-index.js
+++ b/assets/javascripts/discourse/controllers/docs-index.js
@@ -292,7 +292,7 @@ export default Controller.extend({
   @action
   updateSelectedCategories(category) {
     const filterCategories =
-      category.id === this.filterCategories ? null : category.id;
+      category.id === parseInt(this.filterCategories, 10) ? null : category.id;
     this.setProperties({
       filterCategories,
       selectedTopic: null,
diff --git a/test/javascripts/acceptance/docs-test.js b/test/javascripts/acceptance/docs-test.js
index 705ed5f..e263fdc 100644
--- a/test/javascripts/acceptance/docs-test.js
+++ b/test/javascripts/acceptance/docs-test.js
@@ -63,6 +63,13 @@ acceptance("Docs", function (needs) {
 
     await click(".docs-item.docs-category");
     assert.equal(count(".docs-category.selected"), 1);
+
+    await click(".docs-item.docs-category");
+    assert.equal(
+      count(".docs-category.selected"),
+      0,
+      "clicking again deselects"
+    );
   });
 });