discourse
/
discourse-docs
mirror of https://github.com/discourse/discourse-docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Update QUnit acceptance tests to not rely on legacy nav menu (#152) 

Why this change?

The legacy navigation menu has been deprecated for quite awhile and will
soon be removed.

What does this change do?

Update the tests to test against the `sidebar` navigation menu instead
which is the default for a new Discourse install.
This commit is contained in:
Alan Guo Xiang Tan 2023-10-03 12:22:05 +08:00 committed by GitHub
parent 89c7274b1a
commit cd85ea37a5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/javascripts/acceptance/docs-test.js
View File

@ -16,7 +16,6 @@ acceptance("Docs", function (needs) {
needs.site({ docs_path: DOCS_URL_PATH }); needs.site({ docs_path: DOCS_URL_PATH });
needs.settings({ needs.settings({
docs_enabled: true, docs_enabled: true,
navigation_menu: "legacy",
}); });
needs.pretender((server, helper) => { needs.pretender((server, helper) => {
@ -45,8 +44,14 @@ acceptance("Docs", function (needs) {
this.siteSettings.tagging_enabled = true; this.siteSettings.tagging_enabled = true;
await visit("/"); await visit("/");
await click("#toggle-hamburger-menu");
await click(".docs-link"); await click(
".sidebar-section[data-section-name='community'] .sidebar-more-section-links-details-summary"
);
await click(
".sidebar-section[data-section-name='community'] .sidebar-section-link[data-link-name='docs']"
);
assert.equal(query(".docs-category .docs-item-id").innerText, "bug"); assert.equal(query(".docs-category .docs-item-id").innerText, "bug");
assert.equal(query(".docs-category .docs-item-count").innerText, "119"); assert.equal(query(".docs-category .docs-item-count").innerText, "119");
@ -79,7 +84,6 @@ acceptance("Docs - with tag groups enabled", function (needs) {
needs.site({ docs_path: DOCS_URL_PATH }); needs.site({ docs_path: DOCS_URL_PATH });
needs.settings({ needs.settings({
docs_enabled: true, docs_enabled: true,
navigation_menu: "legacy",
}); });
function getRootElementText(selector) { function getRootElementText(selector) {
@ -118,8 +122,14 @@ acceptance("Docs - with tag groups enabled", function (needs) {
"my-tag-group-1|my-tag-group-2|my-tag-group-3"; "my-tag-group-1|my-tag-group-2|my-tag-group-3";
await visit("/"); await visit("/");
await click("#toggle-hamburger-menu");
await click(".docs-link"); await click(
".sidebar-section[data-section-name='community'] .sidebar-more-section-links-details-summary"
);
await click(
".sidebar-section[data-section-name='community'] .sidebar-section-link[data-link-name='docs']"
);
assert.equal(query(".docs-category .docs-item-id").innerText, "bug"); assert.equal(query(".docs-category .docs-item-id").innerText, "bug");
assert.equal(query(".docs-category .docs-item-count").innerText, "119"); assert.equal(query(".docs-category .docs-item-count").innerText, "119");