DEV: Update linting (#199)

This commit is contained in:
Jarek Radosz 2025-03-13 16:08:28 +01:00 committed by GitHub
parent 7b4f5424bb
commit d200f6c928
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 999 additions and 362 deletions

View File

@ -1,80 +1,93 @@
GEM
remote: https://rubygems.org/
specs:
activesupport (7.1.3.3)
activesupport (8.0.2)
base64
benchmark (>= 0.3)
bigdecimal
concurrent-ruby (~> 1.0, >= 1.0.2)
concurrent-ruby (~> 1.0, >= 1.3.1)
connection_pool (>= 2.2.5)
drb
i18n (>= 1.6, < 2)
logger (>= 1.4.2)
minitest (>= 5.1)
mutex_m
tzinfo (~> 2.0)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
uri (>= 0.13.1)
ast (2.4.2)
base64 (0.2.0)
bigdecimal (3.1.8)
concurrent-ruby (1.2.3)
connection_pool (2.4.1)
benchmark (0.4.0)
bigdecimal (3.1.9)
concurrent-ruby (1.3.5)
connection_pool (2.5.0)
drb (2.2.1)
i18n (1.14.5)
i18n (1.14.7)
concurrent-ruby (~> 1.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
minitest (5.23.1)
mutex_m (0.2.0)
parallel (1.24.0)
parser (3.3.1.0)
json (2.10.2)
language_server-protocol (3.17.0.4)
lint_roller (1.1.0)
logger (1.6.6)
minitest (5.25.5)
parallel (1.26.3)
parser (3.3.7.1)
ast (~> 2.4.1)
racc
prettier_print (1.2.1)
racc (1.8.0)
rack (3.0.12)
racc (1.8.1)
rack (3.1.12)
rainbow (3.1.1)
regexp_parser (2.9.2)
rexml (3.3.9)
rubocop (1.64.0)
regexp_parser (2.10.0)
rubocop (1.74.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.31.1, < 2.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.38.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.38.1)
parser (>= 3.3.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
rubocop-discourse (3.8.0)
rubocop-capybara (2.22.1)
lint_roller (~> 1.1)
rubocop (~> 1.72, >= 1.72.1)
rubocop-discourse (3.12.1)
activesupport (>= 6.1)
rubocop (>= 1.59.0)
rubocop-capybara (>= 2.0.0)
rubocop-factory_bot (>= 2.0.0)
rubocop-rails (>= 2.25.0)
rubocop-rspec (>= 2.25.0)
rubocop-factory_bot (2.25.1)
rubocop (~> 1.41)
rubocop-rails (2.25.0)
lint_roller (>= 1.1.0)
rubocop (>= 1.73.2)
rubocop-capybara (>= 2.22.0)
rubocop-factory_bot (>= 2.27.0)
rubocop-rails (>= 2.30.3)
rubocop-rspec (>= 3.0.1)
rubocop-rspec_rails (>= 2.31.0)
rubocop-factory_bot (2.27.1)
lint_roller (~> 1.1)
rubocop (~> 1.72, >= 1.72.1)
rubocop-rails (2.30.3)
activesupport (>= 4.2.0)
lint_roller (~> 1.1)
rack (>= 1.1)
rubocop (>= 1.33.0, < 2.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop-rspec (2.29.2)
rubocop (~> 1.40)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
rubocop-rspec_rails (~> 2.28)
rubocop-rspec_rails (2.28.3)
rubocop (~> 1.40)
rubocop (>= 1.72.1, < 2.0)
rubocop-ast (>= 1.38.0, < 2.0)
rubocop-rspec (3.5.0)
lint_roller (~> 1.1)
rubocop (~> 1.72, >= 1.72.1)
rubocop-rspec_rails (2.31.0)
lint_roller (~> 1.1)
rubocop (~> 1.72, >= 1.72.1)
rubocop-rspec (~> 3.5)
ruby-progressbar (1.13.0)
securerandom (0.4.1)
syntax_tree (6.2.0)
prettier_print (>= 1.2.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.5.0)
unicode-display_width (3.1.4)
unicode-emoji (~> 4.0, >= 4.0.4)
unicode-emoji (4.0.4)
uri (1.0.3)
PLATFORMS
ruby
@ -84,4 +97,4 @@ DEPENDENCIES
syntax_tree
BUNDLED WITH
2.5.10
2.6.5

View File

@ -1,6 +1,7 @@
.docs-search-wrapper {
position: relative;
width: 500px;
.d-icon {
position: absolute;
right: 0.75em;
@ -8,11 +9,13 @@
font-size: 1.5em;
color: var(--primary-low-mid);
pointer-events: none;
@media screen and (max-width: 400px) {
// Just decoration, remove on small screens
display: none;
}
}
.btn.clear-search {
background-color: var(--secondary);
color: var(--tertiary);
@ -30,41 +33,58 @@
display: flex;
justify-content: center;
padding: 1.5em 1em;
@include breakpoint(mobile-extra-large, min-width) {
// More breathing room on larger screens
margin-bottom: 2em;
}
.docs-search-bar {
height: 50px;
margin-bottom: 0px;
margin-bottom: 0;
width: 100%;
}
}
.docs-browse {
display: flex;
// TODO: Remove once legacy topic-list is removed
.topic-list-data.replies,
.topic-list-data.posts,
.topic-list-data.views {
display: none;
}
.loading-container {
display: flex;
flex-basis: 100%;
padding: 0.625em 0;
}
.docs-results {
display: flex;
flex-direction: column;
flex-basis: 100%;
.result-count {
padding-top: 15px;
padding-left: 0.625em;
}
}
.docs-filters {
flex: 0 1 20%;
@include breakpoint(tablet, min-width) {
padding-right: 2em;
}
// min-width on flex allows container to
// be more narrow than content if needed
min-width: 200px;
@include breakpoint(tablet, min-width) {
padding-right: 2em;
}
}
.docs-items {
padding: 0.57em 0 1.5em 0;
@ -93,23 +113,29 @@
height: 1em;
margin-right: 0.25em;
color: var(--primary-high);
&.d-icon-plus {
height: 0.75em;
margin-right: 0.25em;
}
}
&.selected .d-icon {
color: var(--primary);
}
&:hover {
background: var(--highlight-medium);
}
&.selected:hover {
background: var(--danger-low);
.d-icon {
color: var(--danger);
}
}
.tag-id,
.category-id {
margin-right: 3px;
@ -117,10 +143,12 @@
text-overflow: ellipsis;
}
}
.selected {
font-weight: bold;
}
}
.docs-topic-list {
flex-basis: 100%;
@ -153,21 +181,26 @@
font-weight: normal;
font-size: $font-down-1;
}
.raw-topic-link {
color: var(--tertiary);
cursor: pointer;
display: inline-block;
word-break: break-word;
& > * {
pointer-events: none;
}
}
}
.docs-topic {
display: flex;
flex-direction: column;
.docs-nav-link {
font-weight: 700;
&.return {
align-items: center;
background: none;
@ -176,24 +209,30 @@
font-size: $font-0;
justify-content: normal;
padding: 0;
&::before {
content: "«";
margin-right: 5px;
}
}
&.more {
font-size: $font-up-1;
padding: 10px 0;
}
}
.topic-content {
padding-top: 10px;
h1 {
line-height: $line-height-medium;
}
.lightbox-wrapper img {
max-width: 100%;
}
code,
pre {
// Prevent pre from being wider than viewport
@ -216,15 +255,19 @@
.item-controls {
display: flex;
justify-content: space-between;
.btn {
background-color: transparent;
padding: 0.25em;
svg {
color: var(--primary-high);
}
&:hover,
&.active {
background-color: var(--secondary-very-high);
svg {
color: var(--primary-high);
}
@ -232,12 +275,11 @@
height: 28px;
}
}
}
.docs-items {
input {
width: 100%;
}
ul {
margin: 0;
list-style: none;
@ -249,6 +291,7 @@
#main > div {
grid-template-columns: 0 1fr;
}
.has-sidebar,
.docs-search,
.alert,
@ -256,6 +299,7 @@
#skip-link {
display: none;
}
.docs-topic {
.docs-nav-link.return,
.docs-nav-link.more {
@ -267,19 +311,12 @@
.docs-solved {
padding: 0;
input {
width: auto;
}
.docs-item {
width: 100%;
}
}
// TODO: Remove once legacy topic-list is removed
.docs-browse {
.topic-list-data.replies,
.topic-list-data.posts,
.topic-list-data.views {
display: none;
}
}

View File

@ -13,21 +13,27 @@
width: calc(100vw - 2em);
}
}
.docs-browse {
padding-bottom: 60px; // for DiscourseHub footer nav
.docs-items {
padding-right: 0;
}
flex-direction: column;
.docs-results .result-count {
padding-left: 0;
}
.docs-topic-list {
flex-basis: 100%;
}
.raw-topic-link {
padding-right: 0.25em;
}
.docs-topic {
width: calc(100vw - 20px);
}
@ -37,9 +43,11 @@
.docs-filters {
background: var(--primary-very-low);
padding: 0 0.5em;
.docs-items:first-of-type {
margin-top: 1em;
}
+ .docs-results {
margin-top: 2em;
}

View File

@ -1,10 +1,11 @@
{
"private": true,
"devDependencies": {
"@discourse/lint-configs": "2.4.0",
"@discourse/lint-configs": "2.7.0",
"ember-template-lint": "6.1.0",
"eslint": "9.19.0",
"prettier": "2.8.8"
"eslint": "9.20.1",
"prettier": "2.8.8",
"stylelint": "16.14.1"
},
"engines": {
"node": ">= 22",

File diff suppressed because it is too large Load Diff

3
stylelint.config.mjs Normal file
View File

@ -0,0 +1,3 @@
export default {
extends: ["@discourse/lint-configs/stylelint"],
};